public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "ro at CeBiTec dot Uni-Bielefeld.DE" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug testsuite/112729] gcc.target/i386/apx-interrupt-1.c etc. FAIL
Date: Tue, 28 Nov 2023 12:11:49 +0000	[thread overview]
Message-ID: <bug-112729-4-NllrOZ98ui@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-112729-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112729

--- Comment #5 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #3 from Hongyu Wang <wwwhhhyyy333 at gmail dot com> ---
[...]
> Hi Rainer, can you help verify if the change make these test pass on
> solaris/FreeBSD?

They do on Solaris/x86.  Thanks.

FreeBSD was more involved (I'd only noticed the failure there on
gcc-testresults).  Unfortunately, there's no FreeBSD/x86_64 system in
the cfarm.  However, I had an old FreeBSD 13 VM around which could be
coaxed into a gcc build with some effort.  With your patch, the failures
are gone there, too.

One nit:

diff --git a/gcc/testsuite/gcc.target/i386/apx-push2pop2-1.c
b/gcc/testsuite/gcc.target/i386/apx-push2pop2-1.c
index d78c96d36a3..1d73aab1128 100644
--- a/gcc/testsuite/gcc.target/i386/apx-push2pop2-1.c
+++ b/gcc/testsuite/gcc.target/i386/apx-push2pop2-1.c
@@ -1,5 +1,5 @@
 /* { dg-do compile { target { ! ia32 } } } */
-/* { dg-options "-O2 -mapx-features=push2pop2" } */
+/* { dg-options "-O2 -fomit-frame-pointer -mapx-features=push2pop2" } */
 /* { dg-skip-if "does not emit .cfi_xxx" "*-*-darwin*" } */

 extern int bar (int);
diff --git a/gcc/testsuite/gcc.target/i386/apx-push2pop2_force_drap-1.c
b/gcc/testsuite/gcc.target/i386/apx-push2pop2_force_drap-1.c
index 3cac7b10769..4e2259f0c99 100644
--- a/gcc/testsuite/gcc.target/i386/apx-push2pop2_force_drap-1.c
+++ b/gcc/testsuite/gcc.target/i386/apx-push2pop2_force_drap-1.c
@@ -1,5 +1,5 @@
 /* { dg-do compile { target { ! ia32 } } } */
-/* { dg-options "-O2 -mapx-features=push2pop2 -mforce-drap" } */
+/* { dg-options "-O2 -mapx-features=push2pop2 -fomit-frame-pointer
-mforce-drap" } */
 /* { dg-skip-if "does not emit .cfi_xxx" "*-*-darwin*" } */

 #include "apx-push2pop2-1.c"

Is there a reason to have -fomit-frame-pointer once before and once
after -mapx-features=push2pop2?

  parent reply	other threads:[~2023-11-28 12:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-27 15:10 [Bug testsuite/112729] New: " ro at gcc dot gnu.org
2023-11-27 15:10 ` [Bug testsuite/112729] " ro at gcc dot gnu.org
2023-11-27 15:14 ` ro at gcc dot gnu.org
2023-11-28  2:47 ` wwwhhhyyy333 at gmail dot com
2023-11-28  3:33 ` wwwhhhyyy333 at gmail dot com
2023-11-28 12:06 ` ro at CeBiTec dot Uni-Bielefeld.DE
2023-11-28 12:11 ` ro at CeBiTec dot Uni-Bielefeld.DE [this message]
2023-11-28 12:27 ` ro at gcc dot gnu.org
2023-11-28 13:34 ` wwwhhhyyy333 at gmail dot com
2023-11-29  0:52 ` cvs-commit at gcc dot gnu.org
2023-11-29 13:52 ` cvs-commit at gcc dot gnu.org
2023-11-29 13:57 ` ro at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-112729-4-NllrOZ98ui@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).