public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug target/112753] New: [14 Regression] unrecognizable insn building glibc for s390x
@ 2023-11-28 22:42 jsm28 at gcc dot gnu.org
2023-11-29 6:55 ` [Bug target/112753] " rguenth at gcc dot gnu.org
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: jsm28 at gcc dot gnu.org @ 2023-11-28 22:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112753
Bug ID: 112753
Summary: [14 Regression] unrecognizable insn building glibc for
s390x
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Keywords: ice-on-valid-code
Severity: normal
Priority: P3
Component: target
Assignee: unassigned at gcc dot gnu.org
Reporter: jsm28 at gcc dot gnu.org
CC: jchrist at linux dot ibm.com
Target Milestone: ---
Target: s390*-*-*
Created attachment 56709
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56709&action=edit
preprocessed source
An ICE building glibc for s390x-linux-gnu was introduced by the commit
commit 466b100e5fee808d77598e0f294654deec281150
Author: Juergen Christ <jchrist@linux.ibm.com>
Date: Mon Nov 20 09:13:10 2023 +0100
s390: implement flags output
Compile the attached test with -O2.
In file included from ../sysdeps/ieee754/ldbl-64-128/strtold_l.c:58:
./strtod_l.c: In function 'round_and_return':
./strtod_l.c:356:1: error: unrecognizable insn:
(insn 252 251 253 30 (set (reg:FPRX2 187)
(subreg:FPRX2 (reg:TF 186) 0)) "./strtod_l.c":309:218 discrim 1 -1
(nil))
during RTL pass: vregs
./strtod_l.c:356:1: internal compiler error: in extract_insn, at recog.cc:2804
0x6f8bb8 _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
/scratch/jmyers/glibc/many14/src/gcc/gcc/rtl-error.cc:108
0x6f8bda _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
/scratch/jmyers/glibc/many14/src/gcc/gcc/rtl-error.cc:116
0x6f759b extract_insn(rtx_insn*)
/scratch/jmyers/glibc/many14/src/gcc/gcc/recog.cc:2804
0xb85405 instantiate_virtual_regs_in_insn
/scratch/jmyers/glibc/many14/src/gcc/gcc/function.cc:1610
0xb85405 instantiate_virtual_regs
/scratch/jmyers/glibc/many14/src/gcc/gcc/function.cc:1993
0xb85405 execute
/scratch/jmyers/glibc/many14/src/gcc/gcc/function.cc:2040
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/112753] [14 Regression] unrecognizable insn building glibc for s390x
2023-11-28 22:42 [Bug target/112753] New: [14 Regression] unrecognizable insn building glibc for s390x jsm28 at gcc dot gnu.org
@ 2023-11-29 6:55 ` rguenth at gcc dot gnu.org
2023-11-30 20:29 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-11-29 6:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112753
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P3 |P1
Target Milestone|--- |14.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/112753] [14 Regression] unrecognizable insn building glibc for s390x
2023-11-28 22:42 [Bug target/112753] New: [14 Regression] unrecognizable insn building glibc for s390x jsm28 at gcc dot gnu.org
2023-11-29 6:55 ` [Bug target/112753] " rguenth at gcc dot gnu.org
@ 2023-11-30 20:29 ` jakub at gcc dot gnu.org
2023-11-30 21:03 ` jakub at gcc dot gnu.org
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2023-11-30 20:29 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112753
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jakub at gcc dot gnu.org
--- Comment #1 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
I think
--- gcc/config/s390/s390.cc.jj 2023-11-30 21:18:50.678840298 +0100
+++ gcc/config/s390/s390.cc 2023-11-30 21:27:28.952545221 +0100
@@ -17604,6 +17604,10 @@ s390_md_asm_adjust (vec<rtx> &outputs, v
outputs[i] = fprx2;
}
+ if (!TARGET_VXE)
+ /* Long doubles are stored in FPR pairs - nothing to do. */
+ return after_md_seq;
+
for (unsigned i = 0; i < ninputs; i++)
{
if (GET_MODE (inputs[i]) != TFmode)
should fix this.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/112753] [14 Regression] unrecognizable insn building glibc for s390x
2023-11-28 22:42 [Bug target/112753] New: [14 Regression] unrecognizable insn building glibc for s390x jsm28 at gcc dot gnu.org
2023-11-29 6:55 ` [Bug target/112753] " rguenth at gcc dot gnu.org
2023-11-30 20:29 ` jakub at gcc dot gnu.org
@ 2023-11-30 21:03 ` jakub at gcc dot gnu.org
2023-12-01 7:19 ` cvs-commit at gcc dot gnu.org
2023-12-01 11:55 ` jakub at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2023-11-30 21:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112753
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org
Last reconfirmed| |2023-11-30
Status|UNCONFIRMED |ASSIGNED
Ever confirmed|0 |1
--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 56737
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56737&action=edit
gcc14-pr112753.patch
Full patch I'm going to bootstrap/regtest now.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/112753] [14 Regression] unrecognizable insn building glibc for s390x
2023-11-28 22:42 [Bug target/112753] New: [14 Regression] unrecognizable insn building glibc for s390x jsm28 at gcc dot gnu.org
` (2 preceding siblings ...)
2023-11-30 21:03 ` jakub at gcc dot gnu.org
@ 2023-12-01 7:19 ` cvs-commit at gcc dot gnu.org
2023-12-01 11:55 ` jakub at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-12-01 7:19 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112753
--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Andreas Krebbel <krebbel@gcc.gnu.org>:
https://gcc.gnu.org/g:8a2e428591dc97d573cf5c1789c84c8a3884b364
commit r14-6040-g8a2e428591dc97d573cf5c1789c84c8a3884b364
Author: Juergen Christ <jchrist@linux.ibm.com>
Date: Fri Dec 1 08:01:36 2023 +0100
s390x: Fix s390_md_asm_adjust handling of long doubles [PR112753]
Commit 466b100e5fee808d77598e0f294654deec281150 introduced a bug in
s390_md_asm_adjust if vector extensions are not available. Fix the
control flow of this function to not adjust long double values.
gcc/ChangeLog:
PR target/112753
* config/s390/s390.cc (s390_md_asm_adjust): Return after dealing
with the outputs, if no further processing of long doubles is
required.
gcc/testsuite/ChangeLog:
* gcc.target/s390/pr112753.c: New test.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug target/112753] [14 Regression] unrecognizable insn building glibc for s390x
2023-11-28 22:42 [Bug target/112753] New: [14 Regression] unrecognizable insn building glibc for s390x jsm28 at gcc dot gnu.org
` (3 preceding siblings ...)
2023-12-01 7:19 ` cvs-commit at gcc dot gnu.org
@ 2023-12-01 11:55 ` jakub at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2023-12-01 11:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112753
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|jakub at gcc dot gnu.org |unassigned at gcc dot gnu.org
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-01 11:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-28 22:42 [Bug target/112753] New: [14 Regression] unrecognizable insn building glibc for s390x jsm28 at gcc dot gnu.org
2023-11-29 6:55 ` [Bug target/112753] " rguenth at gcc dot gnu.org
2023-11-30 20:29 ` jakub at gcc dot gnu.org
2023-11-30 21:03 ` jakub at gcc dot gnu.org
2023-12-01 7:19 ` cvs-commit at gcc dot gnu.org
2023-12-01 11:55 ` jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).