[Bug fortran/112764] New: Associating entity does not have target attribute if selector has pointer attribute in associate block

[Bug fortran/112764] New: Associating entity does not have target attribute if selector has pointer attribute in associate block

[mscfd at gmx dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112764

            Bug ID: 112764
           Summary: Associating entity does not have target attribute if
                    selector has pointer attribute in associate block
           Product: gcc
           Version: 13.1.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: fortran
          Assignee: unassigned at gcc dot gnu.org
          Reporter: mscfd at gmx dot net
  Target Milestone: ---

The selector has the pointer attribute but association is with an array
section. The associating entity should have the target attribute even in this
case, right? gfortran complains with "Pointer assignment target is neither
TARGET nor POINTER", ifort and ifx accept it. Looks like a bug in gfortran, or
has i1 indeed no target attribute?



program assoc_target

implicit none

integer, dimension(:,:), pointer :: x
integer, pointer :: j

allocate(x(1:100,1:2), source=0)
associate(i1 => x(:,1))
   j => i1(1)
   print *, j
end associate
deallocate(x)

end program assoc_target

[Bug fortran/112764] Associating entity does not have target attribute if selector has pointer attribute in associate block

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112764

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-11-29
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from anlauf at gcc dot gnu.org ---
Confirmed.

F2018:11.1.3.3 has:

"The associating entity does not have the ALLOCATABLE or POINTER attributes;
it has the TARGET attribute if and only if the selector is a variable and has
either the TARGET or POINTER attribute."

[Bug fortran/112764] Associating entity does not have target attribute if selector has pointer attribute in associate block

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112764

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |anlauf at gcc dot gnu.org

--- Comment #2 from anlauf at gcc dot gnu.org ---
Created attachment 56723
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56723&action=edit
Untested patch

The attached patch fixes the issue.  Needs regtesting.

[Bug fortran/112764] Associating entity does not have target attribute if selector has pointer attribute in associate block

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112764

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |rejects-valid
                 CC|                            |pault at gcc dot gnu.org

--- Comment #3 from anlauf at gcc dot gnu.org ---
CC'ing Paul.  He's the expert on ASSOCIATE issues.

[Bug fortran/112764] Associating entity does not have target attribute if selector has pointer attribute in associate block

[mscfd at gmx dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112764

--- Comment #4 from martin <mscfd at gmx dot net> ---
(In reply to anlauf from comment #1)
> Confirmed.
> 
> F2018:11.1.3.3 has:
> 
> "The associating entity does not have the ALLOCATABLE or POINTER attributes;
> it has the TARGET attribute if and only if the selector is a variable and has
> either the TARGET or POINTER attribute."

I was not sure, whether this formulation also covers array sections.
Anyway, thanks for the fast reply!

[Bug fortran/112764] Associating entity does not have target attribute if selector has pointer attribute in associate block

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112764

--- Comment #5 from anlauf at gcc dot gnu.org ---
(In reply to martin from comment #4)
> (In reply to anlauf from comment #1)
> > Confirmed.
> > 
> > F2018:11.1.3.3 has:
> > 
> > "The associating entity does not have the ALLOCATABLE or POINTER attributes;
> > it has the TARGET attribute if and only if the selector is a variable and has
> > either the TARGET or POINTER attribute."
> 
> I was not sure, whether this formulation also covers array sections.

The following example has apparently always been legal, is accepted and works:

  integer, pointer             :: x, y(:)
  integer, allocatable, target :: z(:)
  allocate (y(2), z(3))
  y = 42
  x => y(2)
  print *,x
  z = 23
  x => z(2)
  print *,x
end

I think this is covered by F2018:8.5.17 TARGET attribute, although I find
the text somewhat hard to understand.  Like:

"If an object has the TARGET attribute, then all of its nonpointer subobjects
also have the TARGET attribute."

IIUC that would cover array sections.

[Bug fortran/112764] Associating entity does not have target attribute if selector has pointer attribute in associate block

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112764

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |anlauf at gcc dot gnu.org

--- Comment #6 from anlauf at gcc dot gnu.org ---
Submitted: https://gcc.gnu.org/pipermail/fortran/2023-November/059974.html

[Bug fortran/112764] Associating entity does not have target attribute if selector has pointer attribute in associate block

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112764

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Harald Anlauf <anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:951a3e3749a9bf15cea3940ad4bd76d696e1b0b6

commit r14-6011-g951a3e3749a9bf15cea3940ad4bd76d696e1b0b6
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Wed Nov 29 21:47:24 2023 +0100

    Fortran: fix TARGET attribute of associating entity in ASSOCIATE [PR112764]

    The associating entity in an ASSOCIATE construct has the TARGET attribute
    if and only if the selector is a variable and has either the TARGET or
    POINTER attribute (e.g. F2018:11.1.3.3).

    gcc/fortran/ChangeLog:

            PR fortran/112764
            * primary.cc (gfc_variable_attr): Set TARGET attribute of
associating
            entity dependent on TARGET or POINTER attribute of selector.

    gcc/testsuite/ChangeLog:

            PR fortran/112764
            * gfortran.dg/associate_62.f90: New test.

[Bug fortran/112764] Associating entity does not have target attribute if selector has pointer attribute in associate block

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112764

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Harald Anlauf
<anlauf@gcc.gnu.org>:

https://gcc.gnu.org/g:dd5d399fc16ebe7a1a2b13ae8cb888d619af695c

commit r13-8110-gdd5d399fc16ebe7a1a2b13ae8cb888d619af695c
Author: Harald Anlauf <anlauf@gmx.de>
Date:   Wed Nov 29 21:47:24 2023 +0100

    Fortran: fix TARGET attribute of associating entity in ASSOCIATE [PR112764]

    The associating entity in an ASSOCIATE construct has the TARGET attribute
    if and only if the selector is a variable and has either the TARGET or
    POINTER attribute (e.g. F2018:11.1.3.3).

    gcc/fortran/ChangeLog:

            PR fortran/112764
            * primary.cc (gfc_variable_attr): Set TARGET attribute of
associating
            entity dependent on TARGET or POINTER attribute of selector.

    gcc/testsuite/ChangeLog:

            PR fortran/112764
            * gfortran.dg/associate_62.f90: New test.

    (cherry picked from commit 951a3e3749a9bf15cea3940ad4bd76d696e1b0b6)

[Bug fortran/112764] Associating entity does not have target attribute if selector has pointer attribute in associate block

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112764

anlauf at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
   Target Milestone|---                         |13.3
         Resolution|---                         |FIXED

--- Comment #9 from anlauf at gcc dot gnu.org ---
Fixed on mainline for gcc-14, and backported to 13-branch.  Closing.

Thanks for the report!

[Bug fortran/112764] Associating entity does not have target attribute if selector has pointer attribute in associate block

[mscfd at gmx dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112764

--- Comment #10 from martin <mscfd at gmx dot net> ---
Thanks for the speedy fix! I just thought about a variation, which should now
with the fix work as well (was not yet able to compile current dev branch, so
cannot check myself):


program assoc_ptr_in

implicit none

integer, dimension(:,:), pointer :: x
integer, pointer :: j

allocate(x(1:100,1:2), source=123)
associate(i1 => x(:,1))
   call sub(i1)
end associate
deallocate(x)

contains

subroutine sub(j)
   integer, dimension(:), pointer, intent(in) :: j
   print *,j(1)
end subroutine sub

end program assoc_ptr_in

[Bug fortran/112764] Associating entity does not have target attribute if selector has pointer attribute in associate block

[anlauf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112764

--- Comment #11 from anlauf at gcc dot gnu.org ---
(In reply to martin from comment #10)
> Thanks for the speedy fix! I just thought about a variation, which should
> now with the fix work as well (was not yet able to compile current dev
> branch, so cannot check myself):
> 
> 
> program assoc_ptr_in

This compiles now and prints:

         123