[Bug c++/112793] New: [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[Bug c++/112793] New: [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

            Bug ID: 112793
           Summary: [14 regression] ICE when building stellarium (internal
                    compiler error: in vect_schedule_slp_node, at
                    tree-vect-slp.cc:9062)
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
  Target Milestone: ---

Created attachment 56738
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56738&action=edit
StelObserver.cpp.ii.xz

Originally reported downstream in Gentoo by Toralf Förster at
https://bugs.gentoo.org/918911.

```
FAILED: src/CMakeFiles/stelMain.dir/core/StelObserver.cpp.o
/usr/lib/ccache/bin/x86_64-pc-linux-gnu-g++ -DCOPYRIGHT_YEARS=\"2000-2023\"
-DENABLE_NLS -DENABLE_SCRIPTING -DENABLE_SCRIPT_CONSOLE -DENABLE_SHOWMYSKY
-DENABLE_XLSX -DINSTALL_DATADIR=\"/usr/share/stellarium\"
 -DNDEBUG -DPACKAGE_VERSION=\"23.3.0\" -DQT_CHARTS_LIB -DQT_CONCURRENT_LIB
-DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB
-DQT_SCRIPT_LIB -DQT_WIDGETS_LIB -DQXlsx_SHAREDLIB -DSTELLA
RIUM_COPYRIGHT="\"Copyright (C) 2000-2023 Stellarium Developers\""
-DSTELLARIUM_DEV_URL=\"https://github.com/Stellarium/stellarium\"
-DSTELLARIUM_MAJOR=23 -DSTELLARIUM_MINOR=3 -DSTELLARIUM_PATCH=0 -DSTELLARIU
M_PUBLIC_VERSION=\"23.3\" -DSTELLARIUM_RELEASE_BUILD
-DSTELLARIUM_SERIES=\"23.0\"
-DSTELLARIUM_SOURCE_DIR=\"/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3\"
-DSTELLARIUM_URL=\"https://ste
llarium.org/\" -DUSE_STATIC_PLUGIN_ANGLEMEASURE
-DUSE_STATIC_PLUGIN_ARCHAEOLINES -DUSE_STATIC_PLUGIN_CALENDARS
-DUSE_STATIC_PLUGIN_EQUATIONOFTIME -DUSE_STATIC_PLUGIN_EXOPLANETS
-DUSE_STATIC_PLUGIN_METEORSHOWE
RS -DUSE_STATIC_PLUGIN_MISSINGSTARS -DUSE_STATIC_PLUGIN_NAVSTARS
-DUSE_STATIC_PLUGIN_NOVAE -DUSE_STATIC_PLUGIN_OBSERVABILITY
-DUSE_STATIC_PLUGIN_OCULARS -DUSE_STATIC_PLUGIN_ONLINEQUERIES
-DUSE_STATIC_PLUGIN_P
OINTERCOORDINATES -DUSE_STATIC_PLUGIN_PULSARS -DUSE_STATIC_PLUGIN_QUASARS
-DUSE_STATIC_PLUGIN_REMOTECONTROL -DUSE_STATIC_PLUGIN_REMOTESYNC
-DUSE_STATIC_PLUGIN_SATELLITES -DUSE_STATIC_PLUGIN_SCENERY3D -DUSE_ST
ATIC_PLUGIN_SOLARSYSTEMEDITOR -DUSE_STATIC_PLUGIN_SUPERNOVAE
-D_USE_MATH_DEFINES
-I/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3_build/src
-I/var/tmp/portage/sci-astronomy/stellarium-23.
3/work/stellarium-23.3/src
-I/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3_build/src/stelMain_autogen/include
-I/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3_build
-I/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3/src/core
-I/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3/src/core/modules
-I/var/tmp/portage/sci-astronomy/stellariu
m-23.3/work/stellarium-23.3/src/core/planetsephems
-I/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3/src/gui
-I/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3/src/scrip
ting
-I/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3/src/external/glues_stel/source
-I/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3/plugins/RemoteControl/src/../inc
lude -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtGui -isystem
/usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem
/usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtNetwor
k -isystem /usr/include/qt5/QtCharts -isystem /usr/include/qt5/QtGui/5.15.11
-isystem /usr/include/qt5/QtGui/5.15.11/QtGui -isystem
/usr/include/qt5/QtCore/5.15.11 -isystem /usr/include/qt5/QtCore/5.15.11/QtC
ore -isystem /usr/include/qt5/QtConcurrent -isystem /usr/include/qt5/QtOpenGL
-isystem /usr/include/qt5/QtScript -isystem /usr/include/QXlsxQt5 -DQT_NO_DEBUG
-O3 -march=native -fno-semantic-interposition -pip
e -Wa,-O2 -Wa,-mtune=znver2 -fcf-protection=none -fdiagnostics-color=always
-fdiagnostics-urls=never -frecord-gcc-switches -ggdb3 -Werror=format-security
-Wformat -Wall -Wextra -Wno-unused-parameter -Wno-unkn
own-pragmas -Wno-unused-result -std=c++17 -fdiagnostics-color=always -fPIC
-Winvalid-pch -include
/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3_build/src/CMakeFiles/stelMain.dir/cmake_pc
h.hxx -MD -MT src/CMakeFiles/stelMain.dir/core/StelObserver.cpp.o -MF
src/CMakeFiles/stelMain.dir/core/StelObserver.cpp.o.d -o
src/CMakeFiles/stelMain.dir/core/StelObserver.cpp.o -c
/var/tmp/portage/sci-astro
nomy/stellarium-23.3/work/stellarium-23.3/src/core/StelObserver.cpp
during GIMPLE pass: slp
/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3/src/core/StelObserver.cpp:
In member function ‘Mat4d StelObserver::getRotAltAzToEquatorial(double, double)
const’:
/var/tmp/portage/sci-astronomy/stellarium-23.3/work/stellarium-23.3/src/core/StelObserver.cpp:222:7:
internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062
  222 | Mat4d StelObserver::getRotAltAzToEquatorial(double JD, double JDE)
const
      |       ^~~~~~~~~~~~
0x55b5bd834542 vect_schedule_slp_node
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:9062
0x55b5bf30b407 vect_schedule_scc
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:9455
0x55b5bf30b2d5 vect_schedule_scc
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:9472
0x55b5bf30b2d5 vect_schedule_scc
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:9472
0x55b5bf30b2d5 vect_schedule_scc
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:9472
0x55b5beff4b34 vect_schedule_slp(vec_info*, vec<_slp_instance*, va_heap,
vl_ptr> const&)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:9636
0x55b5bedba03c vect_slp_region
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:7770
0x55b5bedb6983 vect_slp_bbs
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:7870
0x55b5bedb6298 vect_slp_function(function*)
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vect-slp.cc:7949
0x55b5bedb565c execute
       
/usr/src/debug/sys-devel/gcc-14.0.0.9999/gcc-14.0.0.9999/gcc/tree-vectorizer.cc:1531
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

'g++ -c StelObserver.cpp.ii -march=znver2 -O2' is enough to reproduce.

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Hmm __builtin_ctzs ....

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Does gentoo has a patch which adds __builtin_ctzs ?

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

--- Comment #3 from Sam James <sjames at gcc dot gnu.org> ---
(In reply to Andrew Pinski from comment #2)
> Does gentoo has a patch which adds __builtin_ctzs ?

No, nothing like that. Here's what this one was built with:
https://gitweb.gentoo.org/proj/gcc-patches.git/tree/14.0.0/gentoo

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

--- Comment #4 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
With s/__builtin_ctzs/__builtin_ctzg/ and `-O3 -march=skylake-avx512`, I can
reproduce it with an unmodified trunk GCC.

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

--- Comment #5 from Sam James <sjames at gcc dot gnu.org> ---
Created attachment 56744
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56744&action=edit
reduced.ii

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Sam James from comment #5)
> Created attachment 56744 [details]
> reduced.ii

Note this reduced testcase has undefined code in it ...

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
e.g. r[8 * 2] is r[16] and 16 >= 16 :).

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #56744|0                           |1
        is obsolete|                            |

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 56745
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56745&action=edit
testcase without any undefinedness to it

Further reduced and without any undefined/uninitialized variables in it (as far
as I can tell):

Note I added a `#if 0` section which produces almost the same IR (except ssa
names are different) from the other but does not produce an ICE. I don't
understand why though.

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-12-01
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW

--- Comment #9 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
.

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

--- Comment #10 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 56746
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56746&action=edit
Delta reduced testcase

This one is slightly less reduced than the other one but this is a delta based
reduced testcase rather than a cvise based one. I didn't manually reduce it
further though.

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

--- Comment #11 from Sam James <sjames at gcc dot gnu.org> ---
Created attachment 56747
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56747&action=edit
another cvised testcase

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
   Target Milestone|---                         |14.0

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed, mine.  We're scheduling the same SLP node twice from different SLP
instances.  We're supposed to merge SLP instances which share nodes though,
but we're only doing that for internal defs.  We need to either duplicate
the constant/external nodes in different subgraphs or merge subgraphs
with common constants/externals as well.

I'll think about it.

This isn't new in GCC 14, it should be a problem since GCC 11.

[Bug tree-optimization/112793] [14 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

--- Comment #13 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:d782ec8362eadc3169286eb1e39c631effd02323

commit r14-6550-gd782ec8362eadc3169286eb1e39c631effd02323
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Dec 13 14:23:31 2023 +0100

    tree-optimization/112793 - SLP of constant/external code-generated twice

    The following makes the attempt at code-generating a constant/external
    SLP node twice well-formed as that can happen when partitioning BB
    vectorization attempts where we keep constants/externals unpartitioned.

            PR tree-optimization/112793
            * tree-vect-slp.cc (vect_schedule_slp_node): Already
            code-generated constant/external nodes are OK.

            * g++.dg/vect/pr112793.cc: New testcase.

[Bug tree-optimization/112793] [11/12/13 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|14.0                        |11.5
            Summary|[14 regression] ICE when    |[11/12/13 regression] ICE
                   |building stellarium         |when building stellarium
                   |(internal compiler error:   |(internal compiler error:
                   |in vect_schedule_slp_node,  |in vect_schedule_slp_node,
                   |at tree-vect-slp.cc:9062)   |at tree-vect-slp.cc:9062)
      Known to work|                            |14.0
           Priority|P3                          |P2

--- Comment #14 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk.  As said, I think the issue is latent so I'm marking it for
backporting.

[Bug tree-optimization/112793] [11/12/13 regression] ICE when building stellarium (internal compiler error: in vect_schedule_slp_node, at tree-vect-slp.cc:9062)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112793

--- Comment #15 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:42d5985e9884299c8d837ad1588fb47b211b4baf

commit r13-8485-g42d5985e9884299c8d837ad1588fb47b211b4baf
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Dec 13 14:23:31 2023 +0100

    tree-optimization/112793 - SLP of constant/external code-generated twice

    The following makes the attempt at code-generating a constant/external
    SLP node twice well-formed as that can happen when partitioning BB
    vectorization attempts where we keep constants/externals unpartitioned.

            PR tree-optimization/112793
            * tree-vect-slp.cc (vect_schedule_slp_node): Already
            code-generated constant/external nodes are OK.

            * g++.dg/vect/pr112793.cc: New testcase.

    (cherry picked from commit d782ec8362eadc3169286eb1e39c631effd02323)