public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug middle-end/112830] internal compiler error: in convert_memory_address_addr_space_1, at explow.cc:302 Date: Tue, 05 Dec 2023 13:55:50 +0000 [thread overview] Message-ID: <bug-112830-4-YyyocoIEU7@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-112830-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112830 --- Comment #13 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>: https://gcc.gnu.org/g:68d32d02035fc081384ec6d6fd275e49ffa5d016 commit r14-6182-g68d32d02035fc081384ec6d6fd275e49ffa5d016 Author: Richard Biener <rguenther@suse.de> Date: Mon Dec 4 10:35:38 2023 +0100 middle-end/112830 - avoid gimplifying non-default addr-space assign to memcpy The following avoids turning aggregate copy involving non-default address-spaces to memcpy since that is not prepared for that. GIMPLE verification no longer accepts WITH_SIZE_EXPR in aggregate copies, the following re-allows that for the RHS. I also needed to adjust one assert in DCE. get_memory_address is used for string builtin expansion, so instead of fixing that up for non-generic address-spaces I've put an assert there. I'll note that the same issue exists for initialization from an empty CTOR which we gimplify to a memset call but since we are not prepared to handle RTL expansion of the original VLA init and I failed to provide test coverage (without extending the GNU C extension for VLA structs) and the Ada frontend (or other frontends) to not have address-space support the patch instead asserts we only see generic address-spaces there. PR middle-end/112830 * gimplify.cc (gimplify_modify_expr): Avoid turning aggregate copy of non-generic address-spaces to memcpy. (gimplify_modify_expr_to_memcpy): Assert we are dealing with a copy inside the generic address-space. (gimplify_modify_expr_to_memset): Likewise. * tree-cfg.cc (verify_gimple_assign_single): Allow WITH_SIZE_EXPR as part of the RHS of an assignment. * builtins.cc (get_memory_address): Assert we are dealing with the generic address-space. * tree-ssa-dce.cc (ref_may_be_aliased): Handle WITH_SIZE_EXPR. * gcc.target/avr/pr112830.c: New testcase. * gcc.target/i386/pr112830.c: Likewise.
next prev parent reply other threads:[~2023-12-05 13:55 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-12-03 12:22 [Bug middle-end/112830] New: " gjl at gcc dot gnu.org 2023-12-03 12:37 ` [Bug middle-end/112830] " gjl at gcc dot gnu.org 2023-12-03 22:17 ` pinskia at gcc dot gnu.org 2023-12-04 7:06 ` rguenth at gcc dot gnu.org 2023-12-04 8:40 ` rguenth at gcc dot gnu.org 2023-12-04 9:07 ` rguenth at gcc dot gnu.org 2023-12-04 9:08 ` rguenth at gcc dot gnu.org 2023-12-04 9:27 ` rguenth at gcc dot gnu.org 2023-12-04 11:56 ` rguenth at gcc dot gnu.org 2023-12-04 19:19 ` gjl at gcc dot gnu.org 2023-12-05 9:48 ` rguenth at gcc dot gnu.org 2023-12-05 10:54 ` rguenth at gcc dot gnu.org 2023-12-05 11:31 ` ebotcazou at gcc dot gnu.org 2023-12-05 13:55 ` cvs-commit at gcc dot gnu.org [this message] 2023-12-05 13:56 ` rguenth at gcc dot gnu.org 2023-12-05 20:46 ` gjl at gcc dot gnu.org 2023-12-06 7:33 ` rguenth at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-112830-4-YyyocoIEU7@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).