[Bug target/112861] New: [14 regression] Most gdc tests FAIL on macOS 12+

[Bug target/112861] New: [14 regression] Most gdc tests FAIL on macOS 12+

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112861

            Bug ID: 112861
           Summary: [14 regression] Most gdc tests FAIL on macOS 12+
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: iains at gcc dot gnu.org, ibuclaw at gcc dot gnu.org
  Target Milestone: ---
            Target: x86_64-apple-darwin2[1-3]

Between 20231013 and 20231027, many gdc tests started to FAIL on macOS 12+.
The symptoms are always the same:

dyld[21028]: Library not loaded: @rpath/libgphobos.4.dylib
  Referenced from: <738CAFF0-7060-3979-A909-9F484FB97A09>
/private/var/gcc/regression/master/14-gcc/build/gcc/testsuite/gdc/trivial.exe
  Reason: tried:
'/private/var/gcc/regression/master/14-gcc/build/gcc/testsuite/gdc/libgphobos.4.dylib'
(no such file),
'/private/var/gcc/regression/master/14-gcc/build/gcc/libgphobos.4.dylib' (no
such file),
'/System/Volumes/Preboot/Cryptexes/OS/private/var/gcc/regression/master/14-gcc/build/gcc/libgphobos.4.dylib'
(no such file),
'/private/var/gcc/regression/master/14-gcc/build/x86_64-apple-darwin23.1.0/libphobos/src/libgphobos.4.dylib'
(no such file),
'/System/Volumes/Preboot/Cryptexes/OS/private/var/gcc/regression/master/14-gcc/build/x86_64-apple-darwin23.1.0/libphobos/src/libgphobos.4.dylib'
(no such file), '/System/Volumes/Data/vol/gcc/lib/libgphobos.4.dylib' (no such
file),
'/System/Volumes/Preboot/Cryptexes/OS/System/Volumes/Data/vol/gcc/lib/libgphobos.4.dylib'
(no such file),
'/private/var/gcc/regression/master/14-gcc/build/gcc/testsuite/gdc/libgphobos.4.dylib'
(no such file),
'/private/var/gcc/regression/master/14-gcc/build/gcc/libgphobos.4.dylib' (no
such file),
'/System/Volumes/Preboot/Cryptexes/OS/private/var/gcc/regression/master/14-gcc/build/gcc/libgphobos.4.dylib'
(no such file),
'/private/var/gcc/regression/master/14-gcc/build/x86_64-apple-darwin23.1.0/libphobos/src/libgphobos.4.dylib'
(no such file),
'/System/Volumes/Preboot/Cryptexes/OS/private/var/gcc/regression/master/14-gcc/build/x86_64-apple-darwin23.1.0/libphobos/src/libgphobos.4.dylib'
(no such file), '/System/Volumes/Data/vol/gcc/lib/libgphobos.4.dylib' (no such
file),
'/System/Volumes/Preboot/Cryptexes/OS/System/Volumes/Data/vol/gcc/lib/libgphobos.4.dylib'
(no such file), '/usr/local/lib/libgphobos.4.dylib' (no such file),
'/usr/lib/libgphobos.4.dylib' (no such file, not in dyld cache)
FAIL: gdc.dg/debug/trivial.d -gdwarf-2 -g1 execution test

which is no wonder because libgphobos.4.dylib lives in
.../x86_64-apple-darwin23.1.0/libphobos/src/.libs, which is not in the list
above.

[Bug target/112861] [14 regression] Most gdc tests FAIL on macOS 12+

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112861

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug target/112861] [14 regression] Most gdc tests FAIL on macOS 12+

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112861

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-01-24
           Assignee|unassigned at gcc dot gnu.org      |iains at gcc dot gnu.org
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Iain Sandoe <iains at gcc dot gnu.org> ---
Created attachment 57201
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57201&action=edit
patch under test

works on x86_64 sonoma, with XC 15.1 CLT.
testing more widely,

[Bug target/112861] [14 regression] Most gdc tests FAIL on macOS 12+

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112861

--- Comment #2 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #1 from Iain Sandoe <iains at gcc dot gnu.org> ---
> Created attachment 57201
>   --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57201&action=edit
> patch under test
>
> works on x86_64 sonoma, with XC 15.1 CLT.
> testing more widely,

I've successfully tested the patch on both x86_64-apple-darwin23.2.0
with Xcode 15.1 CLT and x86_64-apple-darwin20.6.0 with Xcode 13.2 CLT.

macOS 11 results are clean as before, macOS 14 results almost so:

FAIL: gdc.dg/debug/trivial.d -gdwarf-2 -g3 (test for excess errors)
FAIL: gdc.dg/debug/trivial.d -gdwarf-2 -g3 -O (test for excess errors)
FAIL: gdc.dg/debug/trivial.d -gdwarf-2 -g3 -O3 (test for excess errors)

which are due a known dsymutil issue:

Excess errors:
warning: '.debug_macinfo' is not currently supported: file will be skipped
note: while processing
/private/var/folders/n9/ygx22vs12c5crsryv773x1k800021y/T/cc3IYcpb.o

Thanks.

[Bug target/112861] [14 regression] Most gdc tests FAIL on macOS 12+

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112861

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2024-January
                   |                            |/644140.html

--- Comment #3 from Iain Sandoe <iains at gcc dot gnu.org> ---
patch posted ;
https://gcc.gnu.org/pipermail/gcc-patches/2024-January/644140.html

[Bug target/112861] [14 regression] Most gdc tests FAIL on macOS 12+

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112861

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:

https://gcc.gnu.org/g:d1d144d80f27f7a027ec8a05758555e7aa45462f

commit r14-8522-gd1d144d80f27f7a027ec8a05758555e7aa45462f
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Wed Jan 24 08:05:01 2024 +0000

    testsuite, GDC: Update link flags [PR112861].

    The regressions here are because we do not generate a runpath for
    the uninstalled libstdc++.  This patch updates the link flags handling
    to simplify it.

    We need to add options to locate both libgphobos and libstdc++
    Usually '-L' options are added to point to the relevant directories for
    the uninstalled libraries.

    In cases where libraries are available as both shared and convenience
    some additional checks are made.

    For some targets -static-xxxx options are handled by specs substitution
    and need a '-B' option rather than '-L'.  For Darwin, when embedded
    runpaths are in use (the default for all versions after macOS 10.11),
    '-B' is also needed to provide the runpath.

    When '-B' is used, this results in a '-L' for each path that exists (so
    that appending a '-L' as well is a needless duplicate).  There are also
    cases where tools warn for duplicates, leading to spurious fails.
    Therefore the objective is to add a single -B/-L option for each needed
    path.

            PR target/112861

    gcc/testsuite/ChangeLog:

            * lib/gdc.exp: Decide on whether to present -B or -L to reference
            the paths to uninstalled libphobos and libstdc++ and use that to
            generate the link flags.

[Bug target/112861] [14 regression] Most gdc tests FAIL on macOS 12+

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112861

--- Comment #5 from Iain Sandoe <iains at gcc dot gnu.org> ---
I suppose we are going to have to consider back porting this, if we want to
avoid the same problems on open branches.

[Bug target/112861] Most gdc tests FAIL on macOS 12+

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112861

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[14 regression] Most gdc    |Most gdc tests FAIL on
                   |tests FAIL on macOS 12+     |macOS 12+

--- Comment #6 from Iain Sandoe <iains at gcc dot gnu.org> ---
this is fixed on trunk, but still evaluating whether it's needed for macOS13/14
on older branches - so leaving open for now.

[Bug target/112861] Most gdc tests FAIL on macOS 12+

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112861

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|14.0                        |14.2

--- Comment #7 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 14.1 is being released, retargeting bugs to GCC 14.2.