[Bug target/112864] New: [14 regression] Many libphobos tests FAIL on macOS 12+

[Bug target/112864] New: [14 regression] Many libphobos tests FAIL on macOS 12+

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112864

            Bug ID: 112864
           Summary: [14 regression] Many libphobos tests FAIL on macOS 12+
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: iains at gcc dot gnu.org, ibuclaw at gcc dot gnu.org
  Target Milestone: ---
            Target: x86_64-apple-darwin2[1-3]

Between 20231013 and 20231027, all libphobos tests started to FAIL on macOS
12+:

FAIL: libphobos.aa/test_aa.d (test for excess errors)
Excess errors:
ld: warning: duplicate -rpath
'/private/var/gcc/regression/master/14-gcc/build/x86_64-apple-darwin23.1.0/libphobos/src'
ignored

The duplication can be seen in the log:

Executing on host: /var/gcc/regression/master/14-gcc/build/./gcc/gdc
-B/var/gcc/regression/master/14-gcc/build/./gcc/
-B/vol/gcc/x86_64-apple-darwin23.1.0/bin/
-B/vol/gcc/x86_64-apple-darwin23.1.0/lib/ -isystem
/vol/gcc/x86_64-apple-darwin23.1.0/include -isystem
/vol/gcc/x86_64-apple-darwin23.1.0/sys-include -fchecking=1 -fmessage-length=0
-fno-show-column -Wall -g -O2 -fversion=Shared -fall-instantiations
-fpreview=dip1000 -fno-release -funittest -nostdinc
-B/var/gcc/regression/master/14-gcc/build/x86_64-apple-darwin23.1.0/libphobos/src
-I/var/gcc/regression/master/14-gcc/build/x86_64-apple-darwin23.1.0/libphobos/libdruntime
-I/vol/gcc/src/hg/master/local/libphobos/libdruntime
-I/vol/gcc/src/hg/master/local/libphobos/src 
/vol/gcc/src/hg/master/local/libphobos/testsuite/libphobos.aa/test_aa.d    
-fno-diagnostics-show-caret -fdiagnostics-color=never
-B/var/gcc/regression/master/14-gcc/build/x86_64-apple-darwin23.1.0/libphobos/src
-B/var/gcc/regression/master/14-gcc/build/x86_64-apple-darwin23.1.0/libphobos/libdruntime/gcc
-B/var/gcc/regression/master/14-gcc/build/x86_64-apple-darwin23.1.0/libphobos/src/.libs
-L/var/gcc/regression/master/14-gcc/build/x86_64-apple-darwin23.1.0/libphobos/src/.libs
 -lm  -o ./test_aa.exe    (timeout = 1200)

where there are three instances of -B.../libphobos/src.

PR target/112863 shows a similar issue.

[Bug target/112864] [14 regression] Many libphobos tests FAIL on macOS 12+

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112864

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug target/112864] [14 regression] Many libphobos tests FAIL on macOS 12+

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112864

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-01-28
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2024-January
                   |                            |/644143.html

--- Comment #1 from Iain Sandoe <iains at gcc dot gnu.org> ---
patch : https://gcc.gnu.org/pipermail/gcc-patches/2024-January/644143.html

[Bug target/112864] [14 regression] Many libphobos tests FAIL on macOS 12+

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112864

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:

https://gcc.gnu.org/g:f4aa644dbbbde8c97f41c8abfbb7925c2242e31f

commit r14-8734-gf4aa644dbbbde8c97f41c8abfbb7925c2242e31f
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Sat Jan 27 15:50:15 2024 +0000

    testsuite, libphobos: Update link flags [PR112864].

    The regressions here are primarily from duplicated '-B' additions.

    We remove the duplicate on the link line.
    We also make sure that platforms with extensions other than .so for
    shared libs will have the correct paths.

            PR target/112864

    libphobos/ChangeLog:

            * testsuite/lib/libphobos.exp: Use ${shlib_ext} instead of
            hard-wiring '.so'.
            * testsuite/testsuite_flags.in: Remove duplicate -B option
            for spec file path.

[Bug target/112864] [14 regression] Many libphobos tests FAIL on macOS 12+

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112864

--- Comment #3 from Iain Sandoe <iains at gcc dot gnu.org> ---
I suppose we are going to have to consider back porting this, if we want to
avoid the same problems on open branches.

[Bug target/112864] Many libphobos tests FAIL on macOS 12+

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112864

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[14 regression] Many        |Many libphobos tests FAIL
                   |libphobos tests FAIL on     |on macOS 12+
                   |macOS 12+                   |

--- Comment #4 from Iain Sandoe <iains at gcc dot gnu.org> ---
this is fixed on trunk, but still evaluating whether it's needed for macOS13/14
on older branches - (almost certainly for macOS14 + Xcode 15.1+)

[Bug target/112864] Many libphobos tests FAIL on macOS 12+

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112864

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|14.0                        |14.2

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
GCC 14.1 is being released, retargeting bugs to GCC 14.2.