[Bug target/112948] New: gcc/config/aarch64/aarch64-early-ra.cc:1953: possible cut'n'paste error ?

[Bug target/112948] New: gcc/config/aarch64/aarch64-early-ra.cc:1953: possible cut'n'paste error ?

[dcb314 at hotmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112948

            Bug ID: 112948
           Summary: gcc/config/aarch64/aarch64-early-ra.cc:1953: possible
                    cut'n'paste error ?
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: dcb314 at hotmail dot com
  Target Milestone: ---

Source code is

      if (group1->strided_polarity)
        group2->strided_polarity = group1->strided_polarity * pref;
      else if (group1->strided_polarity)
        group2->strided_polarity = group1->strided_polarity * pref;
      else

Here is static analyser cppcheck finding the problem:

gcc/config/aarch64/aarch64-early-ra.cc:1953:19: style: Expression is always
false because 'else if' condition matches previous condition at line 1951.
[multiCondition]

[Bug target/112948] gcc/config/aarch64/aarch64-early-ra.cc:1953: possible cut'n'paste error ?

[rsandifo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112948

Richard Sandiford <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2023-12-11
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |rsandifo at gcc dot gnu.org

--- Comment #1 from Richard Sandiford <rsandifo at gcc dot gnu.org> ---
Gah.

[Bug target/112948] gcc/config/aarch64/aarch64-early-ra.cc:1953: possible cut'n'paste error ?

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112948

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Richard Sandiford <rsandifo@gcc.gnu.org>:

https://gcc.gnu.org/g:81dfa84e35659bc8adff945e61b02bc76c4c7f1e

commit r14-6780-g81dfa84e35659bc8adff945e61b02bc76c4c7f1e
Author: Richard Sandiford <richard.sandiford@arm.com>
Date:   Thu Dec 21 10:20:19 2023 +0000

    aarch64: Fix cut-&-pasto in early RA pass [PR112948]

    As the PR notes, there was a cut-&-pasto in find_strided_accesses.
    I've not been able to find a testcase that shows the problem.

    gcc/
            PR target/112948
            * config/aarch64/aarch64-early-ra.cc (find_strided_accesses): Fix
            cut-&-pasto.

[Bug target/112948] gcc/config/aarch64/aarch64-early-ra.cc:1953: possible cut'n'paste error ?

[rsandifo at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112948

Richard Sandiford <rsandifo at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #3 from Richard Sandiford <rsandifo at gcc dot gnu.org> ---
Fixed.  Thanks for the report.