public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/112951] New: [14 Regression] cond_copysign, cond_len_copysign optab not documented
@ 2023-12-11 2:46 pinskia at gcc dot gnu.org
2023-12-11 2:49 ` [Bug middle-end/112951] " pinskia at gcc dot gnu.org
` (6 more replies)
0 siblings, 7 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-12-11 2:46 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112951
Bug ID: 112951
Summary: [14 Regression] cond_copysign, cond_len_copysign optab
not documented
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Keywords: documentation
Severity: normal
Priority: P3
Component: middle-end
Assignee: unassigned at gcc dot gnu.org
Reporter: pinskia at gcc dot gnu.org
CC: tnfchris at gcc dot gnu.org
Blocks: 101852
Target Milestone: ---
Found by my simple scripts in PR 101852.
r14-5285-gf30ecd8050444f added these 2 optabs but didn't document them.
Referenced Bugs:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101852
[Bug 101852] [meta-bug] some standard RTL names are not documented
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug middle-end/112951] [14 Regression] cond_copysign, cond_len_copysign optab not documented
2023-12-11 2:46 [Bug middle-end/112951] New: [14 Regression] cond_copysign, cond_len_copysign optab not documented pinskia at gcc dot gnu.org
@ 2023-12-11 2:49 ` pinskia at gcc dot gnu.org
2023-12-11 10:01 ` rguenth at gcc dot gnu.org
` (5 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-12-11 2:49 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112951
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |14.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug middle-end/112951] [14 Regression] cond_copysign, cond_len_copysign optab not documented
2023-12-11 2:46 [Bug middle-end/112951] New: [14 Regression] cond_copysign, cond_len_copysign optab not documented pinskia at gcc dot gnu.org
2023-12-11 2:49 ` [Bug middle-end/112951] " pinskia at gcc dot gnu.org
@ 2023-12-11 10:01 ` rguenth at gcc dot gnu.org
2023-12-11 16:45 ` [Bug middle-end/112951] [14 Regression] cond_copysign, cond_len_copysign optab not documented (added by r14-5285-gf30ecd8050444f) pinskia at gcc dot gnu.org
` (4 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: rguenth at gcc dot gnu.org @ 2023-12-11 10:01 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112951
Richard Biener <rguenth at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Ever confirmed|0 |1
Priority|P3 |P1
Last reconfirmed| |2023-12-11
Status|UNCONFIRMED |NEW
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug middle-end/112951] [14 Regression] cond_copysign, cond_len_copysign optab not documented (added by r14-5285-gf30ecd8050444f)
2023-12-11 2:46 [Bug middle-end/112951] New: [14 Regression] cond_copysign, cond_len_copysign optab not documented pinskia at gcc dot gnu.org
2023-12-11 2:49 ` [Bug middle-end/112951] " pinskia at gcc dot gnu.org
2023-12-11 10:01 ` rguenth at gcc dot gnu.org
@ 2023-12-11 16:45 ` pinskia at gcc dot gnu.org
2023-12-21 19:40 ` pinskia at gcc dot gnu.org
` (3 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-12-11 16:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112951
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note the order of where the optab was added seems wrong:
```
OPTAB_D (cond_neg_optab, "cond_neg$a")
+OPTAB_D (cond_copysign_optab, "cond_copysign$F$a")
OPTAB_D (cond_one_cmpl_optab, "cond_one_cmpl$a")
```
It is placed inbetween the 2 optabs that are documented together:
```
@cindex @code{cond_neg@var{mode}} instruction pattern
@cindex @code{cond_one_cmpl@var{mode}} instruction pattern
@item @samp{cond_neg@var{mode}}
@itemx @samp{cond_one_cmpl@var{mode}}
```
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug middle-end/112951] [14 Regression] cond_copysign, cond_len_copysign optab not documented (added by r14-5285-gf30ecd8050444f)
2023-12-11 2:46 [Bug middle-end/112951] New: [14 Regression] cond_copysign, cond_len_copysign optab not documented pinskia at gcc dot gnu.org
` (2 preceding siblings ...)
2023-12-11 16:45 ` [Bug middle-end/112951] [14 Regression] cond_copysign, cond_len_copysign optab not documented (added by r14-5285-gf30ecd8050444f) pinskia at gcc dot gnu.org
@ 2023-12-21 19:40 ` pinskia at gcc dot gnu.org
2023-12-21 20:11 ` pinskia at gcc dot gnu.org
` (2 subsequent siblings)
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-12-21 19:40 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112951
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|unassigned at gcc dot gnu.org |pinskia at gcc dot gnu.org
--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I have a simple patch.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug middle-end/112951] [14 Regression] cond_copysign, cond_len_copysign optab not documented (added by r14-5285-gf30ecd8050444f)
2023-12-11 2:46 [Bug middle-end/112951] New: [14 Regression] cond_copysign, cond_len_copysign optab not documented pinskia at gcc dot gnu.org
` (3 preceding siblings ...)
2023-12-21 19:40 ` pinskia at gcc dot gnu.org
@ 2023-12-21 20:11 ` pinskia at gcc dot gnu.org
2023-12-21 20:23 ` cvs-commit at gcc dot gnu.org
2023-12-21 20:24 ` pinskia at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-12-21 20:11 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112951
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
URL| |https://gcc.gnu.org/piperma
| |il/gcc-patches/2023-Decembe
| |r/641270.html
Keywords| |patch
--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Patch submitted:
https://gcc.gnu.org/pipermail/gcc-patches/2023-December/641270.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug middle-end/112951] [14 Regression] cond_copysign, cond_len_copysign optab not documented (added by r14-5285-gf30ecd8050444f)
2023-12-11 2:46 [Bug middle-end/112951] New: [14 Regression] cond_copysign, cond_len_copysign optab not documented pinskia at gcc dot gnu.org
` (4 preceding siblings ...)
2023-12-21 20:11 ` pinskia at gcc dot gnu.org
@ 2023-12-21 20:23 ` cvs-commit at gcc dot gnu.org
2023-12-21 20:24 ` pinskia at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2023-12-21 20:23 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112951
--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:
https://gcc.gnu.org/g:df5df10355089c9c92529c222100722cea170877
commit r14-6792-gdf5df10355089c9c92529c222100722cea170877
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date: Thu Dec 21 11:41:18 2023 -0800
Document cond_copysign and cond_len_copysign optabs [PR112951]
This adds the documentation for cond_copysign and cond_len_copysign optabs.
Also reorders the optabs.def to be in the similar order as how the internal
function was done.
gcc/ChangeLog:
PR middle-end/112951
* doc/md.texi (cond_copysign): Document.
(cond_len_copysign): Likewise.
* optabs.def: Reorder cond_copysign to be before
cond_fmin. Likewise for cond_len_copysign.
Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Bug middle-end/112951] [14 Regression] cond_copysign, cond_len_copysign optab not documented (added by r14-5285-gf30ecd8050444f)
2023-12-11 2:46 [Bug middle-end/112951] New: [14 Regression] cond_copysign, cond_len_copysign optab not documented pinskia at gcc dot gnu.org
` (5 preceding siblings ...)
2023-12-21 20:23 ` cvs-commit at gcc dot gnu.org
@ 2023-12-21 20:24 ` pinskia at gcc dot gnu.org
6 siblings, 0 replies; 8+ messages in thread
From: pinskia at gcc dot gnu.org @ 2023-12-21 20:24 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112951
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-12-21 20:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-11 2:46 [Bug middle-end/112951] New: [14 Regression] cond_copysign, cond_len_copysign optab not documented pinskia at gcc dot gnu.org
2023-12-11 2:49 ` [Bug middle-end/112951] " pinskia at gcc dot gnu.org
2023-12-11 10:01 ` rguenth at gcc dot gnu.org
2023-12-11 16:45 ` [Bug middle-end/112951] [14 Regression] cond_copysign, cond_len_copysign optab not documented (added by r14-5285-gf30ecd8050444f) pinskia at gcc dot gnu.org
2023-12-21 19:40 ` pinskia at gcc dot gnu.org
2023-12-21 20:11 ` pinskia at gcc dot gnu.org
2023-12-21 20:23 ` cvs-commit at gcc dot gnu.org
2023-12-21 20:24 ` pinskia at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).