[Bug target/113040] New: [14 Regression] libmvec test failures

[Bug target/113040] New: [14 Regression] libmvec test failures

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113040

            Bug ID: 113040
           Summary: [14 Regression] libmvec test failures
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: hjl.tools at gmail dot com
                CC: crazylht at gmail dot com
  Target Milestone: ---
            Target: x86-64

When GCC 14 (r14-6607-g082835836cf763) to build and test glibc on x86-64,
I got

FAIL: math/test-float-libmvec-sincosf-avx2
FAIL: math/test-float-libmvec-sincosf-avx512f

Program received signal SIGSEGV, Segmentation fault.
_ZGVdN8vvv_sincosf_avx2 ()
    at ../sysdeps/x86_64/fpu/multiarch/svml_s_sincosf8_core_avx2.S:305
305             movl      %r9d, (%r10)
(gdb)

and

Program received signal SIGSEGV, Segmentation fault.
0x000055555547e976 in _ZGVeN16vvv_sincosf_skx ()
    at ../sysdeps/x86_64/fpu/multiarch/svml_s_sincosf16_core_avx512.S:741
741     WRAPPER_AVX512_vvv_vl4l4 _ZGVeN16vl4l4_sincosf_skx
(gdb)

[Bug target/113040] [14 Regression] libmvec test failures

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113040

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |wrong-code
   Target Milestone|---                         |14.0

[Bug target/113040] [14 Regression] libmvec test failures

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113040

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-bisection
                 CC|                            |rguenth at gcc dot gnu.org

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Can you produce a standalone testcase?

[Bug target/113040] [14 Regression] libmvec test failures

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113040

--- Comment #2 from H.J. Lu <hjl.tools at gmail dot com> ---
Created attachment 56902
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=56902&action=edit
A testcase

[hjl@gnu-tgl-3 tmp]$
/export/build/gnu/tools-build/gcc-gitlab-debug/release/usr/gcc-14.0.0-x86-64/bin/gcc
x.c -frounding-math -O2 -g -fopenmp -fno-inline -mavx2 -D_GNU_SOURCE -lm
-fno-builtin -D__FAST_MATH__
[hjl@gnu-tgl-3 tmp]$ ./a.out 
Segmentation fault (core dumped)
[hjl@gnu-tgl-3 tmp]$
/export/build/gnu/tools-build/gcc-gitlab-debug/release/usr/gcc-14.0.0-x86-64/bin/gcc
x.c -frounding-math -O2 -g -fopenmp -fno-inline -mavx512f -D_GNU_SOURCE -lm
-fno-builtin -D__FAST_MATH__
[hjl@gnu-tgl-3 tmp]$ ./a.out 
Segmentation fault (core dumped)
[hjl@gnu-tgl-3 tmp]$

[Bug target/113040] [14 Regression] libmvec test failures

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113040

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2023-12-18
             Status|UNCONFIRMED                 |NEW

[Bug target/113040] [14 Regression] libmvec test failures

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113040

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|needs-bisection             |
                 CC|                            |andre.simoesdiasvieira@arm.
                   |                            |com

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
It is caused by r14-5057-gea4a3d08f11a59

[Bug target/113040] [14 Regression] libmvec test failures

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113040

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1
             Target|x86-64                      |x86_64-*-*

[Bug target/113040] [14 Regression] libmvec test failures

[avieira at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113040

avieira at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |avieira at gcc dot gnu.org
           Assignee|unassigned at gcc dot gnu.org      |avieira at gcc dot gnu.org

--- Comment #4 from avieira at gcc dot gnu.org ---
Yeah my bad. For cases where we don't expose the definition the new code
sequence doesn't add multiple vector parameters for cases where the vector
length of the single parameter is less than that of the simdclone's simdlen.

Testing a patch now.

[Bug target/113040] [14 Regression] libmvec test failures

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113040

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

[Bug middle-end/113040] [14 Regression] libmvec test failures

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113040

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by H.J. Lu <hjl@gcc.gnu.org>:

https://gcc.gnu.org/g:135bb9e37167ef70501a888bd3db195b11b37ae3

commit r14-6788-g135bb9e37167ef70501a888bd3db195b11b37ae3
Author: Andre Vieira (lists) <andre.simoesdiasvieira@arm.com>
Date:   Wed Dec 20 15:17:09 2023 +0000

    omp: Fix simdclone arguments with veclen lower than simdlen [PR113040]

    This patch fixes an issue introduced by:
    commit ea4a3d08f11a59319df7b750a955ac613a3f438a
    Author: Andre Vieira <andre.simoesdiasvieira@arm.com>
    Date:   Wed Nov 1 17:02:41 2023 +0000

         omp: Reorder call for TARGET_SIMD_CLONE_ADJUST

    The problem was that after this patch we no longer added multiple
    arguments for vector arguments where the veclen was lower than the simdlen.

    Bootstrapped and regression tested on x86_64-pc-linux-gnu and
    aarch64-unknown-linux-gnu.

    gcc/ChangeLog:

            PR middle-end/113040
            * omp-simd-clone.cc (simd_clone_adjust_argument_types): Add
multiple
            vector arguments where simdlen is larger than veclen.

[Bug middle-end/113040] [14 Regression] libmvec test failures

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113040

H.J. Lu <hjl.tools at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from H.J. Lu <hjl.tools at gmail dot com> ---
Fixed.