public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113144] [14 regression] ICE when building dpkg-1.21.15 in verify_dominators (error: dominator of 9 should be 48, not 12)
Date: Wed, 10 Jan 2024 12:54:40 +0000	[thread overview]
Message-ID: <bug-113144-4-oGNwHfsVR7@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113144-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113144

--- Comment #16 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:

https://gcc.gnu.org/g:9e7c77c7933b1bb0dd07214333e52a9a896fa349

commit r14-7101-g9e7c77c7933b1bb0dd07214333e52a9a896fa349
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Wed Jan 10 12:51:54 2024 +0000

    middle-end: Fix dominators updates when peeling with multiple exits
[PR113144]

    When we peel at_exit we are moving the new loop at the exit of the previous
    loop.  This means that the blocks outside the loop dat the previous loop
used to
    dominate are no longer being dominated by it.

    The new dominators however are hard to predict since if the loop has
multiple
    exits and all the exits are an "early" one then we always execute the
scalar
    loop.  In this case the scalar loop can completely dominate the new loop.

    If we later have skip_vector then there's an additional skip edge added
that
    might change the dominators.

    The previous patch would force an update of all blocks reachable from the
new
    exits.  This one updates *only* blocks that we know the scalar exits
dominated.

    For the examples this reduces the blocks to update from 18 to 3.

    gcc/ChangeLog:

            PR tree-optimization/113144
            PR tree-optimization/113145
            * tree-vect-loop-manip.cc (slpeel_tree_duplicate_loop_to_edge_cfg):
            Update all BB that the original exits dominated.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/113144
            PR tree-optimization/113145
            * gcc.dg/vect/vect-early-break_94-pr113144.c: New test.

  parent reply	other threads:[~2024-01-10 12:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-26  6:55 [Bug tree-optimization/113144] New: " sjames at gcc dot gnu.org
2023-12-26  6:55 ` [Bug tree-optimization/113144] " sjames at gcc dot gnu.org
2023-12-26  7:01 ` sjames at gcc dot gnu.org
2023-12-26 14:14 ` tnfchris at gcc dot gnu.org
2023-12-26 14:28 ` tnfchris at gcc dot gnu.org
2023-12-27 11:54 ` tnfchris at gcc dot gnu.org
2023-12-27 11:55 ` tnfchris at gcc dot gnu.org
2023-12-28 11:28 ` dcb314 at hotmail dot com
2023-12-29 21:07 ` tnfchris at gcc dot gnu.org
2024-01-05 13:18 ` tnfchris at gcc dot gnu.org
2024-01-08 19:37 ` zsojka at seznam dot cz
2024-01-08 19:55 ` pinskia at gcc dot gnu.org
2024-01-09  3:49 ` tnfchris at gcc dot gnu.org
2024-01-09 17:14 ` jamborm at gcc dot gnu.org
2024-01-09 19:08 ` tnfchris at gcc dot gnu.org
2024-01-09 22:21 ` tnfchris at gcc dot gnu.org
2024-01-10 12:54 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-10 12:56 ` tnfchris at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113144-4-oGNwHfsVR7@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).