public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "pinskia at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/113159] More robust std::sort for silly comparator functions
Date: Fri, 29 Dec 2023 00:33:14 +0000	[thread overview]
Message-ID: <bug-113159-4-LWKkTTlGnP@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113159-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113159

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to Jan Engelhardt from comment #4)
> >And in upcoming Glibc-2.39 there will be a major reimplementation of qsort
> 
> Even so, a recent commit strongly suggests that sticking to array bounds
> remains important:

So IIRC the reasoning is because of bugs in older (current as of a month ago
even) versions of LLVM which crashes on a comparison with itself. Basically
broken comparison functions are forcing workarounds really.

Note GCC uses its own sort function due which is designed to detect the
brokeness of comparison functions even; see PR 109187, PR 90282, PR 87281, PR
84345, etc.

  parent reply	other threads:[~2023-12-29  0:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-27 23:04 [Bug libstdc++/113159] New: " jengelh at inai dot de
2023-12-28  1:16 ` [Bug libstdc++/113159] " redi at gcc dot gnu.org
2023-12-28  8:46 ` xry111 at gcc dot gnu.org
2023-12-28 18:34 ` redi at gcc dot gnu.org
2023-12-28 18:42 ` amonakov at gcc dot gnu.org
2023-12-29  0:23 ` jengelh at inai dot de
2023-12-29  0:33 ` pinskia at gcc dot gnu.org [this message]
2023-12-29  7:56 ` fw at gcc dot gnu.org
2024-01-03  1:41 ` xry111 at gcc dot gnu.org
2024-01-03 11:09 ` redi at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113159-4-LWKkTTlGnP@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).