[Bug libgomp/113192] New: [14 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[Bug libgomp/113192] New: [14 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

            Bug ID: 113192
           Summary: [14 Regression] ERROR: couldn't execute
                    "../../../gcc/libgomp/testsuite/flock": no such file
                    or directory
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgomp
          Assignee: unassigned at gcc dot gnu.org
          Reporter: danglin at gcc dot gnu.org
                CC: jakub at gcc dot gnu.org, tschwinge at gcc dot gnu.org
  Target Milestone: ---
              Host: hppa64-hp-hpux11.11
            Target: hppa64-hp-hpux11.11
             Build: hppa64-hp-hpux11.11

HP-UX doesn't have flock but it does have perl. configure tries to create
a fallback but a relative path to libgomp/testsuite/flock is generated.
It is wrong when the testsuite is run.

AC_MSG_NOTICE([checking for flock implementation])
AC_CHECK_PROGS(FLOCK, flock)
# Fallback if 'perl' is available.
if test -z "$FLOCK"; then
  AC_CHECK_PROG(FLOCK, perl, $srcdir/testsuite/flock)
fi

configure: checking for flock implementation
checking for flock... no
checking for perl... ../../../gcc/libgomp/testsuite/flock

Running /home/dave/gnu/gcc/gcc/libgomp/testsuite/libgomp.c/c.exp ...
ERROR: tcl error sourcing
/home/dave/gnu/gcc/gcc/libgomp/testsuite/libgomp.c/c.exp.
ERROR: tcl error code NONE
ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or
directory
    while executing
"exec $FLOCK $lock_kind 1 >@ $lock_fd"
    (procedure "saved_libgomp_load" line 10)
    invoked from within
"saved_libgomp_load ./alloc-1.exe"
    ("eval" body line 1)
    invoked from within
"eval [list saved_${tool}_load $program] $args"
    (procedure "libgomp_load" line 13)
    invoked from within
"${tool}_load $output_file"
    (procedure "saved-dg-test" line 218)
    invoked from within
"saved-dg-test
/home/dave/gnu/gcc/gcc/libgomp/testsuite/libgomp.c/../libgomp.c-c++-common/alloc-1.c
{} -O2"
    ("eval" body line 1)
    invoked from within
"eval saved-dg-test $args "
    (procedure "dg-test" line 1)
    invoked from within
"dg-test $testcase $options ${default-extra-options}"
    (procedure "dg-runtest" line 10)
    invoked from within
"dg-runtest $tests "" $DEFAULT_CFLAGS"
    (file "/home/dave/gnu/gcc/gcc/libgomp/testsuite/libgomp.c/c.exp" line 27)
    invoked from within
"source /home/dave/gnu/gcc/gcc/libgomp/testsuite/libgomp.c/c.exp"
    ("uplevel" body line 1)
    invoked from within
"uplevel #0 source /home/dave/gnu/gcc/gcc/libgomp/testsuite/libgomp.c/c.exp"
    invoked from within
"catch "uplevel #0 source $test_file_name" msg"

This problem was introduced by the following commit:

commit 04abe1944d30eb18a2060cfcd9695d085f7b4752
Author: Thomas Schwinge <thomas@codesourcery.com>
Date:   Mon May 15 20:00:07 2023 +0200

    Support parallel testing in libgomp: fallback Perl 'flock' [PR66005]

It appears this problem can be worked around by exporting FLOCK.

[Bug libgomp/113192] [11/12/13/14 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[tschwinge at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[14 Regression] ERROR:      |[11/12/13/14 Regression]
                   |couldn't execute            |ERROR: couldn't execute
                   |"../../../gcc/libgomp/tests |"../../../gcc/libgomp/tests
                   |uite/flock": no such file   |uite/flock": no such file
                   |or directory                |or directory
             Blocks|                            |66005
            Version|14.0                        |11.0

--- Comment #1 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
(In reply to John David Anglin from comment #0)
> HP-UX doesn't have flock but it does have perl. configure tries to create
> a fallback but a relative path to libgomp/testsuite/flock is generated.
> It is wrong when the testsuite is run.
> 
> AC_MSG_NOTICE([checking for flock implementation])
> AC_CHECK_PROGS(FLOCK, flock)
> # Fallback if 'perl' is available.
> if test -z "$FLOCK"; then
>   AC_CHECK_PROG(FLOCK, perl, $srcdir/testsuite/flock)
> fi

Aha, sorry.  Does it work if you changes:

    -AC_CHECK_PROG(FLOCK, perl, $srcdir/testsuite/flock)
    +AC_CHECK_PROG(FLOCK, perl, $ac_abs_srcdir/testsuite/flock)

..., so that this:

> configure: checking for flock implementation
> checking for flock... no
> checking for perl... ../../../gcc/libgomp/testsuite/flock

... turns into an absolute path, to resolve:

> Running /home/dave/gnu/gcc/gcc/libgomp/testsuite/libgomp.c/c.exp ...
> ERROR: tcl error sourcing
> /home/dave/gnu/gcc/gcc/libgomp/testsuite/libgomp.c/c.exp.
> ERROR: tcl error code NONE
> ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file
> or directory

... this.

If that works, and you submit a patch, please in the commit log cite this
commit:

> This problem was introduced by the following commit:
> 
> commit 04abe1944d30eb18a2060cfcd9695d085f7b4752
> Author: Thomas Schwinge <thomas@codesourcery.com>
> Date:   Mon May 15 20:00:07 2023 +0200
> 
>     Support parallel testing in libgomp: fallback Perl 'flock' [PR66005]

..., and also specify 'PR testsuite/66005' in the commit log.

If that suggestion doesn't easily resolve this issue, then I'll be able to look
into it next week.


> It appears this problem can be worked around by exporting FLOCK.

But only if that specifies an absolute path (or a "suitable" relative one), I
suppose?


I've also set this "11/12/13 Regression", as these branches use the exact same
code.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66005
[Bug 66005] libgomp make check time is excessive

[Bug libgomp/113192] [11/12/13/14 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

--- Comment #2 from dave.anglin at bell dot net ---
On 2024-01-02 10:21 a.m., tschwinge at gcc dot gnu.org wrote:
> Aha, sorry.  Does it work if you changes:
>
>      -AC_CHECK_PROG(FLOCK, perl, $srcdir/testsuite/flock)
>      +AC_CHECK_PROG(FLOCK, perl, $ac_abs_srcdir/testsuite/flock)
No, we get:
ERROR: couldn't execute "/testsuite/flock": no such file or directory

I see top_srcdir is used in some files.

[Bug libgomp/113192] [11/12/13/14 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.5

[Bug libgomp/113192] [11/12/13/14 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

--- Comment #3 from John David Anglin <danglin at gcc dot gnu.org> ---
export FLOCK=/home/dave/gnu/gcc/gcc/libgomp/testsuite/flock
in my build script works around configure issue.

[Bug libgomp/113192] [11/12/13/14 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
What about:
--- libgomp/configure.ac.jj     2023-11-02 07:49:21.693801244 +0100
+++ libgomp/configure.ac        2024-01-08 21:46:21.014765685 +0100
@@ -343,7 +343,7 @@ AX_COUNT_CPUS
 AC_CHECK_PROGS(FLOCK, flock)
 # Fallback if 'perl' is available.
 if test -z "$FLOCK"; then
-  AC_CHECK_PROG(FLOCK, perl, $srcdir/testsuite/flock)
+  AC_CHECK_PROG(FLOCK, perl, \$(abs_top_srcdir)/testsuite/flock)
 fi

 AC_SUBST(SYSROOT_CFLAGS_FOR_TARGET)
--- libgomp/configure.jj        2024-01-06 02:29:24.566795886 +0100
+++ libgomp/configure   2024-01-08 21:46:23.799726387 +0100
@@ -16655,7 +16655,7 @@ do
   test -z "$as_dir" && as_dir=.
     for ac_exec_ext in '' $ac_executable_extensions; do
   if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then
-    ac_cv_prog_FLOCK="$srcdir/testsuite/flock"
+    ac_cv_prog_FLOCK="\$(abs_top_srcdir)/testsuite/flock"
     $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext"
>&5
     break 2
   fi

[Bug libgomp/113192] [11/12/13/14 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[dave.anglin at bell dot net]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

--- Comment #5 from dave.anglin at bell dot net ---
On 2024-01-08 3:49 p.m., jakub at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192
>
> --- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
> What about:
> --- libgomp/configure.ac.jj     2023-11-02 07:49:21.693801244 +0100
> +++ libgomp/configure.ac        2024-01-08 21:46:21.014765685 +0100
> @@ -343,7 +343,7 @@ AX_COUNT_CPUS
>   AC_CHECK_PROGS(FLOCK, flock)
>   # Fallback if 'perl' is available.
>   if test -z "$FLOCK"; then
> -  AC_CHECK_PROG(FLOCK, perl, $srcdir/testsuite/flock)
> +  AC_CHECK_PROG(FLOCK, perl, \$(abs_top_srcdir)/testsuite/flock)
>   fi
>
>   AC_SUBST(SYSROOT_CFLAGS_FOR_TARGET)
> --- libgomp/configure.jj        2024-01-06 02:29:24.566795886 +0100
> +++ libgomp/configure   2024-01-08 21:46:23.799726387 +0100
> @@ -16655,7 +16655,7 @@ do
>     test -z "$as_dir" && as_dir=.
>       for ac_exec_ext in '' $ac_executable_extensions; do
>     if as_fn_executable_p "$as_dir/$ac_word$ac_exec_ext"; then
> -    ac_cv_prog_FLOCK="$srcdir/testsuite/flock"
> +    ac_cv_prog_FLOCK="\$(abs_top_srcdir)/testsuite/flock"
>       $as_echo "$as_me:${as_lineno-$LINENO}: found $as_dir/$ac_word$ac_exec_ext"
>> &5
>       break 2
>     fi
>
Works.

Thanks,
Dave

[Bug libgomp/113192] [11/12/13/14 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:f2e967e0257bc8188840df236595e7218b6bf748

commit r14-7027-gf2e967e0257bc8188840df236595e7218b6bf748
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Jan 9 09:54:06 2024 +0100

    libgomp: Use absolute pathname to testsuite/flock [PR113192]

    When flock program doesn't exist, libgomp configure attempts to
    offer a fallback version using a perl script, but we weren't using
    absolute filename to that, so it apparently failed to work correctly.

    The following patch arranges for it to get the absolute filename.

    Tested by John David in the PR.

    2024-01-09  Jakub Jelinek  <jakub@redhat.com>

            PR libgomp/113192
            * configure.ac (FLOCK): Use \$(abs_top_srcdir)/testsuite/flock
            rather than $srcdir/testsuite/flock.
            * configure: Regenerated.

[Bug libgomp/113192] [11/12/13 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12/13/14 Regression]    |[11/12/13 Regression]
                   |ERROR: couldn't execute     |ERROR: couldn't execute
                   |"../../../gcc/libgomp/tests |"../../../gcc/libgomp/tests
                   |uite/flock": no such file   |uite/flock": no such file
                   |or directory                |or directory

--- Comment #7 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Hopefully fixed on the trunk so far.

[Bug libgomp/113192] [11/12/13 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:2fb3ee3ee82874e160309344bc3e52afeed8f26a

commit r14-7099-g2fb3ee3ee82874e160309344bc3e52afeed8f26a
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Jan 10 13:29:47 2024 +0100

    libgomp: Fix up FLOCK fallback handling [PR113192]

    My earlier change broke Solaris testing, because @FLOCK@ isn't substituted
    just into libgomp/Makefile where it worked, but also the
    testsuite/libgomp-site-extra.exp file where Make variables aren't present
    and can't be substituted.

    The following patch instead computes the absolute srcdir path and uses it
    for FLOCK.

    2024-01-10  Jakub Jelinek  <jakub@redhat.com>

            PR libgomp/113192
            * configure.ac (FLOCK): Use $libgomp_abs_srcdir/testsuite/flock
            instead of \$(abs_top_srcdir)/testsuite/flock.
            * configure: Regenerated.

[Bug libgomp/113192] [11/12/13 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

--- Comment #9 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:3ac307df305146a438988acbea2341829e8b7ad3

commit r13-8380-g3ac307df305146a438988acbea2341829e8b7ad3
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Jan 9 09:54:06 2024 +0100

    libgomp: Use absolute pathname to testsuite/flock [PR113192]

    When flock program doesn't exist, libgomp configure attempts to
    offer a fallback version using a perl script, but we weren't using
    absolute filename to that, so it apparently failed to work correctly.

    The following patch arranges for it to get the absolute filename.

    Tested by John David in the PR.

    2024-01-09  Jakub Jelinek  <jakub@redhat.com>

            PR libgomp/113192
            * configure.ac (FLOCK): Use \$(abs_top_srcdir)/testsuite/flock
            rather than $srcdir/testsuite/flock.
            * configure: Regenerated.

    (cherry picked from commit f2e967e0257bc8188840df236595e7218b6bf748)

[Bug libgomp/113192] [11/12/13 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

--- Comment #10 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jakub Jelinek
<jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:d4f849c0564fc80938d4d4871810a2b97ace45e7

commit r13-8382-gd4f849c0564fc80938d4d4871810a2b97ace45e7
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Wed Jan 10 13:29:47 2024 +0100

    libgomp: Fix up FLOCK fallback handling [PR113192]

    My earlier change broke Solaris testing, because @FLOCK@ isn't substituted
    just into libgomp/Makefile where it worked, but also the
    testsuite/libgomp-site-extra.exp file where Make variables aren't present
    and can't be substituted.

    The following patch instead computes the absolute srcdir path and uses it
    for FLOCK.

    2024-01-10  Jakub Jelinek  <jakub@redhat.com>

            PR libgomp/113192
            * configure.ac (FLOCK): Use $libgomp_abs_srcdir/testsuite/flock
            instead of \$(abs_top_srcdir)/testsuite/flock.
            * configure: Regenerated.

    (cherry picked from commit 2fb3ee3ee82874e160309344bc3e52afeed8f26a)

[Bug libgomp/113192] [11/12 Regression] ERROR: couldn't execute "../../../gcc/libgomp/testsuite/flock": no such file or directory

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113192

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12/13 Regression]       |[11/12 Regression] ERROR:
                   |ERROR: couldn't execute     |couldn't execute
                   |"../../../gcc/libgomp/tests |"../../../gcc/libgomp/tests
                   |uite/flock": no such file   |uite/flock": no such file
                   |or directory                |or directory

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Should be now fixed for GCC 13 too.