public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "jakub at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug lto/113208] [14 Regression] lto1: error: Alias and target's comdat groups differs since r14-5979-g99d114c15523e0 Date: Tue, 16 Apr 2024 08:57:25 +0000 [thread overview] Message-ID: <bug-113208-4-tqoRwDfDaF@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-113208-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113208 --- Comment #29 from Jakub Jelinek <jakub at gcc dot gnu.org> --- Looking at t1 (i.e. the reduced testcase with constexpr), the difference with -std=c++20 -O1 -fkeep-inline-functions is that in r14-5978 we used to emit _ZN6vectorI12QualityValueEC2ERKS1_ in _ZN6vectorI12QualityValueEC5ERKS1_ comdat section and _ZN6vectorI12QualityValueEC1ERKS1_ as an alias to it (i.e. the r0-97383-g24b3ff2c53806d3d optimization), while with r14-5979 we don't optimize it any longer, i.e. emit _ZN6vectorI12QualityValueEC2ERKS1_ in _ZN6vectorI12QualityValueEC2ERKS1_ comdat and _ZN6vectorI12QualityValueEC2ERKS1_ in _ZN6vectorI12QualityValueEC2ERKS1_ comdat. I thought that ought to be ABI compatible (the latter is what we used to emit before r0-97383), all the involved symbols are weak and either linker keeps the pair of symbols with the _ZN6vectorI12QualityValueEC5ERKS1_ comdat, or one or both of the _ZN6vectorI12QualityValueEC[12]ERKS1_ comdats (depending on if just one or both of those symbols are used), or it keeps all of them and the linker chooses between the 2 symbol definitions one that is actually used. Of course, I'd like to understand why Marek's patch changed the behavior.
next prev parent reply other threads:[~2024-04-16 8:57 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-02 19:56 [Bug lto/113208] New: [14 Regression] lto1: error: Alias and target's comdat groups differs doko at gcc dot gnu.org 2024-01-02 20:02 ` [Bug lto/113208] " doko at gcc dot gnu.org 2024-01-02 20:23 ` doko at gcc dot gnu.org 2024-01-06 6:15 ` pinskia at gcc dot gnu.org 2024-03-07 20:53 ` law at gcc dot gnu.org 2024-03-18 7:45 ` sjames at gcc dot gnu.org 2024-03-18 7:46 ` sjames at gcc dot gnu.org 2024-03-23 9:58 ` sjames at gcc dot gnu.org 2024-03-23 10:32 ` sjames at gcc dot gnu.org 2024-03-24 13:52 ` sjames at gcc dot gnu.org 2024-03-24 13:53 ` sjames at gcc dot gnu.org 2024-03-24 13:53 ` sjames at gcc dot gnu.org 2024-03-24 14:25 ` sjames at gcc dot gnu.org 2024-03-24 14:34 ` sjames at gcc dot gnu.org 2024-03-24 17:45 ` [Bug lto/113208] [14 Regression] lto1: error: Alias and target's comdat groups differs since r14-5979-g99d114c15523e0 sjames at gcc dot gnu.org 2024-03-24 19:59 ` pinskia at gcc dot gnu.org 2024-03-24 20:03 ` sjames at gcc dot gnu.org 2024-03-24 20:03 ` sjames at gcc dot gnu.org 2024-03-24 20:09 ` pinskia at gcc dot gnu.org 2024-03-24 20:09 ` pinskia at gcc dot gnu.org 2024-03-24 20:09 ` pinskia at gcc dot gnu.org 2024-03-24 20:11 ` pinskia at gcc dot gnu.org 2024-03-25 23:43 ` pinskia at gcc dot gnu.org 2024-03-26 10:39 ` rguenth at gcc dot gnu.org 2024-04-04 14:59 ` jakub at gcc dot gnu.org 2024-04-10 7:29 ` rguenth at gcc dot gnu.org 2024-04-10 13:28 ` jakub at gcc dot gnu.org 2024-04-15 15:46 ` hubicka at gcc dot gnu.org 2024-04-15 15:48 ` pinskia at gcc dot gnu.org 2024-04-15 15:55 ` hubicka at gcc dot gnu.org 2024-04-15 17:15 ` hubicka at gcc dot gnu.org 2024-04-16 8:57 ` jakub at gcc dot gnu.org [this message] 2024-04-16 10:34 ` jakub at gcc dot gnu.org 2024-04-16 15:14 ` jakub at gcc dot gnu.org 2024-04-16 16:01 ` jakub at gcc dot gnu.org 2024-04-16 18:23 ` jakub at gcc dot gnu.org 2024-04-25 18:39 ` cvs-commit at gcc dot gnu.org 2024-04-25 18:49 ` [Bug lto/113208] [15 " jakub at gcc dot gnu.org 2024-05-15 16:52 ` cvs-commit at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113208-4-tqoRwDfDaF@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).