public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/113210] [14 Regression] ICE: tree check: expected integer_cst, have cond_expr in get_len, at tree.h:6481 Date: Tue, 09 Jan 2024 09:32:27 +0000 [thread overview] Message-ID: <bug-113210-4-81XHqT65hD@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-113210-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113210 --- Comment #17 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>: https://gcc.gnu.org/g:b1d4e5b51375efd285378173375d634ad6ba8462 commit r14-7030-gb1d4e5b51375efd285378173375d634ad6ba8462 Author: Jakub Jelinek <jakub@redhat.com> Date: Tue Jan 9 10:31:51 2024 +0100 vect: Ensure both NITERSM1 and NITERS are INTEGER_CSTs or neither of them [PR113210] On the following testcase e.g. on riscv64 or aarch64 (latter with -O3 -march=armv8-a+sve ) we ICE, because while NITERS is INTEGER_CST, NITERSM1 is a complex expression like (short unsigned int) (a.0_1 + 255) + 1 > 256 ? ~(short unsigned int) (a.0_1 + 255) : 0 where a.0_1 is unsigned char. The condition is never true, so the above is equivalent to just 0, but only when trying to fold the above with PLUS_EXPR 1 we manage to simplify it (first ~(short unsigned int) (a.0_1 + 255) to -(short unsigned int) (a.0_1 + 255) and then (short unsigned int) (a.0_1 + 255) + 1 > 256 ? -(short unsigned int) (a.0_1 + 255) : 1 to (short unsigned int) (a.0_1 + 255) >= 256 ? -(short unsigned int) (a.0_1 + 255) : 1 and only at this point we fold the condition to be false. But the vectorizer seems to assume that if NITERS is known (i.e. suitable INTEGER_CST) then NITERSM1 also is, so the following hack ensures that if NITERS folds into INTEGER_CST NITERSM1 will be one as well. 2024-01-09 Jakub Jelinek <jakub@redhat.com> PR tree-optimization/113210 * tree-vect-loop.cc (vect_get_loop_niters): If non-INTEGER_CST value in *number_of_iterationsm1 PLUS_EXPR 1 is folded into INTEGER_CST, recompute *number_of_iterationsm1 as the INTEGER_CST minus 1. * gcc.c-torture/compile/pr113210.c: New test.
next prev parent reply other threads:[~2024-01-09 9:32 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-02 23:33 [Bug target/113210] New: [14] RISC-V vector " patrick at rivosinc dot com 2024-01-02 23:38 ` [Bug target/113210] " juzhe.zhong at rivai dot ai 2024-01-02 23:48 ` patrick at rivosinc dot com 2024-01-03 1:33 ` [Bug tree-optimization/113210] [14 Regression] " pinskia at gcc dot gnu.org 2024-01-03 1:34 ` pinskia at gcc dot gnu.org 2024-01-03 1:39 ` pinskia at gcc dot gnu.org 2024-01-03 1:42 ` pinskia at gcc dot gnu.org 2024-01-05 14:37 ` jakub at gcc dot gnu.org 2024-01-05 16:09 ` jakub at gcc dot gnu.org 2024-01-05 16:21 ` jakub at gcc dot gnu.org 2024-01-08 9:44 ` rguenth at gcc dot gnu.org 2024-01-08 10:02 ` jakub at gcc dot gnu.org 2024-01-08 10:09 ` jakub at gcc dot gnu.org 2024-01-08 10:16 ` rguenth at gcc dot gnu.org 2024-01-08 10:18 ` rguenth at gcc dot gnu.org 2024-01-08 10:25 ` rguenth at gcc dot gnu.org 2024-01-08 15:58 ` jakub at gcc dot gnu.org 2024-01-09 8:36 ` rguenth at gcc dot gnu.org 2024-01-09 9:32 ` cvs-commit at gcc dot gnu.org [this message] 2024-01-09 9:32 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113210-4-81XHqT65hD@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).