public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug libstdc++/113250] New: std::filesystem::equivalent("", "/") should throw
@ 2024-01-06 1:56 davidepesa at gmail dot com
2024-01-06 9:09 ` [Bug libstdc++/113250] " redi at gcc dot gnu.org
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: davidepesa at gmail dot com @ 2024-01-06 1:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113250
Bug ID: 113250
Summary: std::filesystem::equivalent("", "/") should throw
Product: gcc
Version: 13.2.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: libstdc++
Assignee: unassigned at gcc dot gnu.org
Reporter: davidepesa at gmail dot com
Target Milestone: ---
According to https://eel.is/c++draft/fs.op.equivalent
> !exists(p1) || !exists(p2) is an error.
However, equivalent("", "/") returns false instead of throwing
filesystem_error.
This is possibly due to a typo here:
https://github.com/gcc-mirror/gcc/blob/5a0b3355d956f5d36f9b562e027b890cc5f61d88/libstdc%2B%2B-v3/src/c%2B%2B17/fs_ops.cc#L900
(&& instead of ||)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/113250] std::filesystem::equivalent("", "/") should throw
2024-01-06 1:56 [Bug libstdc++/113250] New: std::filesystem::equivalent("", "/") should throw davidepesa at gmail dot com
@ 2024-01-06 9:09 ` redi at gcc dot gnu.org
2024-01-11 4:54 ` kmatsui at gcc dot gnu.org
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: redi at gcc dot gnu.org @ 2024-01-06 9:09 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113250
Jonathan Wakely <redi at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed| |2024-01-06
Ever confirmed|0 |1
Status|UNCONFIRMED |NEW
--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Yes, I think you're right about the typo
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/113250] std::filesystem::equivalent("", "/") should throw
2024-01-06 1:56 [Bug libstdc++/113250] New: std::filesystem::equivalent("", "/") should throw davidepesa at gmail dot com
2024-01-06 9:09 ` [Bug libstdc++/113250] " redi at gcc dot gnu.org
@ 2024-01-11 4:54 ` kmatsui at gcc dot gnu.org
2024-01-11 4:55 ` kmatsui at gcc dot gnu.org
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: kmatsui at gcc dot gnu.org @ 2024-01-11 4:54 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113250
Ken Matsui <kmatsui at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kmatsui at gcc dot gnu.org
--- Comment #2 from Ken Matsui <kmatsui at gcc dot gnu.org> ---
Confirmed. I think the testcase should also be like the following.
--- a/libstdc++-v3/testsuite/27_io/filesystem/operations/equivalent.cc
+++ b/libstdc++-v3/testsuite/27_io/filesystem/operations/equivalent.cc
@@ -40,7 +40,7 @@ test01()
__gnu_test::scoped_file f1(p1);
ec = bad_ec;
result = equivalent(p1, p2, ec);
- VERIFY( !ec );
+ VERIFY( ec == std::errc::no_such_file_or_directory );
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/113250] std::filesystem::equivalent("", "/") should throw
2024-01-06 1:56 [Bug libstdc++/113250] New: std::filesystem::equivalent("", "/") should throw davidepesa at gmail dot com
2024-01-06 9:09 ` [Bug libstdc++/113250] " redi at gcc dot gnu.org
2024-01-11 4:54 ` kmatsui at gcc dot gnu.org
@ 2024-01-11 4:55 ` kmatsui at gcc dot gnu.org
2024-01-11 11:39 ` cvs-commit at gcc dot gnu.org
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: kmatsui at gcc dot gnu.org @ 2024-01-11 4:55 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113250
Ken Matsui <kmatsui at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/113250] std::filesystem::equivalent("", "/") should throw
2024-01-06 1:56 [Bug libstdc++/113250] New: std::filesystem::equivalent("", "/") should throw davidepesa at gmail dot com
` (2 preceding siblings ...)
2024-01-11 4:55 ` kmatsui at gcc dot gnu.org
@ 2024-01-11 11:39 ` cvs-commit at gcc dot gnu.org
2024-01-11 11:42 ` cvs-commit at gcc dot gnu.org
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-01-11 11:39 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113250
--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Ken Matsui <kmatsui@gcc.gnu.org>:
https://gcc.gnu.org/g:df147e2ee7199d33d66959c6509ce9c21072077f
commit r14-7135-gdf147e2ee7199d33d66959c6509ce9c21072077f
Author: Ken Matsui <kmatsui@gcc.gnu.org>
Date: Wed Jan 10 22:08:07 2024 -0800
libstdc++: Fix error handling in filesystem::equivalent [PR113250]
This patch made std::filesystem::equivalent correctly throw an exception
when either path does not exist as per [fs.op.equivalent]/4.
PR libstdc++/113250
libstdc++-v3/ChangeLog:
* src/c++17/fs_ops.cc (fs::equivalent): Use || instead of &&.
* src/filesystem/ops.cc (fs::equivalent): Likewise.
* testsuite/27_io/filesystem/operations/equivalent.cc: Handle
error codes.
* testsuite/experimental/filesystem/operations/equivalent.cc:
Likewise.
Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
Reviewed-by: Jonathan Wakely <jwakely@redhat.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/113250] std::filesystem::equivalent("", "/") should throw
2024-01-06 1:56 [Bug libstdc++/113250] New: std::filesystem::equivalent("", "/") should throw davidepesa at gmail dot com
` (3 preceding siblings ...)
2024-01-11 11:39 ` cvs-commit at gcc dot gnu.org
@ 2024-01-11 11:42 ` cvs-commit at gcc dot gnu.org
2024-01-11 11:43 ` cvs-commit at gcc dot gnu.org
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-01-11 11:42 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113250
--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Ken Matsui
<kmatsui@gcc.gnu.org>:
https://gcc.gnu.org/g:3e51890ef351e7fb9e836c6a48f20ca97294dc16
commit r13-8209-g3e51890ef351e7fb9e836c6a48f20ca97294dc16
Author: Ken Matsui <kmatsui@gcc.gnu.org>
Date: Wed Jan 10 22:08:07 2024 -0800
libstdc++: Fix error handling in filesystem::equivalent [PR113250]
This patch made std::filesystem::equivalent correctly throw an exception
when either path does not exist as per [fs.op.equivalent]/4.
PR libstdc++/113250
libstdc++-v3/ChangeLog:
* src/c++17/fs_ops.cc (fs::equivalent): Use || instead of &&.
* src/filesystem/ops.cc (fs::equivalent): Likewise.
* testsuite/27_io/filesystem/operations/equivalent.cc: Handle
error codes.
* testsuite/experimental/filesystem/operations/equivalent.cc:
Likewise.
Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
Reviewed-by: Jonathan Wakely <jwakely@redhat.com>
(cherry picked from commit df147e2ee7199d33d66959c6509ce9c21072077f)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/113250] std::filesystem::equivalent("", "/") should throw
2024-01-06 1:56 [Bug libstdc++/113250] New: std::filesystem::equivalent("", "/") should throw davidepesa at gmail dot com
` (4 preceding siblings ...)
2024-01-11 11:42 ` cvs-commit at gcc dot gnu.org
@ 2024-01-11 11:43 ` cvs-commit at gcc dot gnu.org
2024-01-11 11:44 ` cvs-commit at gcc dot gnu.org
2024-01-11 12:31 ` kmatsui at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-01-11 11:43 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113250
--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Ken Matsui
<kmatsui@gcc.gnu.org>:
https://gcc.gnu.org/g:da19967df3ad5d123888ef24b4fd84be047df226
commit r12-10089-gda19967df3ad5d123888ef24b4fd84be047df226
Author: Ken Matsui <kmatsui@gcc.gnu.org>
Date: Wed Jan 10 22:08:07 2024 -0800
libstdc++: Fix error handling in filesystem::equivalent [PR113250]
This patch made std::filesystem::equivalent correctly throw an exception
when either path does not exist as per [fs.op.equivalent]/4.
PR libstdc++/113250
libstdc++-v3/ChangeLog:
* src/c++17/fs_ops.cc (fs::equivalent): Use || instead of &&.
* src/filesystem/ops.cc (fs::equivalent): Likewise.
* testsuite/27_io/filesystem/operations/equivalent.cc: Handle
error codes.
* testsuite/experimental/filesystem/operations/equivalent.cc:
Likewise.
Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
Reviewed-by: Jonathan Wakely <jwakely@redhat.com>
(cherry picked from commit df147e2ee7199d33d66959c6509ce9c21072077f)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/113250] std::filesystem::equivalent("", "/") should throw
2024-01-06 1:56 [Bug libstdc++/113250] New: std::filesystem::equivalent("", "/") should throw davidepesa at gmail dot com
` (5 preceding siblings ...)
2024-01-11 11:43 ` cvs-commit at gcc dot gnu.org
@ 2024-01-11 11:44 ` cvs-commit at gcc dot gnu.org
2024-01-11 12:31 ` kmatsui at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-01-11 11:44 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113250
--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Ken Matsui
<kmatsui@gcc.gnu.org>:
https://gcc.gnu.org/g:6c4882dd9453d096429cfb4652f25915a931e155
commit r11-11188-g6c4882dd9453d096429cfb4652f25915a931e155
Author: Ken Matsui <kmatsui@gcc.gnu.org>
Date: Wed Jan 10 22:08:07 2024 -0800
libstdc++: Fix error handling in filesystem::equivalent [PR113250]
This patch made std::filesystem::equivalent correctly throw an exception
when either path does not exist as per [fs.op.equivalent]/4.
PR libstdc++/113250
libstdc++-v3/ChangeLog:
* src/c++17/fs_ops.cc (fs::equivalent): Use || instead of &&.
* src/filesystem/ops.cc (fs::equivalent): Likewise.
* testsuite/27_io/filesystem/operations/equivalent.cc: Handle
error codes.
* testsuite/experimental/filesystem/operations/equivalent.cc:
Likewise.
Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
Reviewed-by: Jonathan Wakely <jwakely@redhat.com>
(cherry picked from commit df147e2ee7199d33d66959c6509ce9c21072077f)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Bug libstdc++/113250] std::filesystem::equivalent("", "/") should throw
2024-01-06 1:56 [Bug libstdc++/113250] New: std::filesystem::equivalent("", "/") should throw davidepesa at gmail dot com
` (6 preceding siblings ...)
2024-01-11 11:44 ` cvs-commit at gcc dot gnu.org
@ 2024-01-11 12:31 ` kmatsui at gcc dot gnu.org
7 siblings, 0 replies; 9+ messages in thread
From: kmatsui at gcc dot gnu.org @ 2024-01-11 12:31 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113250
Ken Matsui <kmatsui at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
Target Milestone|--- |11.5
--- Comment #7 from Ken Matsui <kmatsui at gcc dot gnu.org> ---
Fixed in 11.5, 12.4, 13.3. Thank you for filing this issue, Davide!
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-01-11 12:31 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-06 1:56 [Bug libstdc++/113250] New: std::filesystem::equivalent("", "/") should throw davidepesa at gmail dot com
2024-01-06 9:09 ` [Bug libstdc++/113250] " redi at gcc dot gnu.org
2024-01-11 4:54 ` kmatsui at gcc dot gnu.org
2024-01-11 4:55 ` kmatsui at gcc dot gnu.org
2024-01-11 11:39 ` cvs-commit at gcc dot gnu.org
2024-01-11 11:42 ` cvs-commit at gcc dot gnu.org
2024-01-11 11:43 ` cvs-commit at gcc dot gnu.org
2024-01-11 11:44 ` cvs-commit at gcc dot gnu.org
2024-01-11 12:31 ` kmatsui at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).