[Bug c++/113292] New: [modules] internal error when compiling header to module containing static thread_local variable

[Bug c++/113292] New: [modules] internal error when compiling header to module containing static thread_local variable

[nov.ondrej at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113292

            Bug ID: 113292
           Summary: [modules] internal error when compiling header to
                    module containing static thread_local variable
           Product: gcc
           Version: 13.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: nov.ondrej at gmail dot com
  Target Milestone: ---

may be similar to #99187

you can also see here : https://godbolt.org/z/o4Kf8ed85

class test {
    static const test &get_instance() {
        return instance;
    }
    static thread_local test instance;
};


Compile with :-std=c++20 -fmodules-ts -x c++-header

internal compiler error: in tree_node, at cp/module.cc:9264
0x263852c internal_error(char const*, ...)
        ???:0
0xa4edb5 fancy_abort(char const*, int, char const*)
        ???:0
0xbbf621 trees_out::core_vals(tree_node*)
        ???:0
0xbc1ef8 trees_out::tree_value(tree_node*)
        ???:0
0xbbea88 trees_out::tree_node(tree_node*)
        ???:0
...



The error appears, when function is reading static thread_local variable

Ondrej

[Bug c++/113292] [modules] internal error when compiling header to module containing static thread_local variable

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113292

--- Comment #1 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Nathaniel Shead <nshead@gcc.gnu.org>:

https://gcc.gnu.org/g:14338386970bc6c2d46b81181f48622fdf25d705

commit r14-8168-g14338386970bc6c2d46b81181f48622fdf25d705
Author: Nathaniel Shead <nathanieloshead@gmail.com>
Date:   Thu Jan 11 16:49:39 2024 +1100

    c++: Support thread_local statics in header modules [PR113292]

    Currently, thread_locals in header modules cause ICEs. This patch makes
    the required changes for them to work successfully.

    This requires additionally writing the DECL_TLS_MODEL for thread-local
    variables to the module interface, and the TLS wrapper function needs to
    have its DECL_BEFRIENDING_CLASSES written too as this is used to
    retrieve what VAR_DECL it's a wrapper for when emitting a definition at
    end of TU processing.

            PR c++/113292

    gcc/cp/ChangeLog:
            * decl2.cc (get_tls_wrapper_fn): Set DECL_CONTEXT.
            (c_parse_final_cleanups): Suppress warning for no definition of
            TLS wrapper functions in header modules.
            * module.cc (trees_out::lang_decl_vals): Write wrapped variable
            for TLS wrapper functions.
            (trees_in::lang_decl_vals): Read it.
            (trees_out::decl_value): Write TLS model for thread-local vars.
            (trees_in::decl_value): Read it for new decls. Remember to emit
            definitions of TLS wrapper functions later.

    gcc/testsuite/ChangeLog:

            * g++.dg/modules/pr113292_a.H: New test.
            * g++.dg/modules/pr113292_b.C: New test.
            * g++.dg/modules/pr113292_c.C: New test.

    Signed-off-by: Nathaniel Shead <nathanieloshead@gmail.com>

[Bug c++/113292] [modules] internal error when compiling header to module containing static thread_local variable

[nshead at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113292

Nathaniel Shead <nshead at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0
           Keywords|                            |ice-on-valid-code
             Blocks|                            |103524
         Resolution|---                         |FIXED
                 CC|                            |nshead at gcc dot gnu.org
             Status|UNCONFIRMED                 |RESOLVED
           Assignee|unassigned at gcc dot gnu.org      |nshead at gcc dot gnu.org

--- Comment #2 from Nathaniel Shead <nshead at gcc dot gnu.org> ---
Fixed for GCC 14.


Referenced Bugs:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=103524
[Bug 103524] [meta-bug] modules issue