public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug middle-end/113364] New: [14 regression] Failed bootstrap
@ 2024-01-12 20:54 sjames at gcc dot gnu.org
  2024-01-12 20:55 ` [Bug middle-end/113364] " sjames at gcc dot gnu.org
                   ` (22 more replies)
  0 siblings, 23 replies; 24+ messages in thread
From: sjames at gcc dot gnu.org @ 2024-01-12 20:54 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

            Bug ID: 113364
           Summary: [14 regression] Failed bootstrap
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: middle-end
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
                CC: tnfchris at gcc dot gnu.org
  Target Milestone: ---

```
libtool: compile: 
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/build/./gcc/xgcc -shared-libgcc
-B/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/build/./gcc -nostdinc++
-L/var/tmp/portage/sys-devel/gcc-14
.0.1.9999/work/build/x86_64-pc-linux-gnu/32/libstdc++-v3/src
-L/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/build/x86_64-pc-linux-gnu/32/libstdc++-v3/src/.libs
-L/var/tmp/portage/sys-devel/gcc-14.0.1.9999/
work/build/x86_64-pc-linux-gnu/32/libstdc++-v3/libsupc++/.libs
-B/usr/x86_64-pc-linux-gnu/bin/ -B/usr/x86_64-pc-linux-gnu/lib/ -isystem
/usr/x86_64-pc-linux-gnu/include -isystem /usr/x86_64-pc-linux-gnu/sys-i
nclude -m32 -D_GNU_SOURCE -D_DEBUG -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -DHAVE_RPC_XDR_H=0
-DHAVE_TIRPC_RPC_XDR_H=0 -I.
-I/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-1
4.0.1.9999/libsanitizer/sanitizer_common -I.. -I
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/libsanitizer/include
-I /var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/libsani
tizer -isystem
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/libsanitizer/include/system
-Wall -W -Wno-unused-parameter -Wwrite-strings -pedantic -Wno-long-long -fPIC
-fno-builtin -fno-excep
tions -fno-rtti -fomit-frame-pointer -funwind-tables -fvisibility=hidden
-Wno-variadic-macros -I../../libstdc++-v3/include
-I../../libstdc++-v3/include/x86_64-pc-linux-gnu
-I/var/tmp/portage/sys-devel/gcc-14.
0.1.9999/work/gcc-14.0.1.9999/libsanitizer/../libstdc++-v3/libsupc++
-std=gnu++14 -fcf-protection -mshstk -DSANITIZER_LIBBACKTRACE
-DSANITIZER_CP_DEMANGLE -I /var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gc
c-14.0.1.9999/libsanitizer/../libbacktrace -I ../libbacktrace -I
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/libsanitizer/../include
-include /var/tmp/portage/sys-devel/gcc-14.0.1.9999/wor
k/gcc-14.0.1.9999/libsanitizer/libbacktrace/backtrace-rename.h -g -O2 -O3
-march=native -mtls-dialect=gnu2 -fno-semantic-interposition -pipe -Wa,-O2
-Wa,-mtune=znver2 -fcf-protection=none -fdiagnostics-color=
always -fdiagnostics-urls=never -ggdb3 -fno-harden-control-flow-redundancy
-march=znver2 -O3 -fno-harden-control-flow-redundancy -D_GNU_SOURCE -m32 -c
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.
1.9999/libsanitizer/sanitizer_common/sanitizer_stack_store.cpp  -fPIC -DPIC -o
.libs/sanitizer_stack_store.o
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/libsanitizer/sanitizer_common/sanitizer_stack_store.cpp:246:6:
warning: ISO C++ forbids flexible array member ‘data’ [-Wpedantic]
  246 |   u8 data[];
      |      ^~~~
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/libsanitizer/sanitizer_common/sanitizer_stack_store.cpp:
In member function ‘__sanitizer::uptr*
__sanitizer::StackStore::BlockInfo::GetOrUnpack(
__sanitizer::StackStore*)’:
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/libsanitizer/sanitizer_common/sanitizer_stack_store.cpp:253:7:
error: definition in block 21 does not dominate use in block 20
  253 | uptr *StackStore::BlockInfo::GetOrUnpack(StackStore *store) {
      |       ^~~~~~~~~~
for SSA_NAME: vect_value_119.379_149 in statement:
vect_value_119.379_143 = PHI <vect_value_119.379_149(20)>
PHI argument
vect_value_119.379_149
for PHI node
vect_value_119.379_143 = PHI <vect_value_119.379_149(20)>
during GIMPLE pass: vect
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/libsanitizer/sanitizer_common/sanitizer_stack_store.cpp:253:7:
internal compiler error: verify_ssa failed
0x55623ca579c2 verify_ssa(bool, bool) [clone .constprop.0]
       
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/gcc/tree-ssa.cc:1203
0x55623e17bd05 execute_function_todo
       
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/gcc/passes.cc:2095
0x55623e17bd05 do_per_function
       
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/gcc/passes.cc:1687
0x55623e17bd05 execute_todo
       
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/gcc/passes.cc:2142
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
make[8]: *** [Makefile:627: sanitizer_stack_store.lo] Error 1
```

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] Failed bootstrap
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
@ 2024-01-12 20:55 ` sjames at gcc dot gnu.org
  2024-01-12 20:59 ` pinskia at gcc dot gnu.org
                   ` (21 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: sjames at gcc dot gnu.org @ 2024-01-12 20:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #1 from Sam James <sjames at gcc dot gnu.org> ---
Ugh, I lost the builddir, so give me an hour or so to get it back...

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] Failed bootstrap
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
  2024-01-12 20:55 ` [Bug middle-end/113364] " sjames at gcc dot gnu.org
@ 2024-01-12 20:59 ` pinskia at gcc dot gnu.org
  2024-01-12 22:36 ` jakub at gcc dot gnu.org
                   ` (20 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-01-12 20:59 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0
           Keywords|                            |build, ice-on-valid-code
                 CC|                            |pinskia at gcc dot gnu.org

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] Failed bootstrap
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
  2024-01-12 20:55 ` [Bug middle-end/113364] " sjames at gcc dot gnu.org
  2024-01-12 20:59 ` pinskia at gcc dot gnu.org
@ 2024-01-12 22:36 ` jakub at gcc dot gnu.org
  2024-01-12 22:41 ` pinskia at gcc dot gnu.org
                   ` (19 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-01-12 22:36 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Please provide more details, certainly my x86_64-linux and i686-linux
bootstraps went fine.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] Failed bootstrap
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (2 preceding siblings ...)
  2024-01-12 22:36 ` jakub at gcc dot gnu.org
@ 2024-01-12 22:41 ` pinskia at gcc dot gnu.org
  2024-01-13  5:36 ` sjames at gcc dot gnu.org
                   ` (18 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-01-12 22:41 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note the most important part of the command line is `-march=znver2 -O3` .

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] Failed bootstrap
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (3 preceding siblings ...)
  2024-01-12 22:41 ` pinskia at gcc dot gnu.org
@ 2024-01-13  5:36 ` sjames at gcc dot gnu.org
  2024-01-13  5:41 ` pinskia at gcc dot gnu.org
                   ` (17 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: sjames at gcc dot gnu.org @ 2024-01-13  5:36 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #4 from Sam James <sjames at gcc dot gnu.org> ---
Created attachment 57064
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57064&action=edit
sanitizer_stack_store.ii

Crashes with:
```
# /var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/build/./gcc/xgcc -c
-shared-libgcc -B/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/build/./gcc
-nostdinc++ ./.libs/sanitizer_stack_store.ii -std=gnu++14 -m32 -O3
-march=znver2
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/libsanitizer/sanitizer_common/sanitizer_stack_store.cpp:
In member function ‘__sanitizer::uptr*
__sanitizer::StackStore::BlockInfo::GetOrUnpack(__sanitizer::StackStore*)’:
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/libsanitizer/sanitizer_common/sanitizer_stack_store.cpp:253:7:
error: definition in block 31 does not dominate use in block 30
  253 | uptr *StackStore::BlockInfo::GetOrUnpack(StackStore *store) {
      |       ^~~~~~~~~~
for SSA_NAME: vect_value_122.379_589 in statement:
vect_value_122.379_590 = PHI <vect_value_122.379_589(30)>
PHI argument
vect_value_122.379_589
for PHI node
vect_value_122.379_590 = PHI <vect_value_122.379_589(30)>
during GIMPLE pass: vect
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/libsanitizer/sanitizer_common/sanitizer_stack_store.cpp:253:7:
internal compiler error: verify_ssa failed
0x5604d3777a76 verify_ssa(bool, bool) [clone .constprop.0]
       
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/gcc/tree-ssa.cc:1203
0x5604d4e9b845 execute_function_todo
       
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/gcc/passes.cc:2095
0x5604d4e9b845 do_per_function
       
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/gcc/passes.cc:1687
0x5604d4e9b845 execute_todo
       
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/gcc/passes.cc:2142
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

```
# /var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/build/./gcc/xgcc -v
Using built-in specs.
COLLECT_GCC=/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/build/./gcc/xgcc
Target: x86_64-pc-linux-gnu
Configured with:
/var/tmp/portage/sys-devel/gcc-14.0.1.9999/work/gcc-14.0.1.9999/configure
--host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr
--bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/14
--includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/14/include
--datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/14
--mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/14/man
--infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/14/info
--with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14
--disable-silent-rules --disable-dependency-tracking
--with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/14/python
--enable-languages=c,c++,fortran --enable-obsolete --enable-secureplt
--disable-werror --with-system-zlib --enable-nls --without-included-gettext
--disable-libunwind-exceptions --enable-checking=yes,extra,rtl
--with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo Hardened
14.0.1 p, commit 9d69e54a3b402b0fad067464bd402e92c14504a9'
--with-gcc-major-version-only --enable-libstdcxx-time --enable-lto
--disable-libstdcxx-pch --enable-shared --enable-threads=posix
--enable-__cxa_atexit --enable-clocale=gnu --enable-multilib
--with-multilib-list=m32,m64 --disable-fixed-point --enable-targets=all
--enable-libgomp --disable-libssp --disable-libada --enable-cet
--disable-systemtap --enable-valgrind-annotations --disable-vtable-verify
--disable-libvtv --with-zstd --with-isl --disable-isl-version-check
--enable-default-pie --enable-host-pie --enable-host-bind-now
--enable-default-ssp --with-build-config='bootstrap-O3 bootstrap-lto
bootstrap-cet'
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.1 20240112 (experimental)
8b447fa89d5e6b052c9309dfd1dafebdbd829ff9 (Gentoo Hardened 14.0.1 p, commit
9d69e54a3b402b0fad067464bd402e92c14504a9)
```

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] Failed bootstrap
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (4 preceding siblings ...)
  2024-01-13  5:36 ` sjames at gcc dot gnu.org
@ 2024-01-13  5:41 ` pinskia at gcc dot gnu.org
  2024-01-13  6:10 ` pinskia at gcc dot gnu.org
                   ` (16 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-01-13  5:41 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Still happens at r14-7220-gac1a399bf61b04 .

Let me try to reduce it.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] Failed bootstrap
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (5 preceding siblings ...)
  2024-01-13  5:41 ` pinskia at gcc dot gnu.org
@ 2024-01-13  6:10 ` pinskia at gcc dot gnu.org
  2024-01-13  6:11 ` [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2` pinskia at gcc dot gnu.org
                   ` (15 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-01-13  6:10 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Created attachment 57065
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57065&action=edit
Reduced testcase

`-O3 -march=znver2 ` is enough with this testcase to reproduce it.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (6 preceding siblings ...)
  2024-01-13  6:10 ` pinskia at gcc dot gnu.org
@ 2024-01-13  6:11 ` pinskia at gcc dot gnu.org
  2024-01-13  6:27 ` pinskia at gcc dot gnu.org
                   ` (14 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-01-13  6:11 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[14 regression] Failed      |[14 regression] ICE
                   |bootstrap                   |verify_ssa: `definition in
                   |                            |block N does not dominate
                   |                            |use in block` with `-O3
                   |                            |-march=znver2`
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2024-01-13

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (7 preceding siblings ...)
  2024-01-13  6:11 ` [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2` pinskia at gcc dot gnu.org
@ 2024-01-13  6:27 ` pinskia at gcc dot gnu.org
  2024-01-13  8:04 ` tnfchris at gcc dot gnu.org
                   ` (13 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-01-13  6:27 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |aarch64-linux-gnu
                   |                            |x86_64-linux-gnu

--- Comment #7 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note the testcase also ICEs on aarch64 with just -O3.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (8 preceding siblings ...)
  2024-01-13  6:27 ` pinskia at gcc dot gnu.org
@ 2024-01-13  8:04 ` tnfchris at gcc dot gnu.org
  2024-01-13  9:03 ` tnfchris at gcc dot gnu.org
                   ` (12 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-01-13  8:04 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |tnfchris at gcc dot gnu.org
             Status|NEW                         |ASSIGNED

--- Comment #8 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Hmm curious, does it work for you with --with-build-config='bootstrap-O3'
that's how I tested it before

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (9 preceding siblings ...)
  2024-01-13  8:04 ` tnfchris at gcc dot gnu.org
@ 2024-01-13  9:03 ` tnfchris at gcc dot gnu.org
  2024-01-13 11:52 ` sjames at gcc dot gnu.org
                   ` (11 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-01-13  9:03 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #9 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
vect_create_epilog_for_reduction needs to handle the case where the vectorizer
has picked a different exit than the main one.

diff --git a/gcc/tree-vect-loop.cc b/gcc/tree-vect-loop.cc
index eccf0953bba..6f761a4a78f 100644
--- a/gcc/tree-vect-loop.cc
+++ b/gcc/tree-vect-loop.cc
@@ -5965,7 +5965,8 @@ vect_create_epilog_for_reduction (loop_vec_info
loop_vinfo,
      loop-closed PHI of the inner loop which we remember as
      def for the reduction PHI generation.  */
   bool double_reduc = false;
-  bool main_exit_p = LOOP_VINFO_IV_EXIT (loop_vinfo) == loop_exit;
+  bool main_exit_p = LOOP_VINFO_IV_EXIT (loop_vinfo) == loop_exit
+                    && !LOOP_VINFO_EARLY_BREAKS_VECT_PEELED (loop_vinfo);
   stmt_vec_info rdef_info = stmt_info;
   if (STMT_VINFO_DEF_TYPE (stmt_info) == vect_double_reduction_def)
     {

fixes it. But would be good if I can reproduce the bootstrap issue. Will try
with provided options.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (10 preceding siblings ...)
  2024-01-13  9:03 ` tnfchris at gcc dot gnu.org
@ 2024-01-13 11:52 ` sjames at gcc dot gnu.org
  2024-01-15  8:26 ` rguenth at gcc dot gnu.org
                   ` (10 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: sjames at gcc dot gnu.org @ 2024-01-13 11:52 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #10 from Sam James <sjames at gcc dot gnu.org> ---
(In reply to Tamar Christina from comment #8)
> Hmm curious, does it work for you with --with-build-config='bootstrap-O3'
> that's how I tested it before

Will have a look. I'll try ignore the bootstrap failure and build userland
stuff now so we can get some other cases if any.

Did you have -march=<some ISA with good enough vector instructions> too? I
imagine bare '-O2' or '-O3' will be ok on amd64.

I built with the above configure args but also:
1. make -j32 -l32 'STAGE1_CFLAGS=-O3 -march=znver2 -pipe' 'BOOT_CFLAGS=-O3
-march=znver2 -pipe' ...
2. CFLAGS=... exported in the env

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (11 preceding siblings ...)
  2024-01-13 11:52 ` sjames at gcc dot gnu.org
@ 2024-01-15  8:26 ` rguenth at gcc dot gnu.org
  2024-01-15  8:55 ` jakub at gcc dot gnu.org
                   ` (9 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-01-15  8:26 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P1

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (12 preceding siblings ...)
  2024-01-15  8:26 ` rguenth at gcc dot gnu.org
@ 2024-01-15  8:55 ` jakub at gcc dot gnu.org
  2024-01-23  8:28 ` rguenth at gcc dot gnu.org
                   ` (8 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-01-15  8:55 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #11 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Like in PR113374, started to ICE with one message in                            
r14-7194-g6cb155a6cf314232248a12bdd395ed4151ae5a28, another one in              
r14-7195-g411de96dbf2bdafc7a90ebbfc63e68afd6388d29 and yet another one          
r14-7196-g99c0a540d6689ede068f9ba98af6f38c3cd71362 which is what we get until   
latest trunk.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (13 preceding siblings ...)
  2024-01-15  8:55 ` jakub at gcc dot gnu.org
@ 2024-01-23  8:28 ` rguenth at gcc dot gnu.org
  2024-01-23  8:31 ` tnfchris at gcc dot gnu.org
                   ` (7 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: rguenth at gcc dot gnu.org @ 2024-01-23  8:28 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2024-01-13 00:00:00         |2024-1-23

--- Comment #12 from Richard Biener <rguenth at gcc dot gnu.org> ---
Re-confirmed after my fixes btw.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (14 preceding siblings ...)
  2024-01-23  8:28 ` rguenth at gcc dot gnu.org
@ 2024-01-23  8:31 ` tnfchris at gcc dot gnu.org
  2024-01-23  8:31 ` tnfchris at gcc dot gnu.org
                   ` (6 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-01-23  8:31 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #13 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Yes I had to rerun my baseline after updating trunk. Will post patch once peak
finishes

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (15 preceding siblings ...)
  2024-01-23  8:31 ` tnfchris at gcc dot gnu.org
@ 2024-01-23  8:31 ` tnfchris at gcc dot gnu.org
  2024-01-23 14:11 ` tnfchris at gcc dot gnu.org
                   ` (5 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-01-23  8:31 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #14 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Yes I had to rerun my baseline after updating trunk. Will post patch once peak
finishes

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (16 preceding siblings ...)
  2024-01-23  8:31 ` tnfchris at gcc dot gnu.org
@ 2024-01-23 14:11 ` tnfchris at gcc dot gnu.org
  2024-01-23 15:48 ` tnfchris at gcc dot gnu.org
                   ` (4 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-01-23 14:11 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #15 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Ok, the fix fixes the ICE but after rebasing to trunk I get a misscompile
during bootstrap which miscompiles the x86 backend.

This is likely related to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113539
so tracking it down...

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (17 preceding siblings ...)
  2024-01-23 14:11 ` tnfchris at gcc dot gnu.org
@ 2024-01-23 15:48 ` tnfchris at gcc dot gnu.org
  2024-01-24  7:37 ` cvs-commit at gcc dot gnu.org
                   ` (3 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-01-23 15:48 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #16 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
Ok, I've submitted the patch since the ICE and miscompare are unrelated.

I'll keep this ticket open in any case.  The miscompares didn't happen based on
commits from ~2 weeks ago, So this will give me a place to start.

Hopefully send a patch for those tomorrow.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (18 preceding siblings ...)
  2024-01-23 15:48 ` tnfchris at gcc dot gnu.org
@ 2024-01-24  7:37 ` cvs-commit at gcc dot gnu.org
  2024-01-24  7:40 ` tnfchris at gcc dot gnu.org
                   ` (2 subsequent siblings)
  22 siblings, 0 replies; 24+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-01-24  7:37 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #17 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Tamar Christina <tnfchris@gcc.gnu.org>:

https://gcc.gnu.org/g:72429448fd16733f876b282bb37a0653049c446d

commit r14-8382-g72429448fd16733f876b282bb37a0653049c446d
Author: Tamar Christina <tamar.christina@arm.com>
Date:   Wed Jan 24 07:37:17 2024 +0000

    middle-end: fix epilog reductions when vector iters peeled [PR113364]

    This fixes a bug where vect_create_epilog_for_reduction does not handle the
    case where all exits are early exits.  In this case we should do like
induction
    handling code does and not have a main exit.

    This shows that some new miscompiles are happening (stage3 is likely
miscompiled)
    but that's unrelated to this patch and I'll look at it next.

    gcc/ChangeLog:

            PR tree-optimization/113364
            * tree-vect-loop.cc (vect_create_epilog_for_reduction): If all
exits all
            early exits then we must reduce from the first offset for all of
them.

    gcc/testsuite/ChangeLog:

            PR tree-optimization/113364
            * gcc.dg/vect/vect-early-break_107-pr113364.c: New test.

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (19 preceding siblings ...)
  2024-01-24  7:37 ` cvs-commit at gcc dot gnu.org
@ 2024-01-24  7:40 ` tnfchris at gcc dot gnu.org
  2024-01-24  7:42 ` tnfchris at gcc dot gnu.org
  2024-01-24  7:43 ` tnfchris at gcc dot gnu.org
  22 siblings, 0 replies; 24+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-01-24  7:40 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dcb314 at hotmail dot com

--- Comment #18 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
*** Bug 113561 has been marked as a duplicate of this bug. ***

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (20 preceding siblings ...)
  2024-01-24  7:40 ` tnfchris at gcc dot gnu.org
@ 2024-01-24  7:42 ` tnfchris at gcc dot gnu.org
  2024-01-24  7:43 ` tnfchris at gcc dot gnu.org
  22 siblings, 0 replies; 24+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-01-24  7:42 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

--- Comment #19 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
*** Bug 113555 has been marked as a duplicate of this bug. ***

^ permalink raw reply	[flat|nested] 24+ messages in thread

* [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2`
  2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
                   ` (21 preceding siblings ...)
  2024-01-24  7:42 ` tnfchris at gcc dot gnu.org
@ 2024-01-24  7:43 ` tnfchris at gcc dot gnu.org
  22 siblings, 0 replies; 24+ messages in thread
From: tnfchris at gcc dot gnu.org @ 2024-01-24  7:43 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113364

Tamar Christina <tnfchris at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #20 from Tamar Christina <tnfchris at gcc dot gnu.org> ---
I'll continue with the miscompile in PR113539 which I think is a duplicate of
PR113467 which I'll verify now.

^ permalink raw reply	[flat|nested] 24+ messages in thread

end of thread, other threads:[~2024-01-24  7:43 UTC | newest]

Thread overview: 24+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-12 20:54 [Bug middle-end/113364] New: [14 regression] Failed bootstrap sjames at gcc dot gnu.org
2024-01-12 20:55 ` [Bug middle-end/113364] " sjames at gcc dot gnu.org
2024-01-12 20:59 ` pinskia at gcc dot gnu.org
2024-01-12 22:36 ` jakub at gcc dot gnu.org
2024-01-12 22:41 ` pinskia at gcc dot gnu.org
2024-01-13  5:36 ` sjames at gcc dot gnu.org
2024-01-13  5:41 ` pinskia at gcc dot gnu.org
2024-01-13  6:10 ` pinskia at gcc dot gnu.org
2024-01-13  6:11 ` [Bug middle-end/113364] [14 regression] ICE verify_ssa: `definition in block N does not dominate use in block` with `-O3 -march=znver2` pinskia at gcc dot gnu.org
2024-01-13  6:27 ` pinskia at gcc dot gnu.org
2024-01-13  8:04 ` tnfchris at gcc dot gnu.org
2024-01-13  9:03 ` tnfchris at gcc dot gnu.org
2024-01-13 11:52 ` sjames at gcc dot gnu.org
2024-01-15  8:26 ` rguenth at gcc dot gnu.org
2024-01-15  8:55 ` jakub at gcc dot gnu.org
2024-01-23  8:28 ` rguenth at gcc dot gnu.org
2024-01-23  8:31 ` tnfchris at gcc dot gnu.org
2024-01-23  8:31 ` tnfchris at gcc dot gnu.org
2024-01-23 14:11 ` tnfchris at gcc dot gnu.org
2024-01-23 15:48 ` tnfchris at gcc dot gnu.org
2024-01-24  7:37 ` cvs-commit at gcc dot gnu.org
2024-01-24  7:40 ` tnfchris at gcc dot gnu.org
2024-01-24  7:42 ` tnfchris at gcc dot gnu.org
2024-01-24  7:43 ` tnfchris at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).