public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "matz at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug tree-optimization/113372] wrong code with _BitInt() arithmetics at -O1 Date: Mon, 15 Jan 2024 14:43:24 +0000 [thread overview] Message-ID: <bug-113372-4-97P3hr5V9D@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-113372-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113372 --- Comment #16 from Michael Matz <matz at gcc dot gnu.org> --- A general remark: in principle I don't see problems with undoing a little CSE, as proposed. I.e. for each SSA name use, see if it (trivially, or conservatively or optimistically) refers to an address of a tracked DECL, and include those in the dont-share set. But I will remark that this then handles code that was invalid to start with as if it were valid, and I'm not sure if this will change diagnostics outcome in any way (it certainly will prevent the slot sharing and hence any diagnostics that are based on such sharing to happen, e.g. when dirtying memory at lifetime-end). What I mean is the classic anti-pattern in C: char * ptr; { char localarray[n]; dosomething (localarray); ptr = localarray; } domore (ptr); The proposed solution will make the reference to the SSA name of 'ptr', even though it was invalid in the source, keep localarray[] to be conflicting and hence unshared with any other surrounding storage. Depending on how PHI nodes are handled this will also mean that an SSA name can't ever be un-associated with a DECL anymore: char * ptr = someotherarray; if (cond1) { char localarray[n]; ptr = localarray; foo (ptr); } if (cond2) { char localarray[n]; ptr = localarray; foo(ptr); } if (!cond1 && !cond2) foo (ptr); Here we will have a PHI for ptr: 'ptr_3 = PHI<ptr_1, ptr_2>'. The question is how the reference(s) to 'localarray' will be handled: does it lead to ptr_3 also referring to them or not. I.e. usual question in PHI merging: optimistic or pessimistic. Note that the answer to the latter question might influence the whole effectiveness of stack slot sharing. IIRC the latter type of code was one of the examples that explodes in stack usage without sharing (localarray[] being instead local C++ objects; but I don't remember if references to them could bleed out of scopes in the same way as above).
next prev parent reply other threads:[~2024-01-15 14:43 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-13 8:53 [Bug tree-optimization/113372] New: " zsojka at seznam dot cz 2024-01-13 9:03 ` [Bug tree-optimization/113372] " pinskia at gcc dot gnu.org 2024-01-15 10:28 ` jakub at gcc dot gnu.org 2024-01-15 10:33 ` jakub at gcc dot gnu.org 2024-01-15 11:25 ` jakub at gcc dot gnu.org 2024-01-15 11:31 ` rguenther at suse dot de 2024-01-15 11:51 ` jakub at gcc dot gnu.org 2024-01-15 12:07 ` jakub at gcc dot gnu.org 2024-01-15 12:19 ` rguenth at gcc dot gnu.org 2024-01-15 12:43 ` jakub at gcc dot gnu.org 2024-01-15 12:55 ` jakub at gcc dot gnu.org 2024-01-15 13:04 ` rguenth at gcc dot gnu.org 2024-01-15 13:35 ` jakub at gcc dot gnu.org 2024-01-15 13:47 ` rguenther at suse dot de 2024-01-15 14:35 ` jakub at gcc dot gnu.org 2024-01-15 14:42 ` rguenth at gcc dot gnu.org 2024-01-15 14:43 ` matz at gcc dot gnu.org [this message] 2024-01-15 14:58 ` jakub at gcc dot gnu.org 2024-01-16 7:21 ` rguenther at suse dot de 2024-01-16 10:51 ` cvs-commit at gcc dot gnu.org 2024-01-16 10:56 ` jakub at gcc dot gnu.org 2024-01-20 17:09 ` pinskia at gcc dot gnu.org 2024-03-02 0:38 ` cvs-commit at gcc dot gnu.org 2024-03-28 11:01 ` jakub at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-113372-4-97P3hr5V9D@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).