public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenth at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113372] wrong code with _BitInt() arithmetics at -O1
Date: Mon, 15 Jan 2024 14:42:40 +0000 [thread overview]
Message-ID: <bug-113372-4-DqY72P7JpC@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113372-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113372
--- Comment #15 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #14)
> Created attachment 57085 [details]
> gcc14-pr113372.patch
>
> The non-propagation workaround which seems to fix^H^H^Hworkaround all those
> 4 issues (PR90348 testcase actually doesn't FAIL anymore, but I've verified
> the patch results in in and buf no longer being shared) can look like this.
+ || (INTEGRAL_TYPE_P (TREE_TYPE (use))
+ && TYPE_PRECISION (TREE_TYPE (use)) == POINTER_SIZE)))
ptrofftype_p (TREE_TYPE (use))
+ {
+ gimple *g = SSA_NAME_DEF_STMT (use);
+ if (is_gimple_assign (g))
+ for (unsigned i = 1; i < gimple_num_ops (g); ++i)
+ {
+ tree op = gimple_op (g, i);
+ if (op && TREE_CODE (op) == ADDR_EXPR)
I think it should be enough to look at gimple_assing_rhs1, that works
for single non-invariant &a[i], for conversions and for offsetting of
an invariant address (pointer-plus).
I'd say OK with those changes.
next prev parent reply other threads:[~2024-01-15 14:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-13 8:53 [Bug tree-optimization/113372] New: " zsojka at seznam dot cz
2024-01-13 9:03 ` [Bug tree-optimization/113372] " pinskia at gcc dot gnu.org
2024-01-15 10:28 ` jakub at gcc dot gnu.org
2024-01-15 10:33 ` jakub at gcc dot gnu.org
2024-01-15 11:25 ` jakub at gcc dot gnu.org
2024-01-15 11:31 ` rguenther at suse dot de
2024-01-15 11:51 ` jakub at gcc dot gnu.org
2024-01-15 12:07 ` jakub at gcc dot gnu.org
2024-01-15 12:19 ` rguenth at gcc dot gnu.org
2024-01-15 12:43 ` jakub at gcc dot gnu.org
2024-01-15 12:55 ` jakub at gcc dot gnu.org
2024-01-15 13:04 ` rguenth at gcc dot gnu.org
2024-01-15 13:35 ` jakub at gcc dot gnu.org
2024-01-15 13:47 ` rguenther at suse dot de
2024-01-15 14:35 ` jakub at gcc dot gnu.org
2024-01-15 14:42 ` rguenth at gcc dot gnu.org [this message]
2024-01-15 14:43 ` matz at gcc dot gnu.org
2024-01-15 14:58 ` jakub at gcc dot gnu.org
2024-01-16 7:21 ` rguenther at suse dot de
2024-01-16 10:51 ` cvs-commit at gcc dot gnu.org
2024-01-16 10:56 ` jakub at gcc dot gnu.org
2024-01-20 17:09 ` pinskia at gcc dot gnu.org
2024-03-02 0:38 ` cvs-commit at gcc dot gnu.org
2024-03-28 11:01 ` jakub at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-113372-4-DqY72P7JpC@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).