[Bug c/113438] New: ICE (segfault) in dwarf2out_decl with -g -std=c23 on c23-tag-composite-2.c

[Bug c/113438] New: ICE (segfault) in dwarf2out_decl with -g -std=c23 on c23-tag-composite-2.c

[acoplan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113438

            Bug ID: 113438
           Summary: ICE (segfault) in dwarf2out_decl with -g -std=c23 on
                    c23-tag-composite-2.c
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: c
          Assignee: unassigned at gcc dot gnu.org
          Reporter: acoplan at gcc dot gnu.org
  Target Milestone: ---

I did a testsuite run with -g on aarch64 and noticed the following ICE:

$ gcc/xgcc -B gcc -c
~/toolchain/src/gcc/gcc/testsuite/gcc.dg/c23-tag-composite-2.c -g -std=c23
/home/alecop01/toolchain/src/gcc/gcc/testsuite/gcc.dg/c23-tag-composite-2.c:15:21:
internal compiler error: Segmentation fault
   15 | void g(const struct foo { int x; } a);
      |                     ^~~
0xf15783 crash_signal
        /home/alecop01/toolchain/src/other_gcc/gcc/toplev.cc:317
0xa23f04 dwarf2out_decl
        /home/alecop01/toolchain/src/other_gcc/gcc/dwarf2out.cc:27611
0xa242c3 dwarf2out_type_decl
        /home/alecop01/toolchain/src/other_gcc/gcc/dwarf2out.cc:27405
0xa242c3 dwarf2out_type_decl
        /home/alecop01/toolchain/src/other_gcc/gcc/dwarf2out.cc:27400
0xde0d8b rest_of_type_compilation(tree_node*, int)
        /home/alecop01/toolchain/src/other_gcc/gcc/passes.cc:339
0x79ce17 finish_struct(unsigned int, tree_node*, tree_node*, tree_node*,
c_struct_parse_info*, tree_node**)
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-decl.cc:9733
0x7b29a7 composite_type_internal(tree_node*, tree_node*, composite_cache*)
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-typeck.cc:588
0x7b1867 composite_type_internal(tree_node*, tree_node*, composite_cache*)
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-typeck.cc:408
0x7b1867 composite_type_internal(tree_node*, tree_node*, composite_cache*)
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-typeck.cc:730
0x7b376f composite_type_internal(tree_node*, tree_node*, composite_cache*)
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-typeck.cc:408
0x7b376f composite_type(tree_node*, tree_node*)
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-typeck.cc:748
0x77c613 merge_decls
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-decl.cc:2798
0x77c613 duplicate_decls
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-decl.cc:3185
0x780347 pushdecl(tree_node*)
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-decl.cc:3374
0x798ba7 start_decl(c_declarator*, c_declspecs*, bool, tree_node*, bool,
unsigned int*)
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-decl.cc:5703
0x81bce3 c_parser_declaration_or_fndef
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-parser.cc:2766
0x82962f c_parser_external_declaration
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-parser.cc:2046
0x82a16f c_parser_translation_unit
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-parser.cc:1900
0x82a16f c_parse_file()
        /home/alecop01/toolchain/src/other_gcc/gcc/c/c-parser.cc:26815
0x8aa8df c_common_parse_file()
        /home/alecop01/toolchain/src/other_gcc/gcc/c-family/c-opts.cc:1301
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

[Bug c/113438] ICE (segfault) in dwarf2out_decl with -g -std=c23 on c23-tag-composite-2.c

[acoplan at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113438

--- Comment #1 from Alex Coplan <acoplan at gcc dot gnu.org> ---
I also noticed the following C23 failures, not sure if these are worth tracking
separately or not:

FAIL: gcc.dg/gnu23-tag-1.c (internal compiler error: 'verify_type' failed)
FAIL: gcc.dg/gnu23-tag-4.c (internal compiler error: 'verify_type' failed)
FAIL: gcc.dg/gnu23-tag-alias-1.c (internal compiler error: 'verify_type'
failed)

[Bug c/113438] ICE (segfault) in dwarf2out_decl with -g -std=c23 on c23-tag-composite-2.c

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113438

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-01-17
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed, I'm seeing this as well.

[Bug c/113438] ICE (segfault) in dwarf2out_decl with -g -std=c23 on c23-tag-composite-2.c

[uecker at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113438

uecker at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|aarch64-*-*                 |

--- Comment #3 from uecker at gcc dot gnu.org ---
Not aarch64 specific.

[Bug c/113438] ICE (segfault) in dwarf2out_decl with -g -std=c23 on c23-tag-composite-2.c

[uecker at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113438

--- Comment #4 from uecker at gcc dot gnu.org ---
Created attachment 57194
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57194&action=edit
preliminary patch

[Bug c/113438] ICE (segfault) in dwarf2out_decl with -g -std=c23 on c23-tag-composite-2.c

[muecker at gwdg dot de]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113438

--- Comment #5 from Martin Uecker <muecker at gwdg dot de> ---
PATCH: https://gcc.gnu.org/pipermail/gcc-patches/2024-January/644124.html

[Bug c/113438] ICE (segfault) in dwarf2out_decl with -g -std=c23 on c23-tag-composite-2.c

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113438

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Martin Uecker <uecker@gcc.gnu.org>:

https://gcc.gnu.org/g:f6ba433d3c30c20fadd393eed31617a4da81789c

commit r14-8666-gf6ba433d3c30c20fadd393eed31617a4da81789c
Author: Martin Uecker <uecker@tugraz.at>
Date:   Tue Jan 23 13:33:34 2024 +0100

    Fix ICE with -g and -std=c23 when forming composite types [PR113438]

    Set TYPE_STUB_DECL to an artificial decl when creating a new structure
    as a composite type.

            PR c/113438

    gcc/c/
            * c-typeck.cc (composite_type_internal): Set TYPE_STUB_DECL.

    gcc/testsuite/
            * gcc.dg/pr113438.c: New test.

[Bug c/113438] ICE (segfault) in dwarf2out_decl with -g -std=c23 on c23-tag-composite-2.c

[uecker at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113438

uecker at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #7 from uecker at gcc dot gnu.org ---
I filed PR113688 for the verify_type failures with -g.

This bug is fixed on trunk.