[Bug libgomp/113448] New: libgomp.c/alloc-pinned-1.c etc. XPASS

[Bug libgomp/113448] New: libgomp.c/alloc-pinned-1.c etc. XPASS

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113448

            Bug ID: 113448
           Summary: libgomp.c/alloc-pinned-1.c etc. XPASS
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libgomp
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: ams at gcc dot gnu.org, jakub at gcc dot gnu.org
  Target Milestone: ---
            Target: *-*-solaris2.11

Two new libgomp testcases introduced in

commit 348874f0baac0f22c98ab11abbfa65fd172f6bdd
Author: Andrew Stubbs <ams@codesourcery.com>
Date:   Tue Jan 4 12:22:01 2022 +0000

    libgomp: basic pinned memory on Linux

XPASS on Solaris/SPARC and x86, 32 and 64-bit:

+XPASS: libgomp.c/alloc-pinned-1.c execution test
+XPASS: libgomp.c/alloc-pinned-2.c execution test

The tests emit

OS unsupported

The XPASSes are no wonder since on any non-Linux target, the tests have

int  
get_pinned_mem ()
{ 
  return 0;
} 

and at the same time

/* { dg-xfail-run-if "Pinning not implemented on this host" { ! *-*-linux-gnu }
} */

However, the test fake-PASSes, thus the XPASS.  I believe get_pinned_mem should
simply abort() on unsupported OSes.

[Bug libgomp/113448] libgomp.c/alloc-pinned-1.c etc. XPASS

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113448

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug libgomp/113448] libgomp.c/alloc-pinned-1.c etc. XPASS

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113448

John David Anglin <danglin at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |danglin at gcc dot gnu.org

--- Comment #1 from John David Anglin <danglin at gcc dot gnu.org> ---
Same issue observed on hppa64-hp-hpux11.11.

[Bug libgomp/113448] libgomp.c/alloc-pinned-1.c etc. XPASS

[danglin at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113448

--- Comment #2 from John David Anglin <danglin at gcc dot gnu.org> ---
The tests fail on hppa-unknown-linux-gnu:
FAIL: libgomp.c/alloc-pinned-1.c execution test
FAIL: libgomp.c/alloc-pinned-2.c execution test
FAIL: libgomp.c/alloc-pinned-3.c execution test
FAIL: libgomp.c/alloc-pinned-4.c execution test

[Bug libgomp/113448] libgomp.c/alloc-pinned-1.c etc. XPASS

[seurer at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113448

seurer at gcc dot gnu.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |seurer at gcc dot gnu.org

--- Comment #3 from seurer at gcc dot gnu.org ---
-1 and -2 fail on powerpc64 LE

make  -k check-target-libgomp RUNTESTFLAGS="c.exp=libgomp.c/alloc-pinned-*"
FAIL: libgomp.c/alloc-pinned-1.c execution test
FAIL: libgomp.c/alloc-pinned-2.c execution test


-3 and -4 fail on powerpc64 BE

make  -k check-target-libgomp RUNTESTFLAGS="--target_board=unix'{-m32,-m64}'
c.exp=libgomp.c/alloc-pinned-*"
FAIL: libgomp.c/alloc-pinned-3.c execution test
FAIL: libgomp.c/alloc-pinned-4.c execution test

[Bug libgomp/113448] libgomp.c/alloc-pinned-1.c etc. XPASS

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113448

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-02-05
             Status|UNCONFIRMED                 |NEW

--- Comment #4 from Rainer Orth <ro at gcc dot gnu.org> ---
(In reply to seurer from comment #3)
> -1 and -2 fail on powerpc64 LE
> 
> make  -k check-target-libgomp RUNTESTFLAGS="c.exp=libgomp.c/alloc-pinned-*"
> FAIL: libgomp.c/alloc-pinned-1.c execution test
> FAIL: libgomp.c/alloc-pinned-2.c execution test
> 
> 
> -3 and -4 fail on powerpc64 BE
> 
> make  -k check-target-libgomp RUNTESTFLAGS="--target_board=unix'{-m32,-m64}'
> c.exp=libgomp.c/alloc-pinned-*"
> FAIL: libgomp.c/alloc-pinned-3.c execution test
> FAIL: libgomp.c/alloc-pinned-4.c execution test

This PR is about the tests XPASSing on non-Linux targets, while those are FAILs
on Linux.  They are completely unrelated, so better file them separately so
they
are not forgotten.

[Bug libgomp/113448] libgomp.c/alloc-pinned-1.c etc. XPASS

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113448

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:

https://gcc.gnu.org/g:1e94648ab7b370c5867e146c7f59603e2e6ba2e6

commit r14-8930-g1e94648ab7b370c5867e146c7f59603e2e6ba2e6
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Mon Feb 12 14:44:17 2024 +0100

    libgomp: testsuite: Don't XPASS libgomp.c/alloc-pinned-1.c etc. on
non-Linux targets [PR113448]

    Two libgomp tests XPASS on Solaris (any non-Linux target actually) since
    their introduction:

    XPASS: libgomp.c/alloc-pinned-1.c execution test
    XPASS: libgomp.c/alloc-pinned-2.c execution test

    The problem is that the test just prints

    OS unsupported

    and exits successfully, while the test is XFAILed:

    /* { dg-xfail-run-if "Pinning not implemented on this host" { !
*-*-linux-gnu } } */

    Fixed by aborting immediately after the message above in the non-Linux
    case.

    Tested on i386-pc-solaris2.11 and i686-pc-linux-gnu.

    2024-02-02  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

            libgomp:
            PR testsuite/113448
            * testsuite/libgomp.c/alloc-pinned-1.c [!__linux__] (CHECK_SIZE):
            Call abort.
            * testsuite/libgomp.c/alloc-pinned-2.c [!__linux__] (CHECK_SIZE):
            Likewise.

[Bug libgomp/113448] libgomp.c/alloc-pinned-1.c etc. XPASS

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113448

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |ro at gcc dot gnu.org
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> ---
Fixed for GCC 14.0.1.