public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug libstdc++/113450] [14 Regression] std/format/functions/format.cc FAILs
Date: Wed, 17 Jan 2024 21:32:24 +0000	[thread overview]
Message-ID: <bug-113450-4-GjXPgLKBW6@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113450-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113450

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2024-01-17

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
I assume that int8_t is char on Solaris, rather than signed char?

Formatting a char behaves differently from signed char, and other integral
types.

I think this will fix it:

--- a/libstdc++-v3/testsuite/std/format/functions/format.cc
+++ b/libstdc++-v3/testsuite/std/format/functions/format.cc
@@ -365,7 +365,7 @@ test_minmax()
     s = std::format("{:b}" , std::numeric_limits<U>::max());
     VERIFY( s == '1' + ones );
   };
-  check(std::int8_t(0));
+  check(std::make_signed_t<std::int8_t>(0));
   check(std::int16_t(0));
   check(std::int32_t(0));
   check(std::int64_t(0));


That causes the lambda to use signed char instead of char, and that is
formatted as an integer not a character.

  parent reply	other threads:[~2024-01-17 21:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17 15:06 [Bug libstdc++/113450] New: " ro at gcc dot gnu.org
2024-01-17 15:07 ` [Bug libstdc++/113450] " ro at gcc dot gnu.org
2024-01-17 21:32 ` redi at gcc dot gnu.org [this message]
2024-01-18 10:06 ` [Bug libstdc++/113450] [14 Regression] " ro at CeBiTec dot Uni-Bielefeld.DE
2024-01-18 12:54 ` cvs-commit at gcc dot gnu.org
2024-01-18 12:58 ` redi at gcc dot gnu.org
2024-01-18 21:03 ` cvs-commit at gcc dot gnu.org
2024-01-19  8:47 ` ro at CeBiTec dot Uni-Bielefeld.DE
2024-02-14 16:46 ` redi at gcc dot gnu.org
2024-02-14 16:51 ` jakub at gcc dot gnu.org
2024-02-14 16:54 ` redi at gcc dot gnu.org
2024-02-14 17:00 ` jakub at gcc dot gnu.org
2024-02-20 16:09 ` ro at CeBiTec dot Uni-Bielefeld.DE
2024-02-20 16:11 ` ro at CeBiTec dot Uni-Bielefeld.DE
2024-02-20 16:11 ` ro at CeBiTec dot Uni-Bielefeld.DE
2024-02-21  9:56 ` ro at CeBiTec dot Uni-Bielefeld.DE
2024-02-21 11:33 ` redi at gcc dot gnu.org
2024-02-21 13:34 ` ro at CeBiTec dot Uni-Bielefeld.DE
2024-02-21 16:42 ` jsm28 at gcc dot gnu.org
2024-02-22  8:51 ` ro at CeBiTec dot Uni-Bielefeld.DE
2024-02-26 13:40 ` ro at CeBiTec dot Uni-Bielefeld.DE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113450-4-GjXPgLKBW6@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).