public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113459] ICE: in as_a, at machmode.h:381 with memset() on a _BitInt() at -O1 and above
Date: Fri, 19 Jan 2024 09:02:27 +0000	[thread overview]
Message-ID: <bug-113459-4-Sz6rlQDBnG@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113459-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113459

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:dcd5601c2b7298155c9a8e1bfb93ee8e952eca0b

commit r14-8276-gdcd5601c2b7298155c9a8e1bfb93ee8e952eca0b
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Fri Jan 19 10:00:16 2024 +0100

    sccvn: Don't use SCALAR_INT_TYPE_MODE on BLKmode BITINT_TYPEs [PR113459]

    sccvn uses GET_MODE_SIZE (SCALAR_INT_TYPE_MODE (type)) for INTEGER_TYPEs,
    most likely because that is what native_{interpret,encode}_int used.
    This obviously doesn't work for larger BITINT_TYPEs which have BLKmode
    and the above ICEs on those.  native_{interpret,encode}_int checks whether
    the BITINT_TYPE is medium/large/huge (i.e. an array of 2+ ABI limbs)
    and uses TYPE_SIZE_UNIT for that case, otherwise SCALAR_INT_TYPE_MODE like
    for the INTEGER_TYPE case.

    The following patch instead just uses SCALAR_INT_TYPE_MODE for non-BLKmode
    TYPE_MODE and TYPE_SIZE_UNIT otherwise.

    2024-01-19  Jakub Jelinek  <jakub@redhat.com>

            PR tree-optimization/113459
            * tree-ssa-sccvn.cc (vn_walk_cb_data::push_partial_def): Use
            TREE_INT_CST_LOW of TYPE_SIZE_UNIT rather than GET_MODE_SIZE
            of SCALAR_INT_TYPE_MODE if type has BLKmode.
            (vn_reference_lookup_3): Likewise.  Formatting fix.

            * gcc.dg/bitint-73.c: New test.

  parent reply	other threads:[~2024-01-19  9:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-17 20:33 [Bug tree-optimization/113459] New: " zsojka at seznam dot cz
2024-01-18  8:14 ` [Bug tree-optimization/113459] " rguenth at gcc dot gnu.org
2024-01-18  8:20 ` rguenth at gcc dot gnu.org
2024-01-18  9:34 ` jakub at gcc dot gnu.org
2024-01-18 10:06 ` rguenther at suse dot de
2024-01-18 11:45 ` jakub at gcc dot gnu.org
2024-01-19  9:02 ` cvs-commit at gcc dot gnu.org [this message]
2024-01-19  9:05 ` jakub at gcc dot gnu.org
2024-01-20 17:07 ` pinskia at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113459-4-Sz6rlQDBnG@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).