public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "rguenther at suse dot de" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug tree-optimization/113459] ICE: in as_a, at machmode.h:381 with memset() on a _BitInt() at -O1 and above
Date: Thu, 18 Jan 2024 10:06:17 +0000 [thread overview]
Message-ID: <bug-113459-4-WONWCkYfZE@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113459-4@http.gcc.gnu.org/bugzilla/>
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113459
--- Comment #4 from rguenther at suse dot de <rguenther at suse dot de> ---
On Thu, 18 Jan 2024, jakub at gcc dot gnu.org wrote:
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113459
>
> --- Comment #3 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
> (In reply to Richard Biener from comment #2)
> > unsigned buflen = TREE_INT_CST_LOW (TYPE_SIZE_UNIT (vr->type))
> > + 1;
> > if (INTEGRAL_TYPE_P (vr->type))
> > buflen = GET_MODE_SIZE (SCALAR_INT_TYPE_MODE (vr->type)) + 1;
> >
> > there's other spots using the pattern
> >
> > if (INTEGRAL_TYPE_P (type))
> > sz = GET_MODE_SIZE (SCALAR_INT_TYPE_MODE (type));
> >
> > I wonder when GET_MODE_SIZE differs from TYPE_SIZE_UNIT? PSImode?
>
> I'm afraid I don't know either.
>
> > Packed bitfields? r10-6885-g5f9cd512c42786 added the INTEGRAL_TYPE_P
> > special-casing we now run into with the TYPE_SIZE_UNIT code being there
> > before.
> >
> > Jakub, do you remember?
>
> I bet the above comes from what the native_{encode,interpret}_int has been
> doing (and which has been tweaked for BITINT_TYPE).
> If we don't want to throw it away, we could just change it to
> if (INTEGRAL_TYPE_P (...) && TYPE_MODE (...) != BLKmode)
Yeah, that might work. There are a few occurances in tree-ssa-sccvn.cc
that need such adjustment.
next prev parent reply other threads:[~2024-01-18 10:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 20:33 [Bug tree-optimization/113459] New: " zsojka at seznam dot cz
2024-01-18 8:14 ` [Bug tree-optimization/113459] " rguenth at gcc dot gnu.org
2024-01-18 8:20 ` rguenth at gcc dot gnu.org
2024-01-18 9:34 ` jakub at gcc dot gnu.org
2024-01-18 10:06 ` rguenther at suse dot de [this message]
2024-01-18 11:45 ` jakub at gcc dot gnu.org
2024-01-19 9:02 ` cvs-commit at gcc dot gnu.org
2024-01-19 9:05 ` jakub at gcc dot gnu.org
2024-01-20 17:07 ` pinskia at gcc dot gnu.org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-113459-4-WONWCkYfZE@http.gcc.gnu.org/bugzilla/ \
--to=gcc-bugzilla@gcc.gnu.org \
--cc=gcc-bugs@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).