[Bug target/113486] New: ICE: in extract_insn, at recog.cc:2812 (unrecognizable insn) with -mgeneral-regs-only and __builtin_apply() on aarch64

[Bug target/113486] New: ICE: in extract_insn, at recog.cc:2812 (unrecognizable insn) with -mgeneral-regs-only and __builtin_apply() on aarch64

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113486

            Bug ID: 113486
           Summary: ICE: in extract_insn, at recog.cc:2812 (unrecognizable
                    insn) with -mgeneral-regs-only and __builtin_apply()
                    on aarch64
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: aarch64-unknown-linux-gnu

Created attachment 57142
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57142&action=edit
reduced testcase (from c-c++-common/torture/harden-cfr-bret-except.c)

Compiler output:
$ aarch64-unknown-linux-gnu-gcc -mgeneral-regs-only testcase.c
testcase.c: In function 'foo':
testcase.c:5:1: error: unrecognizable insn:
    5 | }
      | ^
(insn 25 24 26 2 (set (reg:TI 32 v0)
        (mem:TI (reg/f:DI 111) [0  S16 A64])) "testcase.c":4:3 -1
     (nil))
during RTL pass: vregs
testcase.c:5:1: internal compiler error: in extract_insn, at recog.cc:2812
0x86009f _fatal_insn(char const*, rtx_def const*, char const*, int, char
const*)
        /repo/gcc-trunk/gcc/rtl-error.cc:108
0x86011c _fatal_insn_not_found(rtx_def const*, char const*, int, char const*)
        /repo/gcc-trunk/gcc/rtl-error.cc:116
0x85113d extract_insn(rtx_insn*)
        /repo/gcc-trunk/gcc/recog.cc:2812
0xf5e8f1 instantiate_virtual_regs_in_insn
        /repo/gcc-trunk/gcc/function.cc:1611
0xf5e8f1 instantiate_virtual_regs
        /repo/gcc-trunk/gcc/function.cc:1994
0xf5e8f1 execute
        /repo/gcc-trunk/gcc/function.cc:2041
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ aarch64-unknown-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-aarch64/bin/aarch64-unknown-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r14-8193-20240117105849-g3340878009a-checking-yes-rtl-df-extra-aarch64/bin/../libexec/gcc/aarch64-unknown-linux-gnu/14.0.1/lto-wrapper
Target: aarch64-unknown-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl
--with-sysroot=/usr/aarch64-unknown-linux-gnu --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --target=aarch64-unknown-linux-gnu
--with-ld=/usr/bin/aarch64-unknown-linux-gnu-ld
--with-as=/usr/bin/aarch64-unknown-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r14-8193-20240117105849-g3340878009a-checking-yes-rtl-df-extra-aarch64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.1 20240117 (experimental) (GCC)

[Bug target/113486] ICE: in extract_insn, at recog.cc:2812 (unrecognizable insn) with -mgeneral-regs-only and __builtin_apply() on aarch64

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113486

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2024-01-18
      Known to fail|                            |5.4.0
     Ever confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.

[Bug target/113486] ICE: in extract_insn, at recog.cc:2812 (unrecognizable insn) with -mgeneral-regs-only and __builtin_apply() on aarch64

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113486

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I have a fix

[Bug target/113486] ICE: in extract_insn, at recog.cc:2812 (unrecognizable insn) with -mgeneral-regs-only and __builtin_apply() on aarch64

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113486

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2024-January
                   |                            |/643394.html

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Patch posted:
https://gcc.gnu.org/pipermail/gcc-patches/2024-January/643394.html

[Bug target/113486] ICE: in extract_insn, at recog.cc:2812 (unrecognizable insn) with -mgeneral-regs-only and __builtin_apply() on aarch64

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113486

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:d3ff08a3764f2047d02b35212fc4f1da9eb75c7b

commit r14-8397-gd3ff08a3764f2047d02b35212fc4f1da9eb75c7b
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Thu Jan 18 10:40:04 2024 -0800

    aarch64: Fix __builtin_apply with -mgeneral-regs-only [PR113486]

    The problem here is the builtin apply mechanism thinks the FP registers
    are to be used due to get_raw_arg_mode not returning VOIDmode. This
    fixes that oversight and the backend now returns VOIDmode for
non-general-regs
    if TARGET_GENERAL_REGS_ONLY is true.

    Built and tested for aarch64-linux-gnu with no regressions.

            PR target/113486

    gcc/ChangeLog:

            * config/aarch64/aarch64.cc (aarch64_get_reg_raw_mode): For
            TARGET_GENERAL_REGS_ONLY, return VOIDmode for non-GP_REGNUM_P
regno.

    gcc/testsuite/ChangeLog:

            * gcc.target/aarch64/builtin_apply-1.c: New test.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>

[Bug target/113486] ICE: in extract_insn, at recog.cc:2812 (unrecognizable insn) with -mgeneral-regs-only and __builtin_apply() on aarch64

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113486

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |14.0

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed, not a regression so not backporting it; also not many people use
__builtin_apply nor use -mgeneral-regs-only especially together too.