public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
From: "vmakarov at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org>
To: gcc-bugs@gcc.gnu.org
Subject: [Bug target/113510] [14 Regression] [ARM Thumb] ICE in extract_constrain_insn with CPU cortex-m23
Date: Tue, 23 Jan 2024 20:44:07 +0000	[thread overview]
Message-ID: <bug-113510-4-dUy4EzPufO@http.gcc.gnu.org/bugzilla/> (raw)
In-Reply-To: <bug-113510-4@http.gcc.gnu.org/bugzilla/>

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113510

Vladimir Makarov <vmakarov at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vmakarov at gcc dot gnu.org

--- Comment #4 from Vladimir Makarov <vmakarov at gcc dot gnu.org> ---
This is not a RA bug.  I believe it is a bug in peephole optimization.

Right after LRA and before peephole2 we have:

(insn 28 13 15 2 (set (reg:SI 12 ip [127])
        (const_int 8 [0x8]))
"../../gcc/gcc/testsuite/gcc.c-torture/compile/nested-3.c":17:10 959
{*thumb1_movsi_insn}
     (nil))
(insn 15 28 16 2 (set (reg:SI 12 ip [127])
        (plus:SI (reg:SI 12 ip [127])
            (reg/f:SI 13 sp)))
"../../gcc/gcc/testsuite/gcc.c-torture/compile/nested-3.c":17:10 935
{*thumb1_addsi3}
     (nil))

and peephole2 combines these two insns into

(insn 39 13 16 2 (set (reg:SI 12 ip [127])
        (plus:SI (reg/f:SI 13 sp)
            (const_int 8 [0x8])))
"../../gcc/gcc/testsuite/gcc.c-torture/compile/nested-3.c":17:10 -1
     (nil))

which is wrong as output and the 1st operand of *thumb1_addsi3 should be a low
register but r12 is not a low register.  If peephole2 took this into account,
it would have not combined the 2 insns and we would have not this PR.

  parent reply	other threads:[~2024-01-23 20:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-19 22:56 [Bug rtl-optimization/113510] New: " thiago.bauermann at linaro dot org
2024-01-19 22:58 ` [Bug rtl-optimization/113510] " thiago.bauermann at linaro dot org
2024-01-19 23:00 ` thiago.bauermann at linaro dot org
2024-01-20  8:24 ` [Bug target/113510] [14 Regression ARM " pinskia at gcc dot gnu.org
2024-01-23 20:44 ` vmakarov at gcc dot gnu.org [this message]
2024-01-24  0:53 ` [Bug target/113510] [14 Regression] [ARM " pinskia at gcc dot gnu.org
2024-01-24 13:00 ` rearnsha at gcc dot gnu.org
2024-03-05 17:31 ` rearnsha at gcc dot gnu.org
2024-03-05 17:35 ` cvs-commit at gcc dot gnu.org
2024-03-05 17:37 ` rearnsha at gcc dot gnu.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-113510-4-dUy4EzPufO@http.gcc.gnu.org/bugzilla/ \
    --to=gcc-bugzilla@gcc.gnu.org \
    --cc=gcc-bugs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).