[Bug tree-optimization/113518] New: ICE: in gimplify_expr, at gimplify.cc:18596 with atomic_fetch_or_explicit() on _BitInt()

[Bug tree-optimization/113518] New: ICE: in gimplify_expr, at gimplify.cc:18596 with atomic_fetch_or_explicit() on _BitInt()

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113518

            Bug ID: 113518
           Summary: ICE: in gimplify_expr, at gimplify.cc:18596 with
                    atomic_fetch_or_explicit() on _BitInt()
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
                CC: jakub at gcc dot gnu.org
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 57170
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57170&action=edit
reduced testcase (from gcc.target/i386/pr102566-2.c)

Compiler output:
$ x86_64-pc-linux-gnu-gcc testcase.c
In file included from testcase.c:1:
testcase.c: In function 'foo':
testcase.c:8:34: internal compiler error: in gimplify_expr, at
gimplify.cc:18596
    8 |   atomic_fetch_or_explicit(&v, 1 << 31, memory_order_relaxed);
      |                                  ^
0x78cb81 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
        /repo/gcc-trunk/gcc/gimplify.cc:18596
0x11a66a6 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
        /repo/gcc-trunk/gcc/gimplify.cc:18085
0x11a62ef gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
        /repo/gcc-trunk/gcc/gimplify.cc:18568
0x11bcae5 gimplify_modify_expr
        /repo/gcc-trunk/gcc/gimplify.cc:6405
0x11a6489 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
        /repo/gcc-trunk/gcc/gimplify.cc:17780
0x11b4b29 gimplify_target_expr
        /repo/gcc-trunk/gcc/gimplify.cc:7399
0x11a66e0 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
        /repo/gcc-trunk/gcc/gimplify.cc:18177
0x11a8b76 gimplify_stmt(tree_node**, gimple**)
        /repo/gcc-trunk/gcc/gimplify.cc:7480
0x11a74e0 gimplify_statement_list
        /repo/gcc-trunk/gcc/gimplify.cc:2222
0x11a74e0 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
        /repo/gcc-trunk/gcc/gimplify.cc:18225
0x11b4ced gimplify_target_expr
        /repo/gcc-trunk/gcc/gimplify.cc:7393
0x11a66e0 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
        /repo/gcc-trunk/gcc/gimplify.cc:18177
0x11a8b76 gimplify_stmt(tree_node**, gimple**)
        /repo/gcc-trunk/gcc/gimplify.cc:7480
0x11a9c79 gimplify_bind_expr
        /repo/gcc-trunk/gcc/gimplify.cc:1614
0x11a71f7 gimplify_expr(tree_node**, gimple**, gimple**, bool (*)(tree_node*),
int)
        /repo/gcc-trunk/gcc/gimplify.cc:17981
0x11bde24 gimplify_stmt(tree_node**, gimple**)
        /repo/gcc-trunk/gcc/gimplify.cc:7480
0x11bde24 gimplify_body(tree_node*, bool)
        /repo/gcc-trunk/gcc/gimplify.cc:19047
0x11be24a gimplify_function_tree(tree_node*)
        /repo/gcc-trunk/gcc/gimplify.cc:19246
0xfcd037 cgraph_node::analyze()
        /repo/gcc-trunk/gcc/cgraphunit.cc:685
0xfcf957 analyze_functions
        /repo/gcc-trunk/gcc/cgraphunit.cc:1248
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r14-8284-20240119180625-g54519030b05-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/14.0.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r14-8284-20240119180625-g54519030b05-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.1 20240119 (experimental) (GCC)

[Bug c/113518] ICE: in gimplify_expr, at gimplify.cc:18596 with atomic_fetch_or_explicit() on _BitInt()

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113518

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
          Component|tree-optimization           |c
   Last reconfirmed|                            |2024-01-20
             Status|UNCONFIRMED                 |NEW

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.

There is a leaking c_maybe_const_expr from the front-end to the gimplifier.

[Bug c/113518] ICE: in gimplify_expr, at gimplify.cc:18596 with atomic_fetch_or_explicit() on _BitInt()

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113518

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |jakub at gcc dot gnu.org

--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 57183
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57183&action=edit
gcc14-pr113518.patch

Untested fix.

[Bug c/113518] ICE: in gimplify_expr, at gimplify.cc:18596 with atomic_fetch_or_explicit() on _BitInt()

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113518

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:

https://gcc.gnu.org/g:dbc5f1f523b3cfa539d72fdd60b9479b3cd5a45d

commit r14-8373-gdbc5f1f523b3cfa539d72fdd60b9479b3cd5a45d
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Tue Jan 23 19:59:00 2024 +0100

    c: Call c_fully_fold on __atomic_* operands in
atomic_bitint_fetch_using_cas_loop [PR113518]

    As the following testcase shows, I forgot to call c_fully_fold on the
    __atomic_*/__sync_* operands called on _BitInt address, the expressions
    are then used inside of TARGET_EXPR initializers etc. and are never fully
    folded later, which means we can ICE e.g. on C_MAYBE_CONST_EXPR trees
    inside of those.

    The following patch fixes it, while the function currently is only called
    in the C FE because C++ doesn't support BITINT_TYPE, I think guarding the
    calls on !c_dialect_cxx () is safer.

    2024-01-23  Jakub Jelinek  <jakub@redhat.com>

            PR c/113518
            * c-common.cc (atomic_bitint_fetch_using_cas_loop): Call
c_fully_fold
            on lhs_addr, val and model for C.

            * gcc.dg/bitint-77.c: New test.

[Bug c/113518] ICE: in gimplify_expr, at gimplify.cc:18596 with atomic_fetch_or_explicit() on _BitInt()

[jakub at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113518

Jakub Jelinek <jakub at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.