[Bug tree-optimization/113548] New: ICE vect-ifcvt-19 in build2, at tree.cc:5097

[Bug tree-optimization/113548] New: ICE vect-ifcvt-19 in build2, at tree.cc:5097

[nightstrike at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113548

            Bug ID: 113548
           Summary: ICE vect-ifcvt-19 in build2, at tree.cc:5097
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: nightstrike at gmail dot com
  Target Milestone: ---

Created attachment 57186
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57186&action=edit
Preprocessed source from -freport-bug

ICE during testsuite run for vect-ifcvt-19.  Many similarly titled bugs, I
think the current title of this one is equally unhelpful, so feel free to
change this PR title to something better.

Running linux 64 to windows 64 cross compiler, fails on 11, 12, 13, 14.  I
didn't test prior versions.

Backtrace:

0x8bb855 build2(tree_code, tree_node*, tree_node*, tree_node*)
        ../../gcc/tree.cc:5097
0xa4dd1f build2_loc(unsigned int, tree_code, tree_node*, tree_node*,
tree_node*)
        ../../gcc/tree.h:4750
0xa4dd1f c_parser_gimple_binary_expression
        ../../gcc/c/gimple-parser.cc:1068
0xa4ec71 c_parser_gimple_statement
        ../../gcc/c/gimple-parser.cc:878
0xa4f95a c_parser_gimple_compound_statement
        ../../gcc/c/gimple-parser.cc:669
0xa51a58 c_parser_parse_gimple_body(c_parser*, char*, c_declspec_il,
profile_count)
        ../../gcc/c/gimple-parser.cc:253
0xa3d3f4 c_parser_declaration_or_fndef
        ../../gcc/c/c-parser.cc:3011
0xa4764b c_parser_external_declaration
        ../../gcc/c/c-parser.cc:2046
0xa48035 c_parser_translation_unit
        ../../gcc/c/c-parser.cc:1900
0xa48035 c_parse_file()
        ../../gcc/c/c-parser.cc:26815
0xabf271 c_common_parse_file()
        ../../gcc/c-family/c-opts.cc:1301

[Bug testsuite/113548] gcc.dg/vect/vect-ifcvt-19.c ICEs on LLP64 target

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113548

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|tree-optimization           |testsuite
           Keywords|                            |testsuite-fail
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=108954
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
            Summary|ICE vect-ifcvt-19 in        |gcc.dg/vect/vect-ifcvt-19.c
                   |build2, at tree.cc:5097     |ICEs on LLP64 target
             Target|x86_64-w64-mingw32          |*-*-mingw
   Last reconfirmed|                            |2024-01-22

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note this is just the bug for the testcase issue rather than the ICE, the ICE
is PR 108954 .

We should change  the type of _2 and _1  to __SIZE_TYPE__ from `unsigned long`
as size_type on mingw (and some other targets) is NOT the same size as
`unsigned long`.

[Bug testsuite/113548] gcc.dg/vect/vect-ifcvt-19.c ICEs on LLP64 target

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113548

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |pinskia at gcc dot gnu.org

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I will fix this testcase today or tomorrow.  It should not be hard.

[Bug testsuite/113548] gcc.dg/vect/vect-ifcvt-19.c ICEs on LLP64 target

[nightstrike at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113548

--- Comment #3 from nightstrike <nightstrike at gmail dot com> ---
Seeing as how this is a testsuite issue, it seems that the crash in the same
location applies to the following:

FAIL: gcc.dg/vect/vect-ifcvt-19.c (internal compiler error: in build2, at
tree.cc:5097)
FAIL: gcc.dg/vect/slp-reduc-10a.c (internal compiler error: in build2, at
tree.cc:5097)
FAIL: gcc.dg/vect/slp-reduc-10b.c (internal compiler error: in build2, at
tree.cc:5097)
FAIL: gcc.dg/vect/slp-reduc-10c.c (internal compiler error: in build2, at
tree.cc:5097)
FAIL: gcc.dg/vect/slp-reduc-10d.c (internal compiler error: in build2, at
tree.cc:5097)
FAIL: gcc.dg/vect/slp-reduc-10e.c (internal compiler error: in build2, at
tree.cc:5097)
FAIL: gcc.dg/vect/vect-ifcvt-19.c -flto -ffat-lto-objects (internal compiler
error: in build2, at tree.cc:5097)
FAIL: gcc.dg/vect/vect-cond-arith-2.c -flto -ffat-lto-objects (internal
compiler error: in build2, at tree.cc:5097)
FAIL: gcc.dg/vect/vect-cond-arith-2.c (internal compiler error: in build2, at
tree.cc:5097)
FAIL: gcc.dg/vect/slp-reduc-10b.c -flto -ffat-lto-objects (internal compiler
error: in build2, at tree.cc:5097)
FAIL: gcc.dg/vect/slp-reduc-10c.c -flto -ffat-lto-objects (internal compiler
error: in build2, at tree.cc:5097)
FAIL: gcc.dg/vect/slp-reduc-10d.c -flto -ffat-lto-objects (internal compiler
error: in build2, at tree.cc:5097)
FAIL: gcc.dg/vect/slp-reduc-10e.c -flto -ffat-lto-objects (internal compiler
error: in build2, at tree.cc:5097)

[Bug testsuite/113548] gcc.dg/vect/vect-ifcvt-19.c ICEs on LLP64 target

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113548

--- Comment #4 from Richard Biener <rguenth at gcc dot gnu.org> ---
Note for 'sizetype' you want to use '__SIZETYPE__', not '__SIZE_TYPE__'

[Bug testsuite/113548] gcc.dg/vect/vect-ifcvt-19.c ICEs on LLP64 target

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113548

--- Comment #5 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
(In reply to nightstrike from comment #3)
> Seeing as how this is a testsuite issue, it seems that the crash in the same
> location applies to the following:
> FAIL: gcc.dg/vect/slp-reduc-10a.c (internal compiler error: in build2, at
> tree.cc:5097)
> FAIL: gcc.dg/vect/slp-reduc-10b.c (internal compiler error: in build2, at
> tree.cc:5097)
> FAIL: gcc.dg/vect/slp-reduc-10c.c (internal compiler error: in build2, at
> tree.cc:5097)
> FAIL: gcc.dg/vect/slp-reduc-10d.c (internal compiler error: in build2, at
> tree.cc:5097)
> FAIL: gcc.dg/vect/slp-reduc-10e.c (internal compiler error: in build2, at
> tree.cc:5097)

What is interesting is these testcases already use __SIZETYPE__ in some places
but not all. Like someone tried to fix them up when they committed them but not
all the way.

[Bug testsuite/113548] gcc.dg/vect/vect-ifcvt-19.c ICEs on LLP64 target

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113548

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2024-January
                   |                            |/643894.html

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Patch posted:
https://gcc.gnu.org/pipermail/gcc-patches/2024-January/643894.html

[Bug testsuite/113548] gcc.dg/vect/vect-ifcvt-19.c ICEs on LLP64 target

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113548

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Andrew Pinski <pinskia@gcc.gnu.org>:

https://gcc.gnu.org/g:e7d7c9e889ae8553b9aac79e6944d70702f8ee53

commit r14-8417-ge7d7c9e889ae8553b9aac79e6944d70702f8ee53
Author: Andrew Pinski <quic_apinski@quicinc.com>
Date:   Wed Jan 24 10:28:37 2024 -0800

    Fix a few vect gimple testcases for LLP64 targets (e.g. mingw) [PR113548]

    This fixes of the vect testcases which uses the gimple FE for LLP64
targets.
    The testcases use directly `unsigned long` for the addition to pointers
    when they should be using `__SIZETYPE__`. This changes to use that instead.

    gcc/testsuite/ChangeLog:

            PR testsuite/113548
            * gcc.dg/vect/slp-reduc-10a.c: Use `__SIZETYPE__` instead of
`unsigned long`.
            * gcc.dg/vect/slp-reduc-10b.c: Likewise.
            * gcc.dg/vect/slp-reduc-10c.c: Likewise.
            * gcc.dg/vect/slp-reduc-10d.c: Likewise.
            * gcc.dg/vect/slp-reduc-10e.c: Likewise.
            * gcc.dg/vect/vect-cond-arith-2.c: Likewise.
            * gcc.dg/vect/vect-ifcvt-19.c: Likewise.

    Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>

[Bug testsuite/113548] gcc.dg/vect/vect-ifcvt-19.c ICEs on LLP64 target

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113548

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Fixed.