[Bug modula2/113559] New: gm2/isolib/run/pass/seqappend.mod FAILs

[Bug modula2/113559] New: gm2/isolib/run/pass/seqappend.mod FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113559

            Bug ID: 113559
           Summary: gm2/isolib/run/pass/seqappend.mod FAILs
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
  Target Milestone: ---
            Target: i386-pc-solaris2.11, sparc-sun-solaris2.11,
                    s390x-ibm-linux-gnu, m68k-unknown-linux-gnu

Since 20230515, the gm2/isolib/run/pass/seqappend.mod test FAILs on 32-bit
Solaris/SPARC and x86:

FAIL: gm2/isolib/run/pass/seqappend.mod execution,  -O 
FAIL: gm2/isolib/run/pass/seqappend.mod execution,  -O -g 
FAIL: gm2/isolib/run/pass/seqappend.mod execution,  -O3 -fomit-frame-pointer 
FAIL: gm2/isolib/run/pass/seqappend.mod execution,  -O3 -fomit-frame-pointer
-finline-functions 
FAIL: gm2/isolib/run/pass/seqappend.mod execution,  -Os 
FAIL: gm2/isolib/run/pass/seqappend.mod execution,  -g 

There are also reports for Linux/s390x and Linux/m68k.

The failure is like

short read occurred: 10...
append test failed

[Bug modula2/113559] gm2/isolib/run/pass/seqappend.mod FAILs

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113559

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug modula2/113559] gm2/isolib/run/pass/seqappend.mod FAILs

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113559

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-01-24
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Thanks for the bug report - indeed verified the bug and have a fix.

[Bug modula2/113559] gm2/isolib/run/pass/seqappend.mod FAILs

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113559

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 57204
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57204&action=edit
Proposed fix

Here is the proposed patch - it passes the regression test on x86_32 and
x86_64.  The full bootstrap tests on both platforms is in progress.

[Bug modula2/113559] gm2/isolib/run/pass/seqappend.mod FAILs

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113559

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57204|0                           |1
        is obsolete|                            |

--- Comment #3 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 57205
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57205&action=edit
Proposed fix v2

Correction the cast should be the signed sizetype CSSIZE_T.

[Bug modula2/113559] gm2/isolib/run/pass/seqappend.mod FAILs

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113559

--- Comment #4 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #3 from Gaius Mulley <gaius at gcc dot gnu.org> ---
> Created attachment 57205
>   --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57205&action=edit
> Proposed fix v2
>
> Correction the cast should be the signed sizetype CSSIZE_T.

I've just successfully tested this version on both i386-pc-solaris2.11
and sparc-sun-solaris2.11.  Thanks.

[Bug modula2/113559] gm2/isolib/run/pass/seqappend.mod FAILs

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113559

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:3de031c96f28f19a68ea2080260d8fd2c78828ee

commit r14-8389-g3de031c96f28f19a68ea2080260d8fd2c78828ee
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Wed Jan 24 13:11:46 2024 +0000

    PR modula2/113559 FIO.mod lseek requires cssize_t rather than longint

    This patch fixes a bug in gcc/m2/gm2-libs/FIO.mod which failed to cast the
    whence parameter into the correct type.  The patch casts the whence
    parameter for lseek to SYSTEM.CSSIZE_T.

    gcc/m2/ChangeLog:

            PR modula2/113559
            * gm2-libs/FIO.mod (SetPositionFromBeginning): Convert pos into
            CSSIZE_T during call to lseek.
            (SetPositionFromEnd): Convert pos into CSSIZE_T during call to
            lseek.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/113559] gm2/isolib/run/pass/seqappend.mod FAILs

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113559

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Thanks for the bug report and testing the bugfix!