[Bug c++/113612] New: ICE: SIGSEGV in get_template_info (pt.cc:378) or tree_check (tree.h:3611) with invalid -fpreprocessed

[Bug c++/113612] New: ICE: SIGSEGV in get_template_info (pt.cc:378) or tree_check (tree.h:3611) with invalid -fpreprocessed

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113612

            Bug ID: 113612
           Summary: ICE: SIGSEGV in get_template_info (pt.cc:378) or
                    tree_check (tree.h:3611) with invalid -fpreprocessed
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: ice-on-invalid-code
          Severity: normal
          Priority: P3
         Component: c++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 57219
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57219&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc testcase.C -c
$ x86_64-pc-linux-gnu-gcc -fpreprocessed testcase.C -wrapper valgrind,-q
testcase.C:1:1: error: stray '#' in program
    1 | #if defined0
      | ^
testcase.C:6:1: error: stray '#' in program
    6 | #endif
      | ^
testcase.C:1:2: error: expected unqualified-id before 'if'
    1 | #if defined0
      |  ^~
==1836== Invalid read of size 2
==1836==    at 0x10B82AE: get_template_info(tree_node const*) (pt.cc:378)
==1836==    by 0x10D80F7: get_partial_spec_bindings(tree_node*, tree_node*,
tree_node*) (pt.cc:25875)
==1836==    by 0x10D890D: most_specialized_partial_spec(tree_node*, int, bool)
(pt.cc:26190)
==1836==    by 0x10D975F: instantiate_template(tree_node*, tree_node*, int)
(pt.cc:22074)
==1836==    by 0x113558A: finish_id_expression_1(tree_node*, tree_node*,
tree_node*, cp_id_kind*, bool, bool, bool*, bool, bool, bool, bool, char
const**, unsigned int) (semantics.cc:4392)
==1836==    by 0x1135F66: finish_id_expression(tree_node*, tree_node*,
tree_node*, cp_id_kind*, bool, bool, bool*, bool, bool, bool, bool, char
const**, unsigned int) (semantics.cc:4573)
==1836==    by 0x107D2DA: cp_parser_primary_expression(cp_parser*, bool, bool,
bool, bool, cp_id_kind*) (parser.cc:6300)
==1836==    by 0x108A225: cp_parser_postfix_expression(cp_parser*, bool, bool,
bool, bool, cp_id_kind*) (parser.cc:7924)
==1836==    by 0x106805C: cp_parser_binary_expression(cp_parser*, bool, bool,
bool, cp_parser_prec, cp_id_kind*) (parser.cc:10383)
==1836==    by 0x1068D62: cp_parser_assignment_expression(cp_parser*,
cp_id_kind*, bool, bool) (parser.cc:10727)
==1836==    by 0x1069E85: cp_parser_constant_expression(cp_parser*, int, bool*,
bool) (parser.cc:11017)
==1836==    by 0x106AE16: cp_parser_initializer_clause(cp_parser*, bool*)
(parser.cc:26126)
==1836==  Address 0x53dce10 is in a rw- anonymous segment
==1836== 
==1836== Invalid read of size 2
==1836==    at 0x10D80F8: tree_check (tree.h:3611)
==1836==    by 0x10D80F8: get_partial_spec_bindings(tree_node*, tree_node*,
tree_node*) (pt.cc:25875)
==1836==    by 0x10D890D: most_specialized_partial_spec(tree_node*, int, bool)
(pt.cc:26190)
==1836==    by 0x10D975F: instantiate_template(tree_node*, tree_node*, int)
(pt.cc:22074)
==1836==    by 0x113558A: finish_id_expression_1(tree_node*, tree_node*,
tree_node*, cp_id_kind*, bool, bool, bool*, bool, bool, bool, bool, char
const**, unsigned int) (semantics.cc:4392)
==1836==    by 0x1135F66: finish_id_expression(tree_node*, tree_node*,
tree_node*, cp_id_kind*, bool, bool, bool*, bool, bool, bool, bool, char
const**, unsigned int) (semantics.cc:4573)
==1836==    by 0x107D2DA: cp_parser_primary_expression(cp_parser*, bool, bool,
bool, bool, cp_id_kind*) (parser.cc:6300)
==1836==    by 0x108A225: cp_parser_postfix_expression(cp_parser*, bool, bool,
bool, bool, cp_id_kind*) (parser.cc:7924)
==1836==    by 0x106805C: cp_parser_binary_expression(cp_parser*, bool, bool,
bool, cp_parser_prec, cp_id_kind*) (parser.cc:10383)
==1836==    by 0x1068D62: cp_parser_assignment_expression(cp_parser*,
cp_id_kind*, bool, bool) (parser.cc:10727)
==1836==    by 0x1069E85: cp_parser_constant_expression(cp_parser*, int, bool*,
bool) (parser.cc:11017)
==1836==    by 0x106AE16: cp_parser_initializer_clause(cp_parser*, bool*)
(parser.cc:26126)
==1836==    by 0x106FA94: cp_parser_initializer(cp_parser*, bool*, bool*, bool)
(parser.cc:26065)
==1836==  Address 0x0 is not stack'd, malloc'd or (recently) free'd
==1836== 
testcase.C:5:35: internal compiler error: Segmentation fault
    5 | template <typename T> T *t<T *> = t<int>
      |                                   ^~~~~~
0x18044bf crash_signal
        /repo/gcc-trunk/gcc/toplev.cc:317
0x10d80f8 tree_check(tree_node*, char const*, int, char const*, tree_code)
        /repo/gcc-trunk/gcc/tree.h:3611
0x10d80f8 get_partial_spec_bindings
        /repo/gcc-trunk/gcc/cp/pt.cc:25875
0x10d890d most_specialized_partial_spec(tree_node*, int, bool)
        /repo/gcc-trunk/gcc/cp/pt.cc:26190
...

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r14-8419-20240125172014-gc6c2a1d79eb-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/14.0.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r14-8419-20240125172014-gc6c2a1d79eb-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.1 20240125 (experimental) (GCC)

[Bug c++/113612] [13/14 Regression] ICE: SIGSEGV in get_template_info (pt.cc:378) or tree_check (tree.h:3611) with invalid -fpreprocessed

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113612

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |error-recovery
   Target Milestone|---                         |13.3
            Summary|ICE: SIGSEGV in             |[13/14 Regression] ICE:
                   |get_template_info           |SIGSEGV in
                   |(pt.cc:378) or tree_check   |get_template_info
                   |(tree.h:3611) with invalid  |(pt.cc:378) or tree_check
                   |-fpreprocessed              |(tree.h:3611) with invalid
                   |                            |-fpreprocessed
      Known to work|                            |13.2.0

[Bug c++/113612] [13/14 Regression] ICE: SIGSEGV in get_template_info (pt.cc:378) or tree_check (tree.h:3611) with invalid -fpreprocessed

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113612

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-bisection
   Last reconfirmed|                            |2024-01-26
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.

[Bug c++/113612] [13/14 Regression] ICE: SIGSEGV in get_template_info (pt.cc:378) or tree_check (tree.h:3611) with invalid -fpreprocessed

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113612

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P4

[Bug c++/113612] [13/14 Regression] ICE: SIGSEGV in get_template_info (pt.cc:378) or tree_check (tree.h:3611) with invalid -fpreprocessed

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113612

Marek Polacek <mpolacek at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P4                          |P2
                 CC|                            |mpolacek at gcc dot gnu.org,
                   |                            |ppalka at gcc dot gnu.org
           Keywords|error-recovery,             |ice-on-valid-code
                   |ice-on-invalid-code,        |
                   |needs-bisection             |

--- Comment #2 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
clang++ compiles this, and so did we:

template <typename T> T t;
template <typename T> extern T *t<T *>;
template <typename T> T *t<T *> = t<int>;

Started with r13-6380:

commit d3d205ab440886164b6de2be2a2efa10cac95b66
Author: Patrick Palka <ppalka@redhat.com>
Date:   Tue Feb 28 15:05:30 2023 -0500

    c++: non-dependent variable template-id [PR108848]

[Bug c++/113612] [13/14 Regression] ICE: SIGSEGV in get_template_info (pt.cc:378) or tree_check (tree.h:3611)

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113612

--- Comment #3 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
(gdb) up
#1  0x0000000001120e27 in get_partial_spec_bindings (tmpl=<template_decl
0x7ffff7fc2080 t>, 
    spec_tmpl=<template_decl 0x7ffff7fc2180 t>, args=<tree_vec 0x7fffea3a7d20>)
    at /home/mpolacek/src/gcc/gcc/cp/pt.cc:25888
25888       = TI_ARGS (get_template_info (DECL_TEMPLATE_RESULT (spec_tmpl)));
(gdb) p spec_tmpl
$1 = <template_decl 0x7ffff7fc2180 t>
(gdb) p DECL_TEMPLATE_RESULT (spec_tmpl)
$2 = <ggc_freed 0x7fffea210e10>

[Bug c++/113612] [13/14 Regression] ICE: SIGSEGV in get_template_info (pt.cc:378) or tree_check (tree.h:3611)

[mpolacek at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113612

--- Comment #4 from Marek Polacek <mpolacek at gcc dot gnu.org> ---
It was freed here in duplicate_decls:

#1  0x00000000012f535d in ggc_free (p=0x7fffea210e10) at
/home/mpolacek/src/gcc/gcc/ggc-page.cc:1630
#2  0x0000000000e971b2 in duplicate_decls (newdecl=<ggc_freed 0x7fffea210e10>, 
    olddecl=<var_decl 0x7fffea210d80 t>, hiding=false, was_hidden=false)
    at /home/mpolacek/src/gcc/gcc/cp/decl.cc:3334
#3  0x00000000010a4bca in register_specialization (spec=<ggc_freed
0x7fffea210e10>, 
    tmpl=<template_decl 0x7ffff7fc2080 t>, args=<tree_vec 0x7fffea3a7ca0>,
is_friend=false, hash=2199381591)
    at /home/mpolacek/src/gcc/gcc/cp/pt.cc:1627
#4  0x00000000010b46e8 in process_partial_specialization (decl=<ggc_freed
0x7fffea210e10>)
    at /home/mpolacek/src/gcc/gcc/cp/pt.cc:5422
#5  0x00000000010b9420 in push_template_decl (decl=<ggc_freed 0x7fffea210e10>,
is_friend=false)
    at /home/mpolacek/src/gcc/gcc/cp/pt.cc:6005
#6  0x0000000000ea198b in start_decl (declarator=0x48c4eb0,
declspecs=0x7fffffffd080, initialized=1, 
    attributes=<tree 0x0>, prefix_attributes=<tree 0x0>,
pushed_scope_p=0x7fffffffcf40)
    at /home/mpolacek/src/gcc/gcc/cp/decl.cc:6108

[Bug c++/113612] [13/14 Regression] ICE: SIGSEGV in get_template_info (pt.cc:378) or tree_check (tree.h:3611)

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113612

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org
             Status|NEW                         |ASSIGNED
                 CC|                            |jason at gcc dot gnu.org

[Bug c++/113612] [13/14 Regression] ICE: SIGSEGV in get_template_info (pt.cc:378) or tree_check (tree.h:3611)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113612

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:19ac327de421fe05916e234e3450e6e1cc5c935c

commit r14-8960-g19ac327de421fe05916e234e3450e6e1cc5c935c
Author: Jason Merrill <jason@redhat.com>
Date:   Mon Feb 12 21:00:53 2024 -0500

    c++: variable partial spec redeclaration [PR113612]

    If register_specialization finds a previous declaration and throws the new
    one away, we shouldn't still add the new one to
    DECL_TEMPLATE_SPECIALIZATIONS.

            PR c++/113612

    gcc/cp/ChangeLog:

            * pt.cc (process_partial_specialization): Return early
            on redeclaration.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp1y/var-templ85.C: New test.

[Bug c++/113612] [13/14 Regression] ICE: SIGSEGV in get_template_info (pt.cc:378) or tree_check (tree.h:3611)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113612

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Jason Merrill
<jason@gcc.gnu.org>:

https://gcc.gnu.org/g:ef7738d2d0ee0103946e5243aa7e5c8ad2fb0c6d

commit r13-8324-gef7738d2d0ee0103946e5243aa7e5c8ad2fb0c6d
Author: Jason Merrill <jason@redhat.com>
Date:   Mon Feb 12 21:00:53 2024 -0500

    c++: variable partial spec redeclaration [PR113612]

    If register_specialization finds a previous declaration and throws the new
    one away, we shouldn't still add the new one to
    DECL_TEMPLATE_SPECIALIZATIONS.

            PR c++/113612

    gcc/cp/ChangeLog:

            * pt.cc (process_partial_specialization): Return early
            on redeclaration.

    gcc/testsuite/ChangeLog:

            * g++.dg/cpp1y/var-templ85.C: New test.

    (cherry picked from commit 19ac327de421fe05916e234e3450e6e1cc5c935c)

[Bug c++/113612] [13/14 Regression] ICE: SIGSEGV in get_template_info (pt.cc:378) or tree_check (tree.h:3611)

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113612

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #7 from Jason Merrill <jason at gcc dot gnu.org> ---
Fixed for 13.3/14.