[Bug tree-optimization/113670] New: ICE with vectors in named registers and -fno-vect-cost-model

[Bug tree-optimization/113670] New: ICE with vectors in named registers and -fno-vect-cost-model

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113670

            Bug ID: 113670
           Summary: ICE with vectors in named registers and
                    -fno-vect-cost-model
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: xry111 at gcc dot gnu.org
  Target Milestone: ---

$ cat t.c
typedef float __attribute__ ((vector_size (16))) vec;
typedef int __attribute__ ((vector_size (16))) ivec;
register vec a asm("xmm0"), b asm("xmm1");
register ivec c asm("xmm2");

void
test (void)
{
  for (int i = 0; i < 4; i++)
    c[i] = a[i] < b[i] ? -1 : 1;
}
$ gcc/cc1 -msse2 t.c -O2 -fno-vect-cost-model -nostdinc -ffixed-xmm{0,1,2}
t.c: In function 'test':
t.c:7:1: internal compiler error: in expand_expr_addr_expr_1, at expr.cc:9139
    7 | test (void)
      | ^~~~
0x10e6d6e expand_expr_addr_expr_1
        ../../gcc/gcc/expr.cc:9139
0x10e76e2 expand_expr_addr_expr
        ../../gcc/gcc/expr.cc:9252
0x10f73a7 expand_expr_real_1(tree_node*, rtx_def*, machine_mode,
expand_modifier, rtx_def**, bool)
        ../../gcc/gcc/expr.cc:12585
0x10e7dc8 expand_expr_real(tree_node*, rtx_def*, machine_mode, expand_modifier,
rtx_def**, bool)
        ../../gcc/gcc/expr.cc:9440
0xef7346 expand_expr(tree_node*, rtx_def*, machine_mode, expand_modifier)
        ../../gcc/gcc/expr.h:316
0x10e91fa expand_expr_real_2(separate_ops*, rtx_def*, machine_mode,
expand_modifier)
        ../../gcc/gcc/expr.cc:9762
0x10ef77d expand_expr_real_gassign(gassign*, rtx_def*, machine_mode,
expand_modifier, rtx_def**, bool)
        ../../gcc/gcc/expr.cc:11096
0xf2db31 expand_gimple_stmt_1
        ../../gcc/gcc/cfgexpand.cc:4010
0xf2ddd4 expand_gimple_stmt
        ../../gcc/gcc/cfgexpand.cc:4071
0xf36844 expand_gimple_basic_block
        ../../gcc/gcc/cfgexpand.cc:6127
0xf38ff8 execute
        ../../gcc/gcc/cfgexpand.cc:6866

[Bug tree-optimization/113670] ICE with vectors in named registers and -fno-vect-cost-model

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113670

Xi Ruoyao <xry111 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|13.2.0                      |

--- Comment #1 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
It's difficult to say when this started because in previous releases another
ICE (PR113622) happens anyway.

[Bug tree-optimization/113670] ICE with vectors in named registers and -fno-vect-cost-model

[xry111 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113670

--- Comment #2 from Xi Ruoyao <xry111 at gcc dot gnu.org> ---
Quoting the observation from Richard:

> We end up with the invalid
> 
> _28 = (sizetype) &a;

[Bug tree-optimization/113670] ICE with vectors in named registers and -fno-vect-cost-model

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113670

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2024-01-31
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
I'll hunt it down.

[Bug tree-optimization/113670] ICE with vectors in named registers and -fno-vect-cost-model

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113670

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:924137b9012cee5603482242de08fbf0b2030f6a

commit r14-8645-g924137b9012cee5603482242de08fbf0b2030f6a
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Jan 31 09:09:50 2024 +0100

    tree-optimization/113670 - gather/scatter to/from hard registers

    The following makes sure we're not taking the address of hard
    registers when vectorizing appearant gathers or scatters to/from
    them.

            PR tree-optimization/113670
            * tree-vect-data-refs.cc (vect_check_gather_scatter):
            Make sure we can take the address of the reference base.

            * gcc.target/i386/pr113670.c: New testcase.

[Bug tree-optimization/113670] ICE with vectors in named registers and -fno-vect-cost-model

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113670

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to fail|14.0                        |
   Target Milestone|---                         |14.0
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
      Known to work|                            |14.0

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed for trunk.

[Bug tree-optimization/113670] ICE with vectors in named registers and -fno-vect-cost-model

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113670

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:ac664905b837095b15099e44e83471672eee7aa9

commit r13-8484-gac664905b837095b15099e44e83471672eee7aa9
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Jan 31 09:09:50 2024 +0100

    tree-optimization/113670 - gather/scatter to/from hard registers

    The following makes sure we're not taking the address of hard
    registers when vectorizing appearant gathers or scatters to/from
    them.

            PR tree-optimization/113670
            * tree-vect-data-refs.cc (vect_check_gather_scatter):
            Make sure we can take the address of the reference base.

            * gcc.target/i386/pr113670.c: New testcase.

    (cherry picked from commit 924137b9012cee5603482242de08fbf0b2030f6a)