[Bug tree-optimization/113706] New: c-c++-common/pr103798-2.c FAILs as C++

[Bug tree-optimization/113706] New: c-c++-common/pr103798-2.c FAILs as C++

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

            Bug ID: 113706
           Summary: c-c++-common/pr103798-2.c FAILs as C++
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: ro at gcc dot gnu.org
                CC: hjl.tools at gmail dot com
  Target Milestone: ---
            Target: i386-pc-solaris2.11, amd64-pc-solaris2.11,
                    sparc*-sun-solaris2.11, pru-unknown-elf

The c-c++-common/pr103798-2.c test FAILs when compiled as C++ on Solaris/SPARC
and x86, 32 and 64-bit:

FAIL: c-c++-common/pr103798-2.c  -std=gnu++14  scan-assembler-not memchr
FAIL: c-c++-common/pr103798-2.c  -std=gnu++17  scan-assembler-not memchr
FAIL: c-c++-common/pr103798-2.c  -std=gnu++20  scan-assembler-not memchr
FAIL: c-c++-common/pr103798-2.c  -std=gnu++98  scan-assembler-not memchr

Similar failures are seen on gcc-testresults posting for PRU.

[Bug tree-optimization/113706] c-c++-common/pr103798-2.c FAILs as C++

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

--- Comment #1 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 57282
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57282&action=edit
32- bit i386-pc-solaris2.11 preprocessed input

[Bug tree-optimization/113706] c-c++-common/pr103798-2.c FAILs as C++

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

--- Comment #2 from Rainer Orth <ro at gcc dot gnu.org> ---
Created attachment 57283
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57283&action=edit
32- bit i386-pc-solaris2.11 assembler output

[Bug tree-optimization/113706] c-c++-common/pr103798-2.c FAILs as C++

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0

[Bug tree-optimization/113706] c-c++-common/pr103798-2.c FAILs as C++

[hjl.tools at gmail dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

--- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
On Solaris, when compiling this

#include <string.h>

__attribute__ ((weak))
int
f (int a)
{
   return memchr ("aE", a, 2) != NULL;
}

as C++ source, std::memchr is used and GCC doesn't treat std::memchr as
BUILT_IN_MEMCHR.

[Bug tree-optimization/113706] c-c++-common/pr103798-2.c FAILs as C++

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

--- Comment #4 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #3 from H.J. Lu <hjl.tools at gmail dot com> ---
> On Solaris, when compiling this
>
> #include <string.h>
>
> __attribute__ ((weak))
> int
> f (int a)
> {
>    return memchr ("aE", a, 2) != NULL;
> }
>
> as C++ source, std::memchr is used and GCC doesn't treat std::memchr as
> BUILT_IN_MEMCHR.

I see.  I'm testing a patch to directly define/declare NULL, size_t and
memchr instead of including <string.h>.  This should still test what the
testcase is supposed to test, I believe.

[Bug tree-optimization/113706] c-c++-common/pr103798-2.c FAILs as C++

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-02-02
                URL|                            |https://gcc.gnu.org/piperma
                   |                            |il/gcc-patches/2024-Februar
                   |                            |y/644842.html
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #5 from Rainer Orth <ro at gcc dot gnu.org> ---
Patch posted.

[Bug tree-optimization/113706] c-c++-common/pr103798-2.c FAILs as C++

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

Rainer Orth <ro at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|https://gcc.gnu.org/piperma |https://gcc.gnu.org/piperma
                   |il/gcc-patches/2024-Februar |il/gcc-patches/2024-Februar
                   |y/644842.html               |y/645459.html

--- Comment #6 from Rainer Orth <ro at gcc dot gnu.org> ---
Jason's analysis in review of initial patch:

https://gcc.gnu.org/pipermail/gcc-patches/2024-February/645437.html

Revised patch posted.

[Bug c++/113706] c-c++-common/pr103798-2.c FAILs as C++

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|tree-optimization           |c++
                 CC|                            |jason at gcc dot gnu.org

--- Comment #7 from Jason Merrill <jason at gcc dot gnu.org> ---
I think this is a front-end issue.

[Bug c++/113706] c-c++-common/pr103798-2.c FAILs as C++

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Rainer Orth <ro@gcc.gnu.org>:

https://gcc.gnu.org/g:ab0c2c367a87b03f38a486a118b89335837619dc

commit r14-8971-gab0c2c367a87b03f38a486a118b89335837619dc
Author: Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
Date:   Wed Feb 14 09:25:03 2024 +0100

    testsuite: xfail c-c++-common/pr103798-2.c for C++ on Solaris [PR113706]

    c-c++-common/pr103798-2.c FAILs on Solaris when compiled as C++:

    FAIL: c-c++-common/pr103798-2.c  -std=gnu++14  scan-assembler-not memchr
    FAIL: c-c++-common/pr103798-2.c  -std=gnu++17  scan-assembler-not memchr
    FAIL: c-c++-common/pr103798-2.c  -std=gnu++20  scan-assembler-not memchr
    FAIL: c-c++-common/pr103798-2.c  -std=gnu++98  scan-assembler-not memchr

    As Jason analyzed, Solaris <string.h> declares memchr for C++ as returning
    const void * as specified by the C++ standard, while gcc expects the return
    type to be void * like in C.

    So this patch xfails the test for C++ on Solaris.

    Tested on sparc-sun-solaris2.11 and x86_64-pc-linux-gnu.

    2024-02-12  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

            gcc/testsuite:
            PR c++/113706
            * c-c++-common/pr103798-2.c (scan-assembler-not): xfail for C++ on
            Solaris.

[Bug c++/113706] c-c++-common/pr103798-2.c FAILs as C++

[ro at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

--- Comment #9 from Rainer Orth <ro at gcc dot gnu.org> ---
xfailed for GCC 14.0.1.

Keep PR open for the underlying bug.

[Bug c++/113706] c-c++-common/pr103798-2.c FAILs as C++

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
   Target Milestone|14.0                        |15.0
           Assignee|unassigned at gcc dot gnu.org      |jason at gcc dot gnu.org

[Bug c++/113706] c-c++-common/pr103798-2.c FAILs as C++

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

--- Comment #10 from Jason Merrill <jason at gcc dot gnu.org> ---
Created attachment 57423
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57423&action=edit
patch for GCC 15

Here's a fix, but since this isn't a regression it can wait for stage 1.

[Bug c++/113706] c-c++-common/pr103798-2.c FAILs as C++

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

--- Comment #11 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Alexandre Oliva <aoliva@gcc.gnu.org>:

https://gcc.gnu.org/g:cc02ebfcfd0755b330c50a840ab713fedd6d8887

commit r14-10023-gcc02ebfcfd0755b330c50a840ab713fedd6d8887
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Thu Apr 18 08:01:26 2024 -0300

    [testsuite] xfail pr103798-2 in C++ on vxworks too [PR113706]

    pr103798-2.c fails in C++ on targets that provide a ISO C++-compliant
    declaration of memchr, because it mismatches the C-compatible builtin,
    as per PR113706.  Expect the C++ test to fail on vxworks as well.


    for  gcc/testsuite/ChangeLog

            PR testsuite/113706
            * c-c++-common/pr103798-2.c: XFAIL in C++ on vxworks too.

[Bug c++/113706] c-c++-common/pr103798-2.c FAILs as C++

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

--- Comment #12 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The trunk branch has been updated by Jason Merrill <jason@gcc.gnu.org>:

https://gcc.gnu.org/g:c3bc2787b8beb7aae67fdf2a7f7271a9a4edca7c

commit r15-91-gc3bc2787b8beb7aae67fdf2a7f7271a9a4edca7c
Author: Jason Merrill <jason@redhat.com>
Date:   Mon Feb 12 18:24:00 2024 -0500

    c++: const void* memchr [PR113706]

    The C++ standard specifies that the <string.h> functions have const and
    non-const overloads, unlike C's single function with const argument and
    non-const return.  Many systems don't actually implement this, but only add
    an overload with non-const argument, so both end up having non-const
return.
    Solaris <string.h> does what the standard says, but we were penalizing it
by
    not recognizing the const overload as the built-in memchr.

            PR c++/113706

    gcc/cp/ChangeLog:

            * decl.cc (decls_match): Handle memchr return type being
            const-qualified.

    gcc/testsuite/ChangeLog:

            * g++.dg/opt/const-builtin1.C: New test.
            * c-c++-common/pr103798-2.c: Remove xfail.

[Bug c++/113706] c-c++-common/pr103798-2.c FAILs as C++

[jason at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

Jason Merrill <jason at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #13 from Jason Merrill <jason at gcc dot gnu.org> ---
Should be fixed now.

[Bug c++/113706] c-c++-common/pr103798-2.c FAILs as C++

[ro at CeBiTec dot Uni-Bielefeld.DE]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113706

--- Comment #14 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot Uni-Bielefeld.DE> ---
> --- Comment #13 from Jason Merrill <jason at gcc dot gnu.org> ---
> Should be fixed now.

It is indeed.  Thanks a lot.