[Bug target/114034] New: Failure of tests gcov-dump-{1,2}.C

[Bug target/114034] New: Failure of tests gcov-dump-{1,2}.C

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114034

            Bug ID: 114034
           Summary: Failure of tests gcov-dump-{1,2}.C
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: fxcoudert at gcc dot gnu.org
  Target Milestone: ---

We have the following failures on x86_64-apple-darwin23:

FAIL: g++.dg/gcov/gcov-dump-1.C  -std=gnu++98 (test for excess errors)
FAIL: g++.dg/gcov/gcov-dump-1.C  -std=gnu++14 (test for excess errors)
FAIL: g++.dg/gcov/gcov-dump-1.C  -std=gnu++17 (test for excess errors)
FAIL: g++.dg/gcov/gcov-dump-1.C  -std=gnu++20 (test for excess errors)
FAIL: g++.dg/gcov/gcov-dump-2.C  -std=gnu++98 (test for excess errors)
FAIL: g++.dg/gcov/gcov-dump-2.C  -std=gnu++14 (test for excess errors)
FAIL: g++.dg/gcov/gcov-dump-2.C  -std=gnu++17 (test for excess errors)
FAIL: g++.dg/gcov/gcov-dump-2.C  -std=gnu++20 (test for excess errors)

Excess errors:
ld: warning: ignoring duplicate libraries: '-lgcov'

The compilation line only includes one -lgcov:

/Users/fx/ibin-20240219/gcc/testsuite/g++1/../../xg++
-B/Users/fx/ibin-20240219/gcc/testsuite/g++1/../../ 
/Users/fx/gcc-upstream/gcc/testsuite/g++.dg/gcov/gcov-dump-1.C   
-fdiagnostics-plain-output  -nostdinc++
-I/Users/fx/ibin-20240219/x86_64-apple-darwin23/libstdc++-v3/include/x86_64-apple-darwin23
-I/Users/fx/ibin-20240219/x86_64-apple-darwin23/libstdc++-v3/include
-I/Users/fx/gcc-upstream/libstdc++-v3/libsupc++
-I/Users/fx/gcc-upstream/libstdc++-v3/include/backward
-I/Users/fx/gcc-upstream/libstdc++-v3/testsuite/util -fmessage-length=0 
-std=gnu++98 -fprofile-generate -ftest-coverage -lgcov   
-L/Users/fx/ibin-20240219/x86_64-apple-darwin23/./libstdc++-v3/src/.libs 
-B/Users/fx/ibin-20240219/x86_64-apple-darwin23/./libstdc++-v3/src/.libs 
-L/Users/fx/ibin-20240219/x86_64-apple-darwin23/./libstdc++-v3/src/.libs 
-L/Users/fx/ibin-20240219/x86_64-apple-darwin23/./libstdc++-v3/src/experimental/.libs
-B/Users/fx/ibin-20240219/x86_64-apple-darwin23/./libitm/
-L/Users/fx/ibin-20240219/x86_64-apple-darwin23/./libitm/.libs -lm  -o
./gcov-dump-1.exe

but the driver somehow includes another one when calling collect2:

/Users/fx/ibin-20240219/gcc/testsuite/g++1/../../collect2 -demangle -syslibroot
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/ -dynamic -arch x86_64
-platform_version macos 14.0.0 0.0 -o ./gcov-dump-1.exe
-L/Users/fx/ibin-20240219/x86_64-apple-darwin23/./libstdc++-v3/src/.libs
-L/Users/fx/ibin-20240219/x86_64-apple-darwin23/./libstdc++-v3/src/.libs
-L/Users/fx/ibin-20240219/x86_64-apple-darwin23/./libstdc++-v3/src/experimental/.libs
-L/Users/fx/ibin-20240219/x86_64-apple-darwin23/./libitm/.libs
-L/Users/fx/ibin-20240219/gcc/testsuite/g++1/../..
-L/Users/fx/ibin-20240219/x86_64-apple-darwin23/./libstdc++-v3/src/.libs
-L/Users/fx/ibin-20240219/x86_64-apple-darwin23/./libitm -lemutls_w -lheapt_w
/var/folders/_8/7ft0tbns6_l87s21n4s_1sc80000gn/T//ccyOpfRM.o -lgcov -lstdc++
-lgcov -lgcc_s.1.1 -lgcc -lSystem -no_compact_unwind -rpath @loader_path -rpath
/Users/fx/ibin-20240219/gcc -rpath
/Users/fx/ibin-20240219/x86_64-apple-darwin23/libstdc++-v3/src/.libs -rpath
/Users/fx/ibin-20240219/x86_64-apple-darwin23/libitm


I'm wondering if it's a good idea to simply ignore the warning in the two test
cases. It's not such a frequent use case, and darwin linker to being a pain
here.

[Bug target/114034] Failure of tests gcov-dump-{1,2}.C

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114034

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
             Target|                            |x86_64-apple-darwin23
   Last reconfirmed|                            |2024-02-21
                 CC|                            |iains at gcc dot gnu.org
     Ever confirmed|0                           |1

[Bug target/114034] Failure of tests gcov-dump-{1,2}.C

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114034

--- Comment #1 from Iain Sandoe <iains at gcc dot gnu.org> ---
let me see if we're adding an extra in the Darwin specs that is covered
elsewhere (sometimes the specs get changed in gcc/gcc.cc and it takes us some
time to sync the ones in darwin.h)

[Bug testsuite/114034] Failure of tests gcov-dump-{1,2}.C

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114034

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testsuite-fail
          Component|target                      |testsuite

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I think we should remove `-lgcov` from the dg-options here since
-fgenerate-profile (and -ftest-coverage) will add it anyways. That is why you
are getting 2 on the command line of ld/collect2.

[Bug testsuite/114034] Failure of tests gcov-dump-{1,2}.C

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114034

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:

https://gcc.gnu.org/g:799a056cf804f433ce0050a5a6bf900f7a01ecb1

commit r14-9748-g799a056cf804f433ce0050a5a6bf900f7a01ecb1
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Sun Mar 31 11:22:58 2024 +0100

    testsuite: Remove duplicate -lgcov [PR114034]

    Duplicate library entries now cause linker warnings with newer linker
    versions on Darwin which leads to these tests regressing.  The library
    is already added by the test flags so there is no need to put an extra
    one in the options.

            PR testsuite/114034

    gcc/testsuite/ChangeLog:

            * g++.dg/gcov/gcov-dump-1.C: Remove extra -lgcov.
            * g++.dg/gcov/gcov-dump-2.C: Likewise.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

[Bug testsuite/114034] Failure of tests gcov-dump-{1,2}.C

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114034

--- Comment #4 from Iain Sandoe <iains at gcc dot gnu.org> ---
fixed on trunk, needed on open branches.

[Bug testsuite/114034] Failure of tests gcov-dump-{1,2}.C

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114034

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:a040eea6b65456625443dcfbf6b21913f2003c8b

commit r13-8589-ga040eea6b65456625443dcfbf6b21913f2003c8b
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Sun Mar 31 11:22:58 2024 +0100

    testsuite: Remove duplicate -lgcov [PR114034]

    Duplicate library entries now cause linker warnings with newer linker
    versions on Darwin which leads to these tests regressing.  The library
    is already added by the test flags so there is no need to put an extra
    one in the options.

            PR testsuite/114034

    gcc/testsuite/ChangeLog:

            * g++.dg/gcov/gcov-dump-1.C: Remove extra -lgcov.
            * g++.dg/gcov/gcov-dump-2.C: Likewise.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
    (cherry picked from commit 799a056cf804f433ce0050a5a6bf900f7a01ecb1)

[Bug testsuite/114034] Failure of tests gcov-dump-{1,2}.C

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114034

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:6a4824a8bc86fcbcb8f51bab4c24d72ffd00715e

commit r12-10385-g6a4824a8bc86fcbcb8f51bab4c24d72ffd00715e
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Sun Mar 31 11:22:58 2024 +0100

    testsuite: Remove duplicate -lgcov [PR114034]

    Duplicate library entries now cause linker warnings with newer linker
    versions on Darwin which leads to these tests regressing.  The library
    is already added by the test flags so there is no need to put an extra
    one in the options.

            PR testsuite/114034

    gcc/testsuite/ChangeLog:

            * g++.dg/gcov/gcov-dump-1.C: Remove extra -lgcov.
            * g++.dg/gcov/gcov-dump-2.C: Likewise.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
    (cherry picked from commit 799a056cf804f433ce0050a5a6bf900f7a01ecb1)

[Bug testsuite/114034] Failure of tests gcov-dump-{1,2}.C

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114034

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:241e10972c916540a085054a1a858c5b2ce82a5a

commit r11-11406-g241e10972c916540a085054a1a858c5b2ce82a5a
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Sun Mar 31 11:22:58 2024 +0100

    testsuite: Remove duplicate -lgcov [PR114034]

    Duplicate library entries now cause linker warnings with newer linker
    versions on Darwin which leads to these tests regressing.  The library
    is already added by the test flags so there is no need to put an extra
    one in the options.

            PR testsuite/114034

    gcc/testsuite/ChangeLog:

            * g++.dg/gcov/gcov-dump-1.C: Remove extra -lgcov.
            * g++.dg/gcov/gcov-dump-2.C: Likewise.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
    (cherry picked from commit 799a056cf804f433ce0050a5a6bf900f7a01ecb1)

[Bug testsuite/114034] Failure of tests gcov-dump-{1,2}.C

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114034

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #8 from Iain Sandoe <iains at gcc dot gnu.org> ---
fixed on open branches