[Bug target/114036] New: Test failure of gcov-14.c on darwin

[Bug target/114036] New: Test failure of gcov-14.c on darwin

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114036

            Bug ID: 114036
           Summary: Test failure of gcov-14.c on darwin
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: fxcoudert at gcc dot gnu.org
  Target Milestone: ---

FAIL: gcc.misc-tests/gcov-14.c (test for excess errors)
Excess errors:
ld: warning: -undefined suppress is deprecated

The test has specific option for darwin:

/* The following line arranges that Darwin has behavior like elf weak import. 
*/
/* { dg-additional-options "-flat_namespace -undefined suppress" { target
*-*-darwin* }  } */


Maybe on modern systems we should simply remove that? The test appears to be
passing anyway :)

[Bug target/114036] Test failure of gcov-14.c on darwin

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114036

Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
             Target|                            |x86_64-apple-darwin23
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2024-02-21

[Bug target/114036] Test failure of gcov-14.c on darwin

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114036

--- Comment #1 from Iain Sandoe <iains at gcc dot gnu.org> ---
yeah, there is a better way to do this with ld64 (and presumably dyld-ld), my
guess is that this is an anachronism from the ld_classic (v1) days.

We can tell the linker it's OK for a symbol to be undefined - and then that
makes it behave like the ELF case.

"-Wl,-U,_symbol_name " is the incantation to do this - and AFAIK should work
back to i686-darwin9 (which is the earliest I test these days).

[Bug target/114036] Test failure of gcov-14.c on darwin

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114036

--- Comment #2 from Iain Sandoe <iains at gcc dot gnu.org> ---
if there are lots of symbols that need to be undefined  .. then one can use an
undefined symbols file.  

Of course, it does not work if we do not know the symbol names at build-time.

[Bug target/114036] Test failure of gcov-14.c on darwin

[fxcoudert at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114036

--- Comment #3 from Francois-Xavier Coudert <fxcoudert at gcc dot gnu.org> ---
There's only one symbol we care about here, and its name is known, so I'll make
a patch with your suggestion and test it.

[Bug target/114036] Test failure of gcov-14.c on darwin

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114036

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Iain D Sandoe <iains@gcc.gnu.org>:

https://gcc.gnu.org/g:ad8e34eaa870608e2b07b4e7147e6ef2944bb8b5

commit r14-9747-gad8e34eaa870608e2b07b4e7147e6ef2944bb8b5
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Sun Mar 31 11:27:53 2024 +0100

    testsuite, Darwin: Allow for an undefined symbol [PR114036].

    Darwin's linker defaults to requiring all symbols to be defined at
    static link time (unless specifically noted or dynamic lookuo is
    enabled).

    For this test, we just need to note that the symbol is expected to
    be undefined.

            PR testsuite/114036

    gcc/testsuite/ChangeLog:

            * gcc.misc-tests/gcov-14.c: Allow for 'Foo' to be undefined
            on Darwin link lines.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>

[Bug target/114036] Test failure of gcov-14.c on darwin

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114036

--- Comment #5 from Iain Sandoe <iains at gcc dot gnu.org> ---
fixed on trunk, needed on open branches.

[Bug target/114036] Test failure of gcov-14.c on darwin

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114036

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:02a1d49da8f95a128d131747546921b67818d144

commit r13-8586-g02a1d49da8f95a128d131747546921b67818d144
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Sun Mar 31 11:27:53 2024 +0100

    testsuite, Darwin: Allow for an undefined symbol [PR114036].

    Darwin's linker defaults to requiring all symbols to be defined at
    static link time (unless specifically noted or dynamic lookuo is
    enabled).

    For this test, we just need to note that the symbol is expected to
    be undefined.

            PR testsuite/114036

    gcc/testsuite/ChangeLog:

            * gcc.misc-tests/gcov-14.c: Allow for 'Foo' to be undefined
            on Darwin link lines.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
    (cherry picked from commit ad8e34eaa870608e2b07b4e7147e6ef2944bb8b5)

[Bug target/114036] Test failure of gcov-14.c on darwin

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114036

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:ed046c2cc0f0a2d00cc77e5e9ce5d8f71e2278c6

commit r12-10379-ged046c2cc0f0a2d00cc77e5e9ce5d8f71e2278c6
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Sun Mar 31 11:27:53 2024 +0100

    testsuite, Darwin: Allow for an undefined symbol [PR114036].

    Darwin's linker defaults to requiring all symbols to be defined at
    static link time (unless specifically noted or dynamic lookuo is
    enabled).

    For this test, we just need to note that the symbol is expected to
    be undefined.

            PR testsuite/114036

    gcc/testsuite/ChangeLog:

            * gcc.misc-tests/gcov-14.c: Allow for 'Foo' to be undefined
            on Darwin link lines.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
    (cherry picked from commit ad8e34eaa870608e2b07b4e7147e6ef2944bb8b5)

[Bug target/114036] Test failure of gcov-14.c on darwin

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114036

--- Comment #8 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-11 branch has been updated by Iain D Sandoe
<iains@gcc.gnu.org>:

https://gcc.gnu.org/g:5feeb2ddc93de85dffd7d52119189cd63bccd40f

commit r11-11405-g5feeb2ddc93de85dffd7d52119189cd63bccd40f
Author: Iain Sandoe <iain@sandoe.co.uk>
Date:   Sun Mar 31 11:27:53 2024 +0100

    testsuite, Darwin: Allow for an undefined symbol [PR114036].

    Darwin's linker defaults to requiring all symbols to be defined at
    static link time (unless specifically noted or dynamic lookuo is
    enabled).

    For this test, we just need to note that the symbol is expected to
    be undefined.

            PR testsuite/114036

    gcc/testsuite/ChangeLog:

            * gcc.misc-tests/gcov-14.c: Allow for 'Foo' to be undefined
            on Darwin link lines.

    Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
    (cherry picked from commit ad8e34eaa870608e2b07b4e7147e6ef2944bb8b5)

[Bug target/114036] Test failure of gcov-14.c on darwin

[iains at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114036

Iain Sandoe <iains at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #9 from Iain Sandoe <iains at gcc dot gnu.org> ---
fixed on open branches