public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug tree-optimization/114093] New: Canonicalization of `a == -1 || a == 0`
@ 2024-02-24 21:21 pinskia at gcc dot gnu.org
  0 siblings, 0 replies; only message in thread
From: pinskia at gcc dot gnu.org @ 2024-02-24 21:21 UTC (permalink / raw)
  To: gcc-bugs

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114093

            Bug ID: 114093
           Summary: Canonicalization of `a == -1 || a == 0`
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: missed-optimization
          Severity: enhancement
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: pinskia at gcc dot gnu.org
  Target Milestone: ---

Take:
```
_Bool f1(int a)
{
        return a == -1 || a == 0;
}

_Bool f0(signed a)
{
        a = -a;
        return a == 1 || a == 0;
}


_Bool f(unsigned a)
{
        return a == -1u || a == 0;
}

_Bool f3(unsigned a)
{
        a = -a;
        return a == 1 || a == 0;
}


_Bool f2(unsigned a)
{
        return (-a) <= 1;
}
```

These all should produce the exact same code as they are all equivalent (if we
ignore the (undefined) overflow possibility for f0).

This is more about canonicalizations rather than anything else.

Though I will note on the riscv and mips targets, f is worse than the others.

LLVM canonical form seems to be `((unsigned)a) + 1 <= 1`.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-02-24 21:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-24 21:21 [Bug tree-optimization/114093] New: Canonicalization of `a == -1 || a == 0` pinskia at gcc dot gnu.org

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).