public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c/114112] New: Error message is translatable but inserts untranslated substring
@ 2024-02-26 12:38 goeran at uddeborg dot se
2024-02-26 17:15 ` [Bug c/114112] " pinskia at gcc dot gnu.org
2024-05-11 11:56 ` goeran at uddeborg dot se
0 siblings, 2 replies; 3+ messages in thread
From: goeran at uddeborg dot se @ 2024-02-26 12:38 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114112
Bug ID: 114112
Summary: Error message is translatable but inserts untranslated
substring
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: c
Assignee: unassigned at gcc dot gnu.org
Reporter: goeran at uddeborg dot se
Target Milestone: ---
At
https://gcc.gnu.org/git?p=gcc.git;a=blob;f=gcc/c-family/c-omp.cc;h=5117022e330c95592d7731eec161ab1b5c6925d9;hb=HEAD#l1810
the function check_loop_binding_expr emits an error message where it inserts a
"context". This "context" comes from the call and is sent as a string not
available for translation. Even if those inserted strings were marked for
translation, it is in general a bad idea to compose a message from smaller
strings in that way if they are to be correctly translated.
(See
https://www.gnu.org/software/gettext/manual/html_node/Preparing-Strings.html if
one wants a further discussion around this.)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug c/114112] Error message is translatable but inserts untranslated substring
2024-02-26 12:38 [Bug c/114112] New: Error message is translatable but inserts untranslated substring goeran at uddeborg dot se
@ 2024-02-26 17:15 ` pinskia at gcc dot gnu.org
2024-05-11 11:56 ` goeran at uddeborg dot se
1 sibling, 0 replies; 3+ messages in thread
From: pinskia at gcc dot gnu.org @ 2024-02-26 17:15 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114112
Andrew Pinski <pinskia at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |NEW
Last reconfirmed| |2024-02-26
Ever confirmed|0 |1
--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed.
An enum should be used instead and then N_( should be used around it.
Like what is done for format_specifier_kind in c-family/c-format.cc:
```
/* Enum describing the kind of specifiers present in the format and
requiring an argument. */
enum format_specifier_kind {
CF_KIND_FORMAT,
CF_KIND_FIELD_WIDTH,
CF_KIND_FIELD_PRECISION
};
static const char *kind_descriptions[] = {
N_("format"),
N_("field width specifier"),
N_("field precision specifier")
};
```
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug c/114112] Error message is translatable but inserts untranslated substring
2024-02-26 12:38 [Bug c/114112] New: Error message is translatable but inserts untranslated substring goeran at uddeborg dot se
2024-02-26 17:15 ` [Bug c/114112] " pinskia at gcc dot gnu.org
@ 2024-05-11 11:56 ` goeran at uddeborg dot se
1 sibling, 0 replies; 3+ messages in thread
From: goeran at uddeborg dot se @ 2024-05-11 11:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114112
Göran Uddeborg <goeran at uddeborg dot se> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED
--- Comment #2 from Göran Uddeborg <goeran at uddeborg dot se> ---
This is fixed in the 14.1.0 version of the message catalog now available for
translation. Thank you!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-11 11:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-26 12:38 [Bug c/114112] New: Error message is translatable but inserts untranslated substring goeran at uddeborg dot se
2024-02-26 17:15 ` [Bug c/114112] " pinskia at gcc dot gnu.org
2024-05-11 11:56 ` goeran at uddeborg dot se
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).