public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "redi at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/114244] Need to use round when parsing fractional seconds Date: Thu, 07 Mar 2024 00:30:52 +0000 [thread overview] Message-ID: <bug-114244-4-0SM5klFRTJ@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-114244-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114244 --- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> --- Yup, the seconds part "00.002" is parsed using std::numpunct (in order to handle the locale's decimal point) and then converted to milliseconds using duration_cast: auto& __ng = use_facet<num_get<_CharT>>(__loc); long double __val; ios_base::iostate __err2{}; __ng.get(__buf, {}, __buf, __err2, __val); if (__is_failed(__err2)) [[unlikely]] __err |= __err2; else { duration<long double> __fs(__val); __s = duration_cast<_Duration>(__fs); } We also use duration_cast when parsing %c and %X using std::time_get, but that's an integer conversion there (but the duration_cast should have been qualified to prevent ADL): __h = hours(__tm.tm_hour); __min = minutes(__tm.tm_min); __s = duration_cast<_Duration>(seconds(__tm.tm_sec)); and another duration_cast in chrono::from_stream for durations. That one could be used with either integral or floating-point reps. Do we want to parse "00:00:31" as minutes(1)? I don't think we do, so only the first case where converting long double to milliseconds should be rounded?
next prev parent reply other threads:[~2024-03-07 0:30 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-05 17:23 [Bug libstdc++/114244] New: " howard.hinnant at gmail dot com 2024-03-05 20:49 ` [Bug libstdc++/114244] " redi at gcc dot gnu.org 2024-03-07 0:30 ` redi at gcc dot gnu.org [this message] 2024-03-07 0:32 ` redi at gcc dot gnu.org 2024-03-07 0:37 ` redi at gcc dot gnu.org 2024-03-07 1:01 ` howard.hinnant at gmail dot com 2024-03-07 1:21 ` redi at gcc dot gnu.org 2024-03-07 23:45 ` cvs-commit at gcc dot gnu.org 2024-03-07 23:46 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114244-4-0SM5klFRTJ@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).