public inbox for gcc-bugs@sourceware.org help / color / mirror / Atom feed
From: "cvs-commit at gcc dot gnu.org" <gcc-bugzilla@gcc.gnu.org> To: gcc-bugs@gcc.gnu.org Subject: [Bug libstdc++/114244] Need to use round when parsing fractional seconds Date: Thu, 07 Mar 2024 23:45:08 +0000 [thread overview] Message-ID: <bug-114244-4-9uLOcUkq2H@http.gcc.gnu.org/bugzilla/> (raw) In-Reply-To: <bug-114244-4@http.gcc.gnu.org/bugzilla/> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114244 --- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>: https://gcc.gnu.org/g:5f9d7a5b6cf64639274e63051caf70fbc8418ea2 commit r14-9376-g5f9d7a5b6cf64639274e63051caf70fbc8418ea2 Author: Jonathan Wakely <jwakely@redhat.com> Date: Thu Mar 7 13:15:41 2024 +0000 libstdc++: Fix parsing of fractional seconds [PR114244] When converting a chrono::duration<long double> to a result type with an integer representation we should use chrono::round<_Duration> so that we don't truncate towards zero. Rounding ensures that e.g. 0.001999s becomes 2ms not 1ms. We can also remove some redundant uses of chrono::duration_cast to convert from seconds to _Duration, because the _Parser class template requires _Duration type to be able to represent seconds without loss of precision. This also fixes a bug where no fractional part would be parsed for chrono::duration<long double> because its period is ratio<1>. We should also consider treat_as_floating_point<rep> when deciding whether to skip reading a fractional part. libstdc++-v3/ChangeLog: PR libstdc++/114244 * include/bits/chrono_io.h (_Parser::operator()): Remove redundant uses of duration_cast. Use chrono::round to convert long double value to durations with integer representations. Check represenation type when deciding whether to skip parsing fractional seconds. * testsuite/20_util/duration/114244.cc: New test. * testsuite/20_util/duration/io.cc: Check that a floating-point duration with ratio<1> precision can be parsed.
next prev parent reply other threads:[~2024-03-07 23:45 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-05 17:23 [Bug libstdc++/114244] New: " howard.hinnant at gmail dot com 2024-03-05 20:49 ` [Bug libstdc++/114244] " redi at gcc dot gnu.org 2024-03-07 0:30 ` redi at gcc dot gnu.org 2024-03-07 0:32 ` redi at gcc dot gnu.org 2024-03-07 0:37 ` redi at gcc dot gnu.org 2024-03-07 1:01 ` howard.hinnant at gmail dot com 2024-03-07 1:21 ` redi at gcc dot gnu.org 2024-03-07 23:45 ` cvs-commit at gcc dot gnu.org [this message] 2024-03-07 23:46 ` redi at gcc dot gnu.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=bug-114244-4-9uLOcUkq2H@http.gcc.gnu.org/bugzilla/ \ --to=gcc-bugzilla@gcc.gnu.org \ --cc=gcc-bugs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).