[Bug tree-optimization/114246] New: [11/12/13/14 Regression] ICE: verify_gimple failed: invalid argument to gimple call with __builtin_memcpy()

[Bug tree-optimization/114246] New: [11/12/13/14 Regression] ICE: verify_gimple failed: invalid argument to gimple call with __builtin_memcpy()

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114246

            Bug ID: 114246
           Summary: [11/12/13/14 Regression] ICE: verify_gimple failed:
                    invalid argument to gimple call with
                    __builtin_memcpy()
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: x86_64-pc-linux-gnu

Created attachment 57618
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57618&action=edit
reduced testcase

Compiler output:
$ x86_64-pc-linux-gnu-gcc -O testcase.c 
testcase.c: In function 'foo':
testcase.c:8:1: error: invalid argument to gimple call
    8 | }
      | ^
(char *) &b
# .MEM_3 = VDEF <.MEM_2(D)>
__builtin_memcpy (&MEM <char> [(void *)&a + 1B], (char *) &b, 1);
during GIMPLE pass: dse
testcase.c:8:1: internal compiler error: verify_gimple failed
0x155f0bd verify_gimple_in_cfg(function*, bool, bool)
        /repo/gcc-trunk/gcc/tree-cfg.cc:5663
0x13cde04 execute_function_todo
        /repo/gcc-trunk/gcc/passes.cc:2088
0x13ce35e execute_todo
        /repo/gcc-trunk/gcc/passes.cc:2142
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ x86_64-pc-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-amd64/bin/x86_64-pc-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r14-9323-20240305175124-g8776468d9e5-checking-yes-rtl-df-extra-nobootstrap-amd64/bin/../libexec/gcc/x86_64-pc-linux-gnu/14.0.1/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--disable-bootstrap --with-cloog --with-ppl --with-isl
--build=x86_64-pc-linux-gnu --host=x86_64-pc-linux-gnu
--target=x86_64-pc-linux-gnu --with-ld=/usr/bin/x86_64-pc-linux-gnu-ld
--with-as=/usr/bin/x86_64-pc-linux-gnu-as --enable-libsanitizer
--disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r14-9323-20240305175124-g8776468d9e5-checking-yes-rtl-df-extra-nobootstrap-amd64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.1 20240305 (experimental) (GCC)

[Bug tree-optimization/114246] [11/12/13/14 Regression] ICE: verify_gimple failed: invalid argument to gimple call with __builtin_memcpy()

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114246

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |11.5
                 CC|                            |pinskia at gcc dot gnu.org

[Bug tree-optimization/114246] [11/12/13/14 Regression] ICE: verify_gimple failed: invalid argument to gimple call with __builtin_memcpy()

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114246

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
   Last reconfirmed|                            |2024-03-06
     Ever confirmed|0                           |1

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Confirmed. we start out with:
```
  __builtin_memcpy (&a, &MEM <int> [(void *)&b + -1B], 2);
  _4 = MEM[(char * {ref-all})&b];
  MEM[(char * {ref-all})&a] = _4;
```

And DSE converts it into:
```
  __builtin_memcpy (&MEM <char> [(void *)&a + 1B], (char *) &b, 1);
  _4 = MEM[(char * {ref-all})&b];
  MEM[(char * {ref-all})&a] = _4;
```

[Bug tree-optimization/114246] [11/12/13/14 Regression] ICE: verify_gimple failed: invalid argument to gimple call with __builtin_memcpy()

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114246

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-bisection

--- Comment #2 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
GCC 9's dse got it correct:
```
  __builtin_memcpy (&MEM[(void *)&a + 1B], &b, 1);

```

[Bug tree-optimization/114246] [11/12/13/14 Regression] ICE: verify_gimple failed: invalid argument to gimple call with __builtin_memcpy()

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114246

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

[Bug tree-optimization/114246] [11/12/13/14 Regression] ICE: verify_gimple failed: invalid argument to gimple call with __builtin_memcpy()

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114246

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:0249744a9fe0775c2c895727aeebec4c59fd5f95

commit r14-9330-g0249744a9fe0775c2c895727aeebec4c59fd5f95
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Mar 6 09:02:31 2024 +0100

    tree-optimization/114246 - invalid call argument from DSE

    The following makes sure to strip type conversions added by
    build_fold_addr_expr before placing the result in a call argument.

            PR tree-optimization/114246
            * tree-ssa-dse.cc (increment_start_addr): Strip useless
            type conversions from the adjusted address.

            * gcc.dg/torture/pr114246.c: New testcase.

[Bug tree-optimization/114246] [11/12/13 Regression] ICE: verify_gimple failed: invalid argument to gimple call with __builtin_memcpy()

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114246

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[11/12/13/14 Regression]    |[11/12/13 Regression] ICE:
                   |ICE: verify_gimple failed:  |verify_gimple failed:
                   |invalid argument to gimple  |invalid argument to gimple
                   |call with                   |call with
                   |__builtin_memcpy()          |__builtin_memcpy()
           Priority|P3                          |P2
      Known to work|                            |14.0
      Known to fail|14.0                        |
           Keywords|needs-bisection             |ice-checking

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.

[Bug tree-optimization/114246] [11/12/13 Regression] ICE: verify_gimple failed: invalid argument to gimple call with __builtin_memcpy()

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114246

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|ice-checking                |

--- Comment #6 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
Note even without checking there is an ICE that happens during FRE with the
invalid IR. (so removing the ice-checking marker).

[Bug tree-optimization/114246] [11/12/13 Regression] ICE: verify_gimple failed: invalid argument to gimple call with __builtin_memcpy()

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114246

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Richard Biener
<rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:c4795316b2d92c9edd3d86ffa11425c82d1e379c

commit r13-8694-gc4795316b2d92c9edd3d86ffa11425c82d1e379c
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Mar 6 09:02:31 2024 +0100

    tree-optimization/114246 - invalid call argument from DSE

    The following makes sure to strip type conversions added by
    build_fold_addr_expr before placing the result in a call argument.

            PR tree-optimization/114246
            * tree-ssa-dse.cc (increment_start_addr): Strip useless
            type conversions from the adjusted address.

            * gcc.dg/torture/pr114246.c: New testcase.

    (cherry picked from commit 0249744a9fe0775c2c895727aeebec4c59fd5f95)