[Bug tree-optimization/114249] New: [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[Bug tree-optimization/114249] New: [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114249

            Bug ID: 114249
           Summary: [14 regression] ICE when building lvm2-2.03.22 (error:
                    invalid types in nop conversion)
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: sjames at gcc dot gnu.org
  Target Milestone: ---

Created attachment 57619
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57619&action=edit
libdm-deptree.i.xz

It ICEs on two different functions with -O2 vs -O3.

```
$ gcc -c ./libdm-deptree.i -O2
libdm-deptree.c: In function ‘dm_tree_preload_children’:
libdm-deptree.c:2894:5: error: invalid types in nop conversion
 2894 | int dm_tree_preload_children(struct dm_tree_node *dnode,
      |     ^~~~~~~~~~~~~~~~~~~~~~~~
unsigned int
<<< error >>>
_890 = (unsigned int) _1319;
during GIMPLE pass: slp
libdm-deptree.c:2894:5: internal compiler error: verify_gimple failed
0x559de62d4070 verify_gimple_in_cfg(function*, bool, bool)
       
/usr/src/debug/sys-devel/gcc-14.0.9999/gcc-14.0.9999/gcc/tree-cfg.cc:5663
0x559de784ba38 execute_function_todo
        /usr/src/debug/sys-devel/gcc-14.0.9999/gcc-14.0.9999/gcc/passes.cc:2088
0x559de784ba38 do_per_function
        /usr/src/debug/sys-devel/gcc-14.0.9999/gcc-14.0.9999/gcc/passes.cc:1687
0x559de784ba38 execute_todo
        /usr/src/debug/sys-devel/gcc-14.0.9999/gcc-14.0.9999/gcc/passes.cc:2142
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

```
$ gcc -c ./libdm-deptree.i -O3
libdm-deptree.c: In function ‘_load_node’:
libdm-deptree.c:2774:12: error: invalid types in nop conversion
 2774 | static int _load_node(struct dm_tree_node *dnode)
      |            ^~~~~~~~~~
unsigned int
<<< error >>>
_1341 = (unsigned int) _1452;
during GIMPLE pass: slp
libdm-deptree.c:2774:12: internal compiler error: verify_gimple failed
0x5568ddc14070 verify_gimple_in_cfg(function*, bool, bool)
       
/usr/src/debug/sys-devel/gcc-14.0.9999/gcc-14.0.9999/gcc/tree-cfg.cc:5663
0x5568df18ba38 execute_function_todo
        /usr/src/debug/sys-devel/gcc-14.0.9999/gcc-14.0.9999/gcc/passes.cc:2088
0x5568df18ba38 do_per_function
        /usr/src/debug/sys-devel/gcc-14.0.9999/gcc-14.0.9999/gcc/passes.cc:1687
0x5568df18ba38 execute_todo
        /usr/src/debug/sys-devel/gcc-14.0.9999/gcc-14.0.9999/gcc/passes.cc:2142
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://bugs.gentoo.org/> for instructions.
```

```
Using built-in specs.
COLLECT_GCC=gcc
COLLECT_LTO_WRAPPER=/usr/libexec/gcc/x86_64-pc-linux-gnu/14/lto-wrapper
Target: x86_64-pc-linux-gnu
Configured with:
/var/tmp/portage/sys-devel/gcc-14.0.9999/work/gcc-14.0.9999/configure
--host=x86_64-pc-linux-gnu --build=x86_64-pc-linux-gnu --prefix=/usr
--bindir=/usr/x86_64-pc-linux-gnu/gcc-bin/14
--includedir=/usr/lib/gcc/x86_64-pc-linux-gnu/14/include
--datadir=/usr/share/gcc-data/x86_64-pc-linux-gnu/14
--mandir=/usr/share/gcc-data/x86_64-pc-linux-gnu/14/man
--infodir=/usr/share/gcc-data/x86_64-pc-linux-gnu/14/info
--with-gxx-include-dir=/usr/lib/gcc/x86_64-pc-linux-gnu/14/include/g++-v14
--disable-silent-rules --disable-dependency-tracking
--with-python-dir=/share/gcc-data/x86_64-pc-linux-gnu/14/python
--enable-languages=c,c++,fortran,rust --enable-obsolete --enable-secureplt
--disable-werror --with-system-zlib --enable-nls --without-included-gettext
--disable-libunwind-exceptions --enable-checking=yes,extra,rtl
--with-bugurl=https://bugs.gentoo.org/ --with-pkgversion='Gentoo Hardened
14.0.9999 p, commit c8305c9bdf09abe3e2f89783fe62f2e4049468fa'
--with-gcc-major-version-only --enable-libstdcxx-time --enable-lto
--disable-libstdcxx-pch --enable-shared --enable-threads=posix
--enable-__cxa_atexit --enable-clocale=gnu --enable-multilib
--with-multilib-list=m32,m64 --disable-fixed-point --enable-targets=all
--enable-libgomp --disable-libssp --disable-libada --disable-cet
--disable-systemtap --enable-valgrind-annotations --disable-vtable-verify
--disable-libvtv --with-zstd --with-isl --disable-isl-version-check
--enable-default-pie --enable-host-pie --enable-host-bind-now
--enable-default-ssp --disable-fixincludes --with-build-config='bootstrap-O3
bootstrap-lto'
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.1 20240305 (experimental)
8776468d9e57ace5f832c1368243a6dbce9984d5 (Gentoo Hardened 14.0.9999 p, commit
c8305c9bdf09abe3e2f89783fe62f2e4049468fa)
```

[Bug tree-optimization/114249] [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114249

Andrew Pinski <pinskia at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |14.0
           Keywords|                            |ice-on-valid-code
                 CC|                            |pinskia at gcc dot gnu.org

[Bug tree-optimization/114249] [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114249

--- Comment #1 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
I think the different functions are due to inlining differences between -O2 and
-O3 and the ICE is due to code in _load_node as dm_tree_preload_children calls
_load_node .

[Bug tree-optimization/114249] [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114249

--- Comment #2 from Sam James <sjames at gcc dot gnu.org> ---
Reduced:
```
enum { SEG_THIN_POOL } read_only;
struct {
  unsigned skip_block_zeroing;
  unsigned ignore_discard;
  unsigned no_discard_passdown;
  unsigned error_if_no_space;
} _thin_pool_emit_segment_line_seg;
void dm_snprintf();
void _emit_segment() {
  int features =
      (_thin_pool_emit_segment_line_seg.error_if_no_space ? 1 : 0) +
      (read_only ? 1 : 0) +
      (_thin_pool_emit_segment_line_seg.ignore_discard ? 1 : 0) +
      (_thin_pool_emit_segment_line_seg.no_discard_passdown ? 1 : 0) +
      (_thin_pool_emit_segment_line_seg.skip_block_zeroing ? 1 : 0);
  dm_snprintf(features);
}
```

[Bug tree-optimization/114249] [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[pinskia at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114249

--- Comment #3 from Andrew Pinski <pinskia at gcc dot gnu.org> ---
This is a very recent failure since g:264e3ad419cf71b10e7951a23750ac3507e21df9
worked .

[Bug tree-optimization/114249] [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[sjames at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114249

--- Comment #4 from Sam James <sjames at gcc dot gnu.org> ---
my guess is r14-9316-g7890836de20912

[Bug tree-optimization/114249] [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114249

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2024-03-06
     Ever confirmed|0                           |1

--- Comment #5 from Richard Biener <rguenth at gcc dot gnu.org> ---
Mine.

[Bug tree-optimization/114249] [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114249

--- Comment #6 from Richard Biener <rguenth at gcc dot gnu.org> ---
*** Bug 114250 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/114249] [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114249

--- Comment #7 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:3a910114fdb2aa76495c4c748acf6b9c7fbecc89

commit r14-9331-g3a910114fdb2aa76495c4c748acf6b9c7fbecc89
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Mar 6 09:25:15 2024 +0100

    tree-optimization/114249 - ICE with BB reduction vectorization

    When we scrap the last def of an odd lane numbered BB reduction
    we can end up recording a pattern def which will later wreck
    code generation.  The following puts this logic where it better
    belongs, avoiding this issue.

            PR tree-optimization/114249
            * tree-vect-slp.cc (vect_build_slp_instance): Move making
            a BB reduction lane number even ...
            (vect_slp_check_for_roots): ... here to avoid leaking
            pattern defs.

            * gcc.dg/vect/bb-slp-pr114249.c: New testcase.

[Bug tree-optimization/114249] [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114249

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #8 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed.

[Bug tree-optimization/114249] [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114249

--- Comment #9 from Richard Biener <rguenth at gcc dot gnu.org> ---
*** Bug 114251 has been marked as a duplicate of this bug. ***

[Bug tree-optimization/114249] [14 regression] ICE when building lvm2-2.03.22 (error: invalid types in nop conversion)

[patrick at rivosinc dot com]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114249

Patrick O'Neill <patrick at rivosinc dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |patrick at rivosinc dot com

--- Comment #10 from Patrick O'Neill <patrick at rivosinc dot com> ---
*** Bug 114259 has been marked as a duplicate of this bug. ***