[Bug modula2/114294] New: expression causes ICE

[Bug modula2/114294] New: expression causes ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114294

            Bug ID: 114294
           Summary: expression causes ICE
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: gaius at gcc dot gnu.org
  Target Milestone: ---

gm2 ICE occurs if:


MODULE example ;

FROM NumberIO IMPORT WriteInt ;

TYPE
   multidimarray = ARRAY [0..2] OF ARRAY [0..2] OF REAL ;

PROCEDURE foo (VAR c : multidimarray) ;
BEGIN
  WriteInt(1 + HIGH(c[0]), 0)
END foo ;

VAR
   bar: multidimarray ;
BEGIN
   foo (bar)
END example.

[Bug modula2/114294] expression causes ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114294

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-03-10
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Confirmed on gm2-14 (and reported broken in gm2-13).

[Bug modula2/114294] expression causes ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114294

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 57704
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57704&action=edit
Proposed fix

The proposed fix was to assign a type to the result constant created by HIGH.
The call to PutConst was missing.

[Bug modula2/114294] expression causes ICE

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114294

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:6dbf0d252f69ab2924256e6778ba7dc55d5b6915

commit r14-9483-g6dbf0d252f69ab2924256e6778ba7dc55d5b6915
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Thu Mar 14 19:09:34 2024 +0000

    PR modula2/114294 expression causes ICE

    This patch fixes an ICE when encountering an expression:
    1 + HIGH (a[0]).  The fix was to assign a type to the constant
    created by BuildConstHighFromSym in M2Quads.mod.

    gcc/m2/ChangeLog:

            PR modula2/114294
            * gm2-compiler/M2Quads.mod (BuildConstHighFromSym):
            Call PutConst to assign the type Cardinal in the result
            constant.

    gcc/testsuite/ChangeLog:

            PR modula2/114294
            * gm2/pim/pass/log: Removed.
            * gm2/pim/pass/highexp.mod: New test.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/114294] expression causes ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114294

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing now that the patch has been applied.