public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug c/114364] New: Untranslatable string 'in intervening code'
@ 2024-03-16 15:28 roland.illig at gmx dot de
2024-03-16 15:32 ` [Bug c/114364] " roland.illig at gmx dot de
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: roland.illig at gmx dot de @ 2024-03-16 15:28 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114364
Bug ID: 114364
Summary: Untranslatable string 'in intervening code'
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Keywords: diagnostic
Severity: normal
Priority: P3
Component: c
Assignee: unassigned at gcc dot gnu.org
Reporter: roland.illig at gmx dot de
Target Milestone: ---
From c-family/c-omp.cc:
> error_at (LOCATION_OR (eloc, loc),
> "variable %qD used %s is bound "
> "in intervening code", bad, context);
As a translator, I have no chance of translating 'in intervening code'.
Sentence fragments must not be embedded using %s, as other natural languages
differ structurally.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/114364] Untranslatable string 'in intervening code'
2024-03-16 15:28 [Bug c/114364] New: Untranslatable string 'in intervening code' roland.illig at gmx dot de
@ 2024-03-16 15:32 ` roland.illig at gmx dot de
2024-03-16 16:00 ` jakub at gcc dot gnu.org
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: roland.illig at gmx dot de @ 2024-03-16 15:32 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114364
--- Comment #1 from Roland Illig <roland.illig at gmx dot de> ---
Oops, I misinterpreted the code, as 'in intervening code' is indeed
translatable, but 'as loop variable' isn't, so the bug report is still valid.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/114364] Untranslatable string 'in intervening code'
2024-03-16 15:28 [Bug c/114364] New: Untranslatable string 'in intervening code' roland.illig at gmx dot de
2024-03-16 15:32 ` [Bug c/114364] " roland.illig at gmx dot de
@ 2024-03-16 16:00 ` jakub at gcc dot gnu.org
2024-03-17 21:45 ` roland.illig at gmx dot de
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-03-16 16:00 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114364
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Ever confirmed|0 |1
Assignee|unassigned at gcc dot gnu.org |jakub at gcc dot gnu.org
Last reconfirmed| |2024-03-16
--- Comment #2 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Created attachment 57716
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57716&action=edit
gcc14-pr1164364.patch
Untested fix.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/114364] Untranslatable string 'in intervening code'
2024-03-16 15:28 [Bug c/114364] New: Untranslatable string 'in intervening code' roland.illig at gmx dot de
2024-03-16 15:32 ` [Bug c/114364] " roland.illig at gmx dot de
2024-03-16 16:00 ` jakub at gcc dot gnu.org
@ 2024-03-17 21:45 ` roland.illig at gmx dot de
2024-03-19 8:13 ` cvs-commit at gcc dot gnu.org
2024-03-19 8:20 ` jakub at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: roland.illig at gmx dot de @ 2024-03-17 21:45 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114364
--- Comment #3 from Roland Illig <roland.illig at gmx dot de> ---
The diff looks good to me. Untested.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/114364] Untranslatable string 'in intervening code'
2024-03-16 15:28 [Bug c/114364] New: Untranslatable string 'in intervening code' roland.illig at gmx dot de
` (2 preceding siblings ...)
2024-03-17 21:45 ` roland.illig at gmx dot de
@ 2024-03-19 8:13 ` cvs-commit at gcc dot gnu.org
2024-03-19 8:20 ` jakub at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-03-19 8:13 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114364
--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jakub Jelinek <jakub@gcc.gnu.org>:
https://gcc.gnu.org/g:8959ab63f1881a8a4b1921b946d4ea3986bf1063
commit r14-9534-g8959ab63f1881a8a4b1921b946d4ea3986bf1063
Author: Jakub Jelinek <jakub@redhat.com>
Date: Tue Mar 19 09:10:26 2024 +0100
openmp: Make c_omp_check_loop_binding_exprs diagnostics translatable
[PR114364]
c_omp_check_loop_binding_exprs with check_loop_binding_expr was composing
diagnostics from a format string with %s that provided additional words
(but not
keywords). That is a big no no for translations, both because the
translator
can't choose a different word order and because the %s part wasn't
translated
at all (would need to use _("...") to get translated), so this patch
rewrites it
such that the whole messages are in the format strings.
2024-03-19 Jakub Jelinek <jakub@redhat.com>
PR c/114364
* c-omp.cc (enum check_loop_binding_expr_ctx): New type.
(check_loop_binding_expr): Remove context argument, add ctx
argument with check_loop_binding_expr_ctx type at the end. Don't
create diagnostic message from multiple pieces.
(c_omp_check_loop_binding_exprs): Adjust callers.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Bug c/114364] Untranslatable string 'in intervening code'
2024-03-16 15:28 [Bug c/114364] New: Untranslatable string 'in intervening code' roland.illig at gmx dot de
` (3 preceding siblings ...)
2024-03-19 8:13 ` cvs-commit at gcc dot gnu.org
@ 2024-03-19 8:20 ` jakub at gcc dot gnu.org
4 siblings, 0 replies; 6+ messages in thread
From: jakub at gcc dot gnu.org @ 2024-03-19 8:20 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114364
Jakub Jelinek <jakub at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|ASSIGNED |RESOLVED
--- Comment #5 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
Fixed.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-03-19 8:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-16 15:28 [Bug c/114364] New: Untranslatable string 'in intervening code' roland.illig at gmx dot de
2024-03-16 15:32 ` [Bug c/114364] " roland.illig at gmx dot de
2024-03-16 16:00 ` jakub at gcc dot gnu.org
2024-03-17 21:45 ` roland.illig at gmx dot de
2024-03-19 8:13 ` cvs-commit at gcc dot gnu.org
2024-03-19 8:20 ` jakub at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).