[Bug modula2/114422] New: Attempting to declare a set of unknown type causes ICE

[Bug modula2/114422] New: Attempting to declare a set of unknown type causes ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114422

            Bug ID: 114422
           Summary: Attempting to declare a set of unknown type causes ICE
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: gaius at gcc dot gnu.org
  Target Milestone: ---

The following program causes an ICE in cc1gm2:

MODULE badset3 ;

TYPE
   userset = SET OF CHAR ;
VAR
   set: userset ;
BEGIN
   set := unknown {}
END badset3.

[Bug modula2/114422] Attempting to declare a set of unknown type causes ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114422

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-03-21
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Confirmed and the bug is a malformed error message directive.

[Bug modula2/114422] Attempting to declare a set of unknown type causes ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114422

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 57761
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57761&action=edit
Proposed fix

Here is the proposed fix containing the escaped error message and three
regression tests.

[Bug modula2/114422] Attempting to declare a set of unknown type causes ICE

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114422

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:1542e8a44cc35e63233d3557afbf501c5ff84c55

commit r14-9602-g1542e8a44cc35e63233d3557afbf501c5ff84c55
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Fri Mar 22 01:47:31 2024 +0000

    PR modula2/114422 Attempting to declare a set of unknown type causes ICE

    This patch corrects an error message directive which did not
    escape the { character.  The patch also contains test cases
    to stress set declaration errors.

    gcc/m2/ChangeLog:

            PR modula2/114422
            * gm2-compiler/M2Quads.mod (BuildConstructor): Add escape
            character.

    gcc/testsuite/ChangeLog:

            PR modula2/114422
            * gm2/iso/fail/badset.mod: New test.
            * gm2/iso/fail/badset2.mod: New test.
            * gm2/iso/fail/badset3.mod: New test.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/114422] Attempting to declare a set of unknown type causes ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114422

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #4 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing now that the patch has been applied.