[Bug target/114432] New: [13 Regression] ICE in connect_traces, at dwarf2cfi.cc:3079 on s390x-linux-gnu

[Bug target/114432] New: [13 Regression] ICE in connect_traces, at dwarf2cfi.cc:3079 on s390x-linux-gnu

[doko at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114432

            Bug ID: 114432
           Summary: [13 Regression] ICE in connect_traces, at
                    dwarf2cfi.cc:3079 on s390x-linux-gnu
           Product: gcc
           Version: 13.2.1
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: target
          Assignee: unassigned at gcc dot gnu.org
          Reporter: doko at gcc dot gnu.org
  Target Milestone: ---

seen with the gcc-13 branch on s390x-linux-gnu, didn't try trunk yet, fails in
Ubuntu with --with-arch=z13 --with-tune=z16, but succeeds in Debian with
--with-arch=z196.

[...]
during RTL pass: dwarf2
+===========================GNAT BUG DETECTED==============================+
| 13.2.0 (s390x-linux-gnu) in connect_traces, at dwarf2cfi.cc:3079 |
| Error detected around
/<<PKGBUILDDIR>>/src/alog-protected_containers.adb:69:11|
| Compiling /<<PKGBUILDDIR>>/src/alog-protected_containers.adb|
| Please submit a bug report; see https://gcc.gnu.org/bugs/ . |
| Use a subject line meaningful to you and us to track the bug. |
| Include the entire contents of this bug box in the report. |
| Include the exact command that you entered. |
| Also include sources listed below. |
+==========================================================================+

Please include these source files with error report
Note that list may not be accurate in some cases,
so please double check that the problem can still
be reproduced with the set of files listed.
Consider also -gnatd.n switch (see debug.adb).

/<<PKGBUILDDIR>>/src/alog-protected_containers.adb
/<<PKGBUILDDIR>>/src/alog-protected_containers.ads
/<<PKGBUILDDIR>>/src/alog.ads
/<<PKGBUILDDIR>>/src/alog-log_request.ads

raised TYPES.UNRECOVERABLE_ERROR : comperr.adb:414

   compilation of alog-protected_containers.adb failed


full build log at
https://launchpad.net/ubuntu/+source/libalog/0.6.2-5/+build/27944112

[Bug target/114432] [13 Regression] ICE in connect_traces, at dwarf2cfi.cc:3079 on s390x-linux-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114432

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |13.3

[Bug target/114432] [13 Regression] ICE in connect_traces, at dwarf2cfi.cc:3079 on s390x-linux-gnu

[stefansf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114432

Stefan Schulze Frielinghaus <stefansf at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-4-17
                 CC|                            |stefansf at gcc dot gnu.org

--- Comment #1 from Stefan Schulze Frielinghaus <stefansf at gcc dot gnu.org> ---
Reproducible via

$ wget https://www.codelabs.ch/download/libalog-0.6.2.tar.bz2
$ tar xf libalog-0.6.2.tar.bz2
$ gcc -c -x ada -gnatA -gnatygAdISuxo -gnatVa -gnatwal -gnatf -fstack-check
-gnato -g -O2 -fno-omit-frame-pointer -mbackchain -gnatwe -fPIC
libalog-0.6.2/src/alog-active_logger.adb

Started with r12-4926-g79fe28d2c4b785
Confirmed on trunk r14-9999-g9c7cf5d71f0716

@Doko does Debian use -mbackchain? I can reproduce this on Ubuntu even for z196
but -mbackchain and -fstack-check are required in order to fail. For me 12.3 is
failing, too, which matches with my bisect. How did you test 12.3?

[Bug target/114432] [13 Regression] ICE in connect_traces, at dwarf2cfi.cc:3079 on s390x-linux-gnu

[stefansf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114432

--- Comment #2 from Stefan Schulze Frielinghaus <stefansf at gcc dot gnu.org> ---
Fails for function alog.active_logger.logging_taskT and trace 2 whose heads are

(gdb) call debug(ti->head)
(code_label 48 573 49 152 (nil) [2 uses])

(gdb) call debug(ti->eh_head)
(insn 57 765 58 (set (reg/f:DI 14 %r14 [orig:74 _39 ] [74])
        (mem/f:DI (reg/f:DI 10 %r10 [orig:123 _task ] [123]) [0
_task_25(D)->parent+0 S8 A64]))
"libalog-0.6.2/src/alog-active_logger.adb":252:33 discrim 2 1477 {*movdi_64}
     (expr_list:REG_EH_REGION (const_int 6 [0x6])
        (nil)))

Looking at the trace there exists no insn with a ARGS_SIZE note which is why

gcc_assert (!ti->args_size_undefined || ti->args_size_defined_for_eh);

fails.

[Bug target/114432] [13 Regression] ICE in connect_traces, at dwarf2cfi.cc:3079 on s390x-linux-gnu

[stefansf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114432

--- Comment #3 from Stefan Schulze Frielinghaus <stefansf at gcc dot gnu.org> ---
Created attachment 57971
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57971&action=edit
dwarf2cfi dump for alog-active_logger.adb

[Bug target/114432] [13 Regression] ICE in connect_traces, at dwarf2cfi.cc:3079 on s390x-linux-gnu

[stefansf at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114432

--- Comment #4 from Stefan Schulze Frielinghaus <stefansf at gcc dot gnu.org> ---
Ignore the previous comment.  With -fstack-check and -mbackchain we have for
trace 2 an incoming edge from trace 1 (fallthrough) where
cur_trace->end_true_args_size == 48 and from further incoming edges as e.g.
from trace 7 where cur_trace->end_true_args_size == 0 which is why the
args_size is supposed to be undefined.

Interestingly, trace 2 resides in the function body whereas trace 7 resides in
the epilogue, i.e., we have a jump from the epilogue into the function body:

(note 597 810 634 NOTE_INSN_PROLOGUE_END)
...
(insn 635 677 566 (set (reg/f:DI 15 %r15)
        (plus:DI (reg/f:DI 15 %r15)
            (const_int 8216 [0x2018])))
"libalog-0.6.2/src/alog-active_logger.adb":244:4 1481 {*la_64}
     (expr_list:REG_ARGS_SIZE (const_int 48 [0x30])
        (nil)))
...
(code_label 48 573 49 152 (nil) [2 uses])
...
(note 673 768 599 NOTE_INSN_EPILOGUE_BEG)
...
(insn 159 163 160 (set (reg/f:DI 15 %r15)
        (reg/f:DI 6 %r6 [orig:79 saved_stack.186_50 ] [79]))
"libalog-0.6.2/src/alog-active_logger.adb":260:0 discrim 10 1477 {*movdi_64}
     (expr_list:REG_DEAD (reg/f:DI 6 %r6 [orig:79 saved_stack.186_50 ] [79])
        (expr_list:REG_ARGS_SIZE (const_int 0 [0])
            (nil))))
...
(jump_insn 645 644 646 (set (pc)
        (label_ref 48)) 2170 {*jump64}
     (nil)
 -> 48)

This is also the case when -fno-shrink-wrap is used.

[Bug target/114432] [13/14/15 Regression] ICE in connect_traces, at dwarf2cfi.cc:3079 on s390x-linux-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114432

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[13 Regression] ICE in      |[13/14/15 Regression] ICE
                   |connect_traces, at          |in connect_traces, at
                   |dwarf2cfi.cc:3079 on        |dwarf2cfi.cc:3079 on
                   |s390x-linux-gnu             |s390x-linux-gnu
           Priority|P3                          |P2

[Bug target/114432] [13/14/15 Regression] ICE in connect_traces, at dwarf2cfi.cc:3079 on s390x-linux-gnu

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114432

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|2024-04-17 00:00:00         |2024-05-08
     Ever confirmed|0                           |1
             Status|UNCONFIRMED                 |NEW