[Bug modula2/114443] New: missing quote causes ICE

[Bug modula2/114443] New: missing quote causes ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114443

            Bug ID: 114443
           Summary: missing quote causes ICE
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: gaius at gcc dot gnu.org
  Target Milestone: ---

A missing end of string quote causes an ICE, for example:

MODULE missingquote ;

CONST
   MyConst = 'foobar

BEGIN

END missingquote.

$ gm2 missingquote.mod 
missingquote.mod:4:   MyConst = 'foobar
missingquote.mod:4:             ^^^^^^^
missingquote.mod:4:missing terminating quote, '
cc1gm2: internal compiler error: in libc_abort, at m2/mc-boot-ch/Glibc.c:161

[Bug modula2/114443] missing quote causes ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114443

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-03-23
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

[Bug modula2/114443] missing quote causes ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114443

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 57788
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57788&action=edit
Proposed fix

This patch inserts a missing quotation at the end of a line
if required (after an appropiate error message is generated).

gcc/m2/ChangeLog:

        * m2.flex: Call AddTokCharStar with a stringtok if
        end of line is reached without a closing quote.

gcc/testsuite/ChangeLog:

        * gm2/pim/fail/missingquote.mod: New test.

[Bug modula2/114443] missing quote causes ICE

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114443

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:c8a343f9f8602f4e6c1b385ddbeb58572234d447

commit r14-9647-gc8a343f9f8602f4e6c1b385ddbeb58572234d447
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Sat Mar 23 15:49:23 2024 +0000

    PR modula2/114443 missing quote cause ICE

    This patch inserts a missing quotation at the end of a line
    if required (after an appropiate error message is generated).

    gcc/m2/ChangeLog:

            PR modula2/114443
            * m2.flex: Call AddTokCharStar with a stringtok if
            end of line is reached without a closing quote.

    gcc/testsuite/ChangeLog:

            PR modula2/114443
            * gm2/pim/fail/missingquote.mod: New test.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/114443] missing quote causes ICE

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114443

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing now the patch has been applied.