public inbox for gcc-bugs@sourceware.org
help / color / mirror / Atom feed
* [Bug modula2/114517] New: gm2 does not allow comparion operator # in the first column
@ 2024-03-28 13:56 gaius at gcc dot gnu.org
2024-03-28 14:58 ` [Bug modula2/114517] " cvs-commit at gcc dot gnu.org
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: gaius at gcc dot gnu.org @ 2024-03-28 13:56 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114517
Bug ID: 114517
Summary: gm2 does not allow comparion operator # in the first
column
Product: gcc
Version: 14.0
Status: UNCONFIRMED
Severity: normal
Priority: P3
Component: modula2
Assignee: gaius at gcc dot gnu.org
Reporter: gaius at gcc dot gnu.org
Target Milestone: ---
gm2 allows # cpp directives, but this conflicts with the # comparison operator
(in the unlikely event that # appears in an expression in the first column).
It would be more appropriate to:
(i) by default allow # in the first column to be interpreted as a cpp
directive (given this is the most likely desired use).
(ii) allow users to supply -fno-cpp to turn off this default and cc1gm2
should interpret '#' as a comparison operator.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug modula2/114517] gm2 does not allow comparion operator # in the first column
2024-03-28 13:56 [Bug modula2/114517] New: gm2 does not allow comparion operator # in the first column gaius at gcc dot gnu.org
@ 2024-03-28 14:58 ` cvs-commit at gcc dot gnu.org
2024-03-28 15:03 ` gaius at gcc dot gnu.org
2024-03-28 15:03 ` gaius at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: cvs-commit at gcc dot gnu.org @ 2024-03-28 14:58 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114517
--- Comment #1 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:
https://gcc.gnu.org/g:04799f03e8d01b903295ef3a100a0117b7ddbf5e
commit r14-9709-g04799f03e8d01b903295ef3a100a0117b7ddbf5e
Author: Gaius Mulley <(no_default)>
Date: Thu Mar 28 14:57:49 2024 +0000
PR modula2/114517 gm2 does not allow comparison operator hash in column one
This patch allows -fno-cpp to be supplied to gm2. Without this patch
it causes an ICE. The patch allows -fno-cpp to turn off cpp flags.
These are tested in m2.flex to decide whether a change of state is
allowed (enabling handling of #line directives).
gcc/ChangeLog:
PR modula2/114517
* doc/gm2.texi: Mention gm2 treats a # in the first column
as a preprocessor directive unless -fno-cpp is supplied.
gcc/m2/ChangeLog:
PR modula2/114517
* gm2-compiler/M2Options.def (SetCpp): Add comment.
(GetCpp): Move after SetCpp.
(GetLineDirectives): New procedure function.
* gm2-compiler/M2Options.mod (GetLineDirectives): New
procedure function.
* gm2-gcc/m2options.h (M2Options_GetLineDirectives): New
prototype.
* gm2-lang.cc (gm2_langhook_init_options): OPT_fcpp only
assert if !value.
* m2.flex: Test GetLineDirectives before changing to LINE0
state.
gcc/testsuite/ChangeLog:
PR modula2/114517
* gm2/cpp/fail/hashfirstcolumn2.mod: New test.
* gm2/imports/fail/imports-fail.exp: New test.
* gm2/imports/fail/localmodule2.mod: New test.
* gm2/imports/run/pass/localmodule.mod: New test.
Signed-off-by: Gaius Mulley <(no_default)>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug modula2/114517] gm2 does not allow comparion operator # in the first column
2024-03-28 13:56 [Bug modula2/114517] New: gm2 does not allow comparion operator # in the first column gaius at gcc dot gnu.org
2024-03-28 14:58 ` [Bug modula2/114517] " cvs-commit at gcc dot gnu.org
@ 2024-03-28 15:03 ` gaius at gcc dot gnu.org
2024-03-28 15:03 ` gaius at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: gaius at gcc dot gnu.org @ 2024-03-28 15:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114517
Gaius Mulley <gaius at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Ever confirmed|0 |1
Last reconfirmed| |2024-03-28
--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Confirmed.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Bug modula2/114517] gm2 does not allow comparion operator # in the first column
2024-03-28 13:56 [Bug modula2/114517] New: gm2 does not allow comparion operator # in the first column gaius at gcc dot gnu.org
2024-03-28 14:58 ` [Bug modula2/114517] " cvs-commit at gcc dot gnu.org
2024-03-28 15:03 ` gaius at gcc dot gnu.org
@ 2024-03-28 15:03 ` gaius at gcc dot gnu.org
2 siblings, 0 replies; 4+ messages in thread
From: gaius at gcc dot gnu.org @ 2024-03-28 15:03 UTC (permalink / raw)
To: gcc-bugs
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114517
Gaius Mulley <gaius at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |FIXED
--- Comment #3 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing now that the patch has been applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-03-28 15:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-28 13:56 [Bug modula2/114517] New: gm2 does not allow comparion operator # in the first column gaius at gcc dot gnu.org
2024-03-28 14:58 ` [Bug modula2/114517] " cvs-commit at gcc dot gnu.org
2024-03-28 15:03 ` gaius at gcc dot gnu.org
2024-03-28 15:03 ` gaius at gcc dot gnu.org
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).