[Bug modula2/114565] New: progress trace would be useful to isolate ICE for users

[Bug modula2/114565] New: progress trace would be useful to isolate ICE for users

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114565

            Bug ID: 114565
           Summary: progress trace would be useful to isolate ICE for
                    users
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: modula2
          Assignee: gaius at gcc dot gnu.org
          Reporter: gaius at gcc dot gnu.org
  Target Milestone: ---

As suggested on the gm2 mailing list, it would be helpful if gm2 had an option
to dump progress to help users isolate source code which triggers an ICE.

[Bug modula2/114565] progress trace would be useful to isolate ICE for users

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114565

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2024-04-02
             Status|UNCONFIRMED                 |ASSIGNED
     Ever confirmed|0                           |1

--- Comment #1 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Confirmed.

[Bug modula2/114565] progress trace would be useful to isolate ICE for users

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114565

--- Comment #2 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 57851
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57851&action=edit
Proposed patch

Here is a proposed patch which introduces the option -fm2-debug-trace=
and allows a comma separated list containing: quad,token,line,all.
It currently dumps progress to stdout and this would be expected to change once
PR113836 is complete.  In short the progress data should also be dumped to file
and flushed on every newline.

[Bug modula2/114565] progress trace would be useful to isolate ICE for users

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114565

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #57851|0                           |1
        is obsolete|                            |

--- Comment #3 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Created attachment 57852
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57852&action=edit
Proposed patch v3

Here is an improved patch which has been generated against the current tip of
the repository and also contains performance fixes for the token trace.

[Bug modula2/114565] progress trace would be useful to isolate ICE for users

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114565

--- Comment #4 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Gaius Mulley <gaius@gcc.gnu.org>:

https://gcc.gnu.org/g:1bafa6a3fdbb53651ffa5d854c2341c487bf3269

commit r14-9764-g1bafa6a3fdbb53651ffa5d854c2341c487bf3269
Author: Gaius Mulley <gaiusmod2@gmail.com>
Date:   Tue Apr 2 23:47:42 2024 +0100

    PR modula2/114565 progress trace would be useful to isolate ICE for users

    This patch introduces the internal option -fm2-debug-trace= which can
    be given a comma separated list of filter terms.  Currently it allows:
    all,line,token,quad.  The patch allows users to trace the progress of
    cc1gm2 so that source which causes an ICE can be reduced.  Once
    PR113836 is complete it is expected that the trace information will be
    written to file.

    gcc/m2/ChangeLog:

            PR modula2/114565
            * gm2-compiler/M2GenGCC.mod (CodeStatement): Test
            GetDebugTraceQuad before calling DisplayQuad.
            * gm2-compiler/M2LexBuf.mod (NumberIO): Import CardToStr.
            (GetToken): Test GetDebugTraceToken before writing the
            token number or token line.
            * gm2-compiler/M2Options.def (SetDebugTraceQuad): Rename to
            (SetM2DebugTraceFilter): ...this.
            (SetDebugTraceAPI): Remove.
            (GetDebugTraceQuad): New procedure function.
            (GetDebugTraceTree): Ditto.
            (GetDebugTraceToken): Ditto.
            (GetDebugTraceLine): Ditto.
            (GetDebugFunctionLineNumbers): Ditto.
            * gm2-compiler/M2Options.mod (DebugFunctionLineNumbers): New
            boolean variable.
            (DebugTraceQuad): Ditto.
            (DebugTraceTree): Ditto.
            (DebugTraceLine): Ditto.
            (DebugTraceToken): Ditto.
            (errors1): New procedure.
            (SetDebugTraceQuad): Remove.
            (SetM2DebugTraceFilter): New procedure implemented.
            (SetM2DebugTrace): Ditto.
            (GetDebugTraceQuad): Ditto.
            (GetDebugTraceToken ): Ditto.
            (GetDebugTraceLine): Ditto.
            (SetDebugTraceLine): Remove.
            * gm2-compiler/M2Quads.mod (GenQuadOTrash): Test
            GetDebugTraceQuad and call DisplayQuad.
            (GenQuadOTypetok): Ditto.
            * gm2-compiler/SymbolTable.mod: Replace
            DebugFunctionLineNumbers with GetDebugFunctionLineNumbers.
            * gm2-gcc/init.cc (_M2_M2LangDump_init): Add prototype.
            (init_PerCompilationInit): Add call.
            * gm2-gcc/m2misc.cc (m2misc_cerror): New function.
            (m2misc_error): Ditto.
            * gm2-gcc/m2misc.def (error): New procedure.
            (cerror): Ditto.
            * gm2-gcc/m2misc.h (m2misc_cerror): New prototype.
            (m2misc_error): Ditto.
            * gm2-gcc/m2options.h (M2Options_SetDebugTraceQuad): New
            prototype.
            (M2Options_SetDebugTraceAPI): Remove.
            (M2Options_GetDebugTraceToken): New prototype.
            (M2Options_GetDebugTraceLine): Ditto.
            (M2Options_SetDebugFunctionLineNumbers): Ditto.
            (M2Options_GetDebugFunctionLineNumbers): Ditto.
            (M2Options_SetM2DebugTraceFilter): Ditto.
            * gm2-lang.cc (gm2_langhook_init_options): Remove
            OPT_fdebug_trace_quad case.
            Remove OPT_fdebug_trace_api case.
            Add OPT_fm2_debug_trace_ case.
            * lang.opt (fm2-debug-trace): New option.
            (fdebug-trace-api): Remove.
            (fdebug-trace-quad): Remove.
            * m2.flex (m2flex_M2Error): Check s for NULL.
            (skipnewline): New function.
            (consumeLine): Call traceline.

    Signed-off-by: Gaius Mulley <gaiusmod2@gmail.com>

[Bug modula2/114565] progress trace would be useful to isolate ICE for users

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114565

--- Comment #5 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing now the patch has been bootstrapped, compared and applied.

[Bug modula2/114565] progress trace would be useful to isolate ICE for users

[gaius at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114565

Gaius Mulley <gaius at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from Gaius Mulley <gaius at gcc dot gnu.org> ---
Closing.