[Bug libstdc++/114633] New: [14 Regression] A cross to rx fails to build in libstdc++

[Bug libstdc++/114633] New: [14 Regression] A cross to rx fails to build in libstdc++

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114633

            Bug ID: 114633
           Summary: [14 Regression] A cross to rx fails to build in
                    libstdc++
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: libstdc++
          Assignee: unassigned at gcc dot gnu.org
          Reporter: rguenth at gcc dot gnu.org
  Target Milestone: ---

[  911s] libtool: compile: 
/home/abuild/rpmbuild/BUILD/gcc-14.0.1+git9687/obj-x
86_64-suse-linux/./gcc/xgcc -shared-libgcc
-B/home/abuild/rpmbuild/BUILD/gcc-14.
0.1+git9687/obj-x86_64-suse-linux/./gcc -nostdinc++
-L/home/abuild/rpmbuild/BUIL
D/gcc-14.0.1+git9687/obj-x86_64-suse-linux/rx-elf/libstdc++-v3/src
-L/home/abuil
d/rpmbuild/BUILD/gcc-14.0.1+git9687/obj-x86_64-suse-linux/rx-elf/libstdc++-v3/sr
c/.libs
-L/home/abuild/rpmbuild/BUILD/gcc-14.0.1+git9687/obj-x86_64-suse-linux/r
x-elf/libstdc++-v3/libsupc++/.libs -B/usr/rx-elf/bin/ -B/usr/rx-elf/lib/
-isyste
m /usr/rx-elf/include -isystem /usr/rx-elf/sys-include
--sysroot=/usr/rx-elf/sys
-root -I/home/abuild/rpmbuild/BUILD/gcc-14.0.1+git9687/libstdc++-v3/../libgcc
-I
/home/abuild/rpmbuild/BUILD/gcc-14.0.1+git9687/obj-x86_64-suse-linux/rx-elf/libs
tdc++-v3/include/rx-elf
-I/home/abuild/rpmbuild/BUILD/gcc-14.0.1+git9687/obj-x86
_64-suse-linux/rx-elf/libstdc++-v3/include
-I/home/abuild/rpmbuild/BUILD/gcc-14.
0.1+git9687/libstdc++-v3/libsupc++ -std=gnu++20 -fno-implicit-templates -Wall
-W
extra -Wwrite-strings -Wcast-qual -Wabi=2 -fdiagnostics-show-location=once
-fran
dom-seed=tzdb.lo -fimplicit-templates -g -O2 -c
../../../../../libstdc++-v3/src/
c++20/tzdb.cc -o tzdb.o
[  911s] In file included from
/home/abuild/rpmbuild/BUILD/gcc-14.0.1+git9687/ob
j-x86_64-suse-linux/rx-elf/libstdc++-v3/include/chrono:3360,
[  911s]                  from
../../../../../libstdc++-v3/src/c++20/tzdb.cc:31:
[  911s]
/home/abuild/rpmbuild/BUILD/gcc-14.0.1+git9687/obj-x86_64-suse-linux/rx
-elf/libstdc++-v3/include/bits/chrono_io.h: In member function
'std::basic_istre
am<_CharT2, _Traits2>&
std::chrono::__detail::_Parser<_Duration>::operator()(std
::basic_istream<_CharT2, _Traits2>&, const _CharT*,
std::__cxx11::basic_string<_
CharT2, _Traits2, _Alloc>*, std::chrono::minutes*)':
[  911s]
/home/abuild/rpmbuild/BUILD/gcc-14.0.1+git9687/obj-x86_64-suse-linux/rx
-elf/libstdc++-v3/include/bits/chrono_io.h:3692:59: error: no matching function 
for call to 'from_chars(char*&, char*&, long double&, std::chars_format)'
[  911s]  3692 |                           auto [ptr, ec] =
std::from_chars(__fi
rst, __last,
[  911s]       |                                           
~~~~~~~~~~~~~~~^~~~~
~~~~~~~~~~~~
[  911s]  3693 |                                                           
__va
l, fixed);
[  911s]       |                                                           
~~~~
~~~~~~~~~


This is building with

../configure 'CFLAGS= -O2 -funwind-tables -fasynchronous-unwind-tables
-fstack-clash-protection -Werror=return-type -g' 'CXXFLAGS= -O2 -funwind-tables
-fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g'
'XCFLAGS= -O2 -funwind-tables -fasynchronous-unwind-tables
-fstack-clash-protection -Werror=return-type -g' 'TCFLAGS= -O2 -funwind-tables
-fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -g'
'GDCFLAGS= -O2 -funwind-tables -fasynchronous-unwind-tables
-fstack-clash-protection -g' --prefix=/usr --infodir=/usr/share/info
--mandir=/usr/share/man --libdir=/usr/lib64 --libexecdir=/usr/lib64
--enable-languages=c,c++ --enable-checking=release --disable-werror
--with-gxx-include-dir=/usr/include/c++/14
--with-libstdcxx-zoneinfo=/usr/share/zoneinfo --enable-ssp --disable-libssp
--disable-libvtv --enable-cet=auto --disable-libcc1 --disable-plugin
--with-bugurl=https://bugs.opensuse.org/ '--with-pkgversion=SUSE Linux'
--with-slibdir=/usr/rx-elf/sys-root/lib64 --with-system-zlib
--enable-libstdcxx-allocator=new --disable-libstdcxx-pch
--enable-version-specific-runtime-libs --with-gcc-major-version-only
--enable-linux-futex --enable-gnu-indirect-function --program-suffix=-14
--program-prefix=rx-elf- --target=rx-elf --disable-nls
--with-sysroot=/usr/rx-elf/sys-root --with-build-sysroot=/usr/rx-elf/sys-root
--with-build-time-tools=/usr/rx-elf/bin --with-newlib --disable-bootstrap
--enable-link-serialization --disable-libsanitizer --build=x86_64-suse-linux
--host=x86_64-suse-linux

against newlib 4.3.0.20230120

[Bug libstdc++/114633] [14 Regression] A cross to rx fails to build in libstdc++

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114633

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Target|                            |rx-elf
           Keywords|                            |build
   Target Milestone|---                         |14.0

[Bug libstdc++/114633] [14 Regression] A cross to rx fails to build in libstdc++

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114633

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2024-04-08
     Ever confirmed|0                           |1

--- Comment #1 from Jonathan Wakely <redi at gcc dot gnu.org> ---
--- a/libstdc++-v3/include/bits/chrono_io.h
+++ b/libstdc++-v3/include/bits/chrono_io.h
@@ -3685,6 +3685,7 @@ namespace __detail
                      if (!__is_failed(__err)) [[likely]]
                        {
                          long double __val{};
+#if __cpp_lib_to_chars
                          string __str = std::move(__buf).str();
                          auto __first = __str.data();
                          auto __last = __first + __str.size();
@@ -3694,6 +3695,9 @@ namespace __detail
                          if ((bool)ec || ptr != __last) [[unlikely]]
                            __err |= ios_base::failbit;
                          else
+#else
+                         if (__buf >> __val)
+#endif
                            {
                              duration<long double> __fs(__val);
                              if constexpr (__is_floating)

[Bug libstdc++/114633] [14 Regression] A cross to rx fails to build in libstdc++

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114633

--- Comment #2 from Richard Biener <rguenth at gcc dot gnu.org> ---
That makes the build succeed!

[Bug libstdc++/114633] [14 Regression] A cross to rx fails to build in libstdc++

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114633

--- Comment #3 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Jonathan Wakely <redi@gcc.gnu.org>:

https://gcc.gnu.org/g:92b38ec84f2990d217f036dc6c5a32cde5ecfb93

commit r14-9879-g92b38ec84f2990d217f036dc6c5a32cde5ecfb93
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Apr 8 17:37:32 2024 +0100

    libstdc++: Fix build for targets without FP std::from_chars [PR114633]

    If the faster std::from_chars is not supported for floating-point types
    then just extract the value from the stream using operator>>.

    This fixes a build error for targets where __cpp_lib_to_chars is not
    defined.

    libstdc++-v3/ChangeLog:

            PR libstdc++/114633
            * include/bits/chrono_io.h (_Parser::operator()) <'S'>: Use
            stream extraction if std::from_chars is not available.

[Bug libstdc++/114633] [14 Regression] A cross to rx fails to build in libstdc++

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114633

Jonathan Wakely <redi at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Jonathan Wakely <redi at gcc dot gnu.org> ---
Thanks for testing it, so this should be fixed now.