[Bug tree-optimization/114672] New: during GIMPLE pass: widening_mul ICE: verify_gimple failed: type mismatch in 'widen_mult_plus_expr' at -O2

[Bug tree-optimization/114672] New: during GIMPLE pass: widening_mul ICE: verify_gimple failed: type mismatch in 'widen_mult_plus_expr' at -O2

[zsojka at seznam dot cz]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114672

            Bug ID: 114672
           Summary: during GIMPLE pass: widening_mul ICE: verify_gimple
                    failed: type mismatch in 'widen_mult_plus_expr' at -O2
           Product: gcc
           Version: 14.0
            Status: UNCONFIRMED
          Keywords: ice-on-valid-code
          Severity: normal
          Priority: P3
         Component: tree-optimization
          Assignee: unassigned at gcc dot gnu.org
          Reporter: zsojka at seznam dot cz
  Target Milestone: ---
              Host: x86_64-pc-linux-gnu
            Target: aarch64-unknown-linux-gnu

Created attachment 57914
  --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=57914&action=edit
reduced testcase

Compiler output:
$ aarch64-unknown-linux-gnu-gcc -O2 testcase.c 
testcase.c: In function 'foo':
testcase.c:9:1: error: type mismatch in 'widen_mult_plus_expr'
    9 | foo ()
      | ^~~
<unnamed-signed:60>
signed int
signed int
<unnamed-signed:60>
_8 = WIDEN_MULT_PLUS_EXPR <_11, _12, _1>;
during GIMPLE pass: widening_mul
testcase.c:9:1: internal compiler error: verify_gimple failed
0x1396f9d verify_gimple_in_cfg(function*, bool, bool)
        /repo/gcc-trunk/gcc/tree-cfg.cc:5663
0x1202df4 execute_function_todo
        /repo/gcc-trunk/gcc/passes.cc:2089
0x120334e execute_todo
        /repo/gcc-trunk/gcc/passes.cc:2143
Please submit a full bug report, with preprocessed source (by using
-freport-bug).
Please include the complete backtrace with any bug report.
See <https://gcc.gnu.org/bugs/> for instructions.

$ aarch64-unknown-linux-gnu-gcc -v
Using built-in specs.
COLLECT_GCC=/repo/gcc-trunk/binary-latest-aarch64/bin/aarch64-unknown-linux-gnu-gcc
COLLECT_LTO_WRAPPER=/repo/gcc-trunk/binary-trunk-r14-9877-20240409180605-g1f719aa7c0d-checking-yes-rtl-df-extra-aarch64/bin/../libexec/gcc/aarch64-unknown-linux-gnu/14.0.1/lto-wrapper
Target: aarch64-unknown-linux-gnu
Configured with: /repo/gcc-trunk//configure --enable-languages=c,c++
--enable-valgrind-annotations --disable-nls --enable-checking=yes,rtl,df,extra
--with-cloog --with-ppl --with-isl
--with-sysroot=/usr/aarch64-unknown-linux-gnu --build=x86_64-pc-linux-gnu
--host=x86_64-pc-linux-gnu --target=aarch64-unknown-linux-gnu
--with-ld=/usr/bin/aarch64-unknown-linux-gnu-ld
--with-as=/usr/bin/aarch64-unknown-linux-gnu-as --enable-libsanitizer
--disable-libstdcxx-pch
--prefix=/repo/gcc-trunk//binary-trunk-r14-9877-20240409180605-g1f719aa7c0d-checking-yes-rtl-df-extra-aarch64
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 14.0.1 20240409 (experimental) (GCC)

[Bug tree-optimization/114672] during GIMPLE pass: widening_mul ICE: verify_gimple failed: type mismatch in 'widen_mult_plus_expr' at -O2

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114672

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Assignee|unassigned at gcc dot gnu.org      |rguenth at gcc dot gnu.org
   Last reconfirmed|                            |2024-04-10
             Status|UNCONFIRMED                 |ASSIGNED

--- Comment #1 from Richard Biener <rguenth at gcc dot gnu.org> ---
Confirmed.

[Bug tree-optimization/114672] during GIMPLE pass: widening_mul ICE: verify_gimple failed: type mismatch in 'widen_mult_plus_expr' at -O2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114672

--- Comment #2 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by Richard Biener <rguenth@gcc.gnu.org>:

https://gcc.gnu.org/g:912753cc5f18d786e334dd425469fa7f93155661

commit r14-9892-g912753cc5f18d786e334dd425469fa7f93155661
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Apr 10 10:33:40 2024 +0200

    tree-optimization/114672 - WIDEN_MULT_PLUS_EXPR type mismatch

    The following makes sure to restrict WIDEN_MULT*_EXPR to a mode
    precision final compute type as the mode is used to find the optab
    and type checking chokes when seeing bit-precisions later which
    would likely also not properly expanded to RTL.

            PR tree-optimization/114672
            * tree-ssa-math-opts.cc (convert_plusminus_to_widen): Only
            allow mode-precision results.

            * gcc.dg/torture/pr114672.c: New testcase.

[Bug tree-optimization/114672] during GIMPLE pass: widening_mul ICE: verify_gimple failed: type mismatch in 'widen_mult_plus_expr' at -O2

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114672

Richard Biener <rguenth at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Known to work|                            |14.0

--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
Fixed on trunk sofar.

[Bug tree-optimization/114672] during GIMPLE pass: widening_mul ICE: verify_gimple failed: type mismatch in 'widen_mult_plus_expr' at -O2

[ricbal02 at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114672

Richard Ball <ricbal02 at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ricbal02 at gcc dot gnu.org

--- Comment #4 from Richard Ball <ricbal02 at gcc dot gnu.org> ---
Confirmed bug exists in gcc-12 and gcc-13. Backport applies cleanly and fixes
the issue. I'll request a backport on the mailing list

[Bug tree-optimization/114672] during GIMPLE pass: widening_mul ICE: verify_gimple failed: type mismatch in 'widen_mult_plus_expr' at -O2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114672

--- Comment #5 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-13 branch has been updated by Richard Ball
<ricbal02@gcc.gnu.org>:

https://gcc.gnu.org/g:0d625dc1bffd885b04eb90ff48a6d34acacc3e0b

commit r13-8676-g0d625dc1bffd885b04eb90ff48a6d34acacc3e0b
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Apr 10 10:33:40 2024 +0200

    tree-optimization/114672 - WIDEN_MULT_PLUS_EXPR type mismatch

    The following makes sure to restrict WIDEN_MULT*_EXPR to a mode
    precision final compute type as the mode is used to find the optab
    and type checking chokes when seeing bit-precisions later which
    would likely also not properly expanded to RTL.

            PR tree-optimization/114672
            * tree-ssa-math-opts.cc (convert_plusminus_to_widen): Only
            allow mode-precision results.

            * gcc.dg/torture/pr114672.c: New testcase.

    (cherry picked from commit 912753cc5f18d786e334dd425469fa7f93155661)

[Bug tree-optimization/114672] during GIMPLE pass: widening_mul ICE: verify_gimple failed: type mismatch in 'widen_mult_plus_expr' at -O2

[cvs-commit at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114672

--- Comment #6 from GCC Commits <cvs-commit at gcc dot gnu.org> ---
The releases/gcc-12 branch has been updated by Richard Ball
<ricbal02@gcc.gnu.org>:

https://gcc.gnu.org/g:87e37c72cfb153d65ac8b26d6f2d1fe155818318

commit r12-10410-g87e37c72cfb153d65ac8b26d6f2d1fe155818318
Author: Richard Biener <rguenther@suse.de>
Date:   Wed Apr 10 10:33:40 2024 +0200

    tree-optimization/114672 - WIDEN_MULT_PLUS_EXPR type mismatch

    The following makes sure to restrict WIDEN_MULT*_EXPR to a mode
    precision final compute type as the mode is used to find the optab
    and type checking chokes when seeing bit-precisions later which
    would likely also not properly expanded to RTL.

            PR tree-optimization/114672
            * tree-ssa-math-opts.cc (convert_plusminus_to_widen): Only
            allow mode-precision results.

            * gcc.dg/torture/pr114672.c: New testcase.

    (cherry picked from commit 912753cc5f18d786e334dd425469fa7f93155661)